linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build warnings after merge of the final tree (mtd tree related)
@ 2010-10-26  2:49 Stephen Rothwell
  2010-10-26  8:51 ` David Woodhouse
  2010-10-26  9:15 ` David Woodhouse
  0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2010-10-26  2:49 UTC (permalink / raw)
  To: David Woodhouse; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2553 bytes --]

Hi David,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) produced these warnings:

In file included from drivers/mtd/mtdchar.c:36:
include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
In file included from drivers/mtd/chips/chipreg.c:11:
include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
In file included from drivers/mtd/chips/cfi_probe.c:17:
include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
In file included from drivers/mtd/chips/cfi_probe.c:18:
include/linux/mtd/cfi.h:75:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
In file included from drivers/mtd/maps/physmap_of.c:21:
include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
In file included from drivers/mtd/chips/cfi_cmdset_0002.c:36:
include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
In file included from drivers/mtd/chips/cfi_cmdset_0002.c:38:
include/linux/mtd/cfi.h:75:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
In file included from drivers/mtd/chips/cfi_util.c:23:
include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
In file included from drivers/mtd/chips/cfi_util.c:24:
include/linux/mtd/cfi.h:75:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
In file included from drivers/mtd/chips/gen_probe.c:11:
include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
In file included from drivers/mtd/chips/gen_probe.c:12:
include/linux/mtd/cfi.h:75:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
In file included from drivers/mtd/chips/jedec_probe.c:21:
include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
In file included from drivers/mtd/chips/jedec_probe.c:22:
include/linux/mtd/cfi.h:75:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.

I am not sure where these came from ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build warnings after merge of the final tree (mtd tree related)
  2010-10-26  2:49 linux-next: build warnings after merge of the final tree (mtd tree related) Stephen Rothwell
@ 2010-10-26  8:51 ` David Woodhouse
  2010-10-26 10:49   ` David Woodhouse
  2010-10-26  9:15 ` David Woodhouse
  1 sibling, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2010-10-26  8:51 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

On Tue, 2010-10-26 at 13:49 +1100, Stephen Rothwell wrote:
> 
> I am not sure where these came from ... 

It's a config issue. You have chosen to build NOR flash support.

NOR flash can be wired up many ways. It could be four 8-bit chips in
parallel in a 32-bit bus, two 16-bit chips in a 32-bit bus, 2 8-bit
chips in a 16-bit bus, one 16-bit chip in a 16-bus bus, etc...

You have elected to support *none* of those configurations. No NOR chip
support can work.

You don't get to choose individual geometry options unless you set
CONFIG_MTD_ADV_OPTIONS -- by default you get a fully versatile driver
which can cope with anything at runtime.

I'll build a ppc44x_defconfig and work out what's going wrong. I'd
expect this kind of thing with randconfig, but not a defconfig.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build warnings after merge of the final tree (mtd tree related)
  2010-10-26  2:49 linux-next: build warnings after merge of the final tree (mtd tree related) Stephen Rothwell
  2010-10-26  8:51 ` David Woodhouse
@ 2010-10-26  9:15 ` David Woodhouse
  1 sibling, 0 replies; 6+ messages in thread
From: David Woodhouse @ 2010-10-26  9:15 UTC (permalink / raw)
  To: Stephen Rothwell, H Hartley Sweeten; +Cc: linux-next, linux-kernel

On Tue, 2010-10-26 at 13:49 +1100, Stephen Rothwell wrote:
> Hi David,
> 
> After merging the final tree, today's linux-next build (powerpc
> ppc44x_defconfig) produced these warnings:
> 
> In file included from drivers/mtd/mtdchar.c:36:
> include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"

432dc821c90114f9b0e00f6752a700e937516ade is the first bad commit
commit 432dc821c90114f9b0e00f6752a700e937516ade
Author: H Hartley Sweeten <hartleys@visionengravers.com>
Date:   Thu Aug 19 18:18:21 2010 -0700

    mtd: cleanup Kconfig dependencies

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build warnings after merge of the final tree (mtd tree related)
  2010-10-26  8:51 ` David Woodhouse
@ 2010-10-26 10:49   ` David Woodhouse
  2010-10-26 16:43     ` H Hartley Sweeten
  0 siblings, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2010-10-26 10:49 UTC (permalink / raw)
  To: Stephen Rothwell, H Hartley Sweeten; +Cc: linux-next, linux-kernel

On Tue, 2010-10-26 at 09:51 +0100, David Woodhouse wrote:
> On Tue, 2010-10-26 at 13:49 +1100, Stephen Rothwell wrote:
> > 
> > I am not sure where these came from ... 
> 
> It's a config issue. You have chosen to build NOR flash support.
> 
> NOR flash can be wired up many ways. It could be four 8-bit chips in
> parallel in a 32-bit bus, two 16-bit chips in a 32-bit bus, 2 8-bit
> chips in a 16-bit bus, one 16-bit chip in a 16-bus bus, etc...
> 
> You have elected to support *none* of those configurations. No NOR chip
> support can work.
> 
> You don't get to choose individual geometry options unless you set
> CONFIG_MTD_ADV_OPTIONS -- by default you get a fully versatile driver
> which can cope with anything at runtime.
> 
> I'll build a ppc44x_defconfig and work out what's going wrong. I'd
> expect this kind of thing with randconfig, but not a defconfig.

Fixed by reverting the offending commit:
http://git.infradead.org/mtd-2.6.git/commitdiff/6411bf6cd

Thanks.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: linux-next: build warnings after merge of the final tree (mtd tree related)
  2010-10-26 10:49   ` David Woodhouse
@ 2010-10-26 16:43     ` H Hartley Sweeten
  2010-10-26 16:48       ` David Woodhouse
  0 siblings, 1 reply; 6+ messages in thread
From: H Hartley Sweeten @ 2010-10-26 16:43 UTC (permalink / raw)
  To: David Woodhouse, Stephen Rothwell; +Cc: linux-next, linux-kernel

On Tuesday, October 26, 2010 3:50 AM, David Woodhouse wrote:
> On Tue, 2010-10-26 at 09:51 +0100, David Woodhouse wrote:
>> On Tue, 2010-10-26 at 13:49 +1100, Stephen Rothwell wrote:
>>> 
>>> I am not sure where these came from ... 
>> 
>> It's a config issue. You have chosen to build NOR flash support.
>> 
>> NOR flash can be wired up many ways. It could be four 8-bit chips in
>> parallel in a 32-bit bus, two 16-bit chips in a 32-bit bus, 2 8-bit
>> chips in a 16-bit bus, one 16-bit chip in a 16-bus bus, etc...
>> 
>> You have elected to support *none* of those configurations. No NOR chip
>> support can work.
>> 
>> You don't get to choose individual geometry options unless you set
>> CONFIG_MTD_ADV_OPTIONS -- by default you get a fully versatile driver
>> which can cope with anything at runtime.
>> 
>> I'll build a ppc44x_defconfig and work out what's going wrong. I'd
>> expect this kind of thing with randconfig, but not a defconfig.
>
> Fixed by reverting the offending commit:
> http://git.infradead.org/mtd-2.6.git/commitdiff/6411bf6cd

I didn't follow the logic for the MTD_MAP_BANK_WIDTH_* all the way thru.

Honestly I still don't quite get it.  If MTD_CFI_GEOMETRY is n wouldn't
all the MTD_MAP_BANK_WIDTH_* also be n?

Sorry about the trouble.

Hartley

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: linux-next: build warnings after merge of the final tree (mtd tree related)
  2010-10-26 16:43     ` H Hartley Sweeten
@ 2010-10-26 16:48       ` David Woodhouse
  0 siblings, 0 replies; 6+ messages in thread
From: David Woodhouse @ 2010-10-26 16:48 UTC (permalink / raw)
  To: H Hartley Sweeten; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Tue, 2010-10-26 at 11:43 -0500, H Hartley Sweeten wrote:
> I didn't follow the logic for the MTD_MAP_BANK_WIDTH_* all the way thru.
> 
> Honestly I still don't quite get it.  If MTD_CFI_GEOMETRY is n wouldn't
> all the MTD_MAP_BANK_WIDTH_* also be n? 

config MTD_CFI_GEOMETRY
        bool "Specific CFI Flash geometry selection"
        depends on MTD_CFI_ADV_OPTIONS
        help
          This option does not affect the code directly, but will enable
          some other configuration options which would allow you to reduce
          the size of the kernel by including support for only certain
          arrangements of CFI chips. If unsure, say 'N' and all options
          which are supported by the current code will be enabled.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-10-26 16:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-26  2:49 linux-next: build warnings after merge of the final tree (mtd tree related) Stephen Rothwell
2010-10-26  8:51 ` David Woodhouse
2010-10-26 10:49   ` David Woodhouse
2010-10-26 16:43     ` H Hartley Sweeten
2010-10-26 16:48       ` David Woodhouse
2010-10-26  9:15 ` David Woodhouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).