From: Joe Perches <joe@perches.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
sedat.dilek@gmail.com, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86 <platform-driver-x86@vger.kernel.org>
Subject: Re: linux-next: Tree for April 4 [BROKEN thinkpad_acpi]
Date: Mon, 04 Apr 2011 05:49:29 -0700 [thread overview]
Message-ID: <1301921369.1941.29.camel@Joe-Laptop> (raw)
In-Reply-To: <20110404122225.GA15883@srcf.ucam.org>
On Mon, 2011-04-04 at 13:22 +0100, Matthew Garrett wrote:
> On Mon, Apr 04, 2011 at 11:21:43AM +0200, Sedat Dilek wrote:
> > My build breaked today.
> > Looks like the issue was introduced by commit
> > 2af915b1eda9a671973256540035f8a6da1d57b4:
> > "thinkpad_acpi: Convert printks to pr_<level>"
> Yes, this seems to break the non-debug case. Joe, can you take a look?
Sorry 'bout that. I only compiled it allyesconfig.
It's vdbg_printk no_printk verification.
#ifdef CONFIG_THINKPAD_ACPI_DEBUG
#define vdbg_printk dbg_printk
static const char *str_supported(int is_supported);
#else
#define vdbg_printk(a_dbg_level, format, arg...) \
no_printk(format, ##arg)
#endif
Two ways to handle this.
1: add
static inline const char *str_supported(int is_supported) { return ""; }
to the #else
2: Remove no_printk verification and return it to do {} while (0)
Do you have a preference?
next prev parent reply other threads:[~2011-04-04 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 9:21 linux-next: Tree for April 4 [BROKEN thinkpad_acpi] Sedat Dilek
2011-04-04 12:22 ` Matthew Garrett
2011-04-04 12:49 ` Joe Perches [this message]
2011-04-04 13:00 ` Matthew Garrett
2011-04-04 13:44 ` Sedat Dilek
2011-04-04 14:44 ` Sedat Dilek
2011-04-04 15:02 ` Joe Perches
2011-04-04 15:08 ` Sedat Dilek
2011-04-04 15:13 ` Joe Perches
2011-04-05 12:27 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301921369.1941.29.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).