From: Matthew Garrett <mjg@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
sedat.dilek@gmail.com, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86 <platform-driver-x86@vger.kernel.org>,
ibm-acpi@hmh.eng.br
Subject: Re: linux-next: Tree for April 4 [BROKEN thinkpad_acpi]
Date: Mon, 4 Apr 2011 14:00:36 +0100 [thread overview]
Message-ID: <20110404130036.GB16669@srcf.ucam.org> (raw)
In-Reply-To: <1301921369.1941.29.camel@Joe-Laptop>
On Mon, Apr 04, 2011 at 05:49:29AM -0700, Joe Perches wrote:
> It's vdbg_printk no_printk verification.
>
> #ifdef CONFIG_THINKPAD_ACPI_DEBUG
> #define vdbg_printk dbg_printk
> static const char *str_supported(int is_supported);
> #else
> #define vdbg_printk(a_dbg_level, format, arg...) \
> no_printk(format, ##arg)
> #endif
>
> Two ways to handle this.
>
> 1: add
> static inline const char *str_supported(int is_supported) { return ""; }
> to the #else
>
> 2: Remove no_printk verification and return it to do {} while (0)
>
> Do you have a preference?
I don't. Henrique?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-04-04 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 9:21 linux-next: Tree for April 4 [BROKEN thinkpad_acpi] Sedat Dilek
2011-04-04 12:22 ` Matthew Garrett
2011-04-04 12:49 ` Joe Perches
2011-04-04 13:00 ` Matthew Garrett [this message]
2011-04-04 13:44 ` Sedat Dilek
2011-04-04 14:44 ` Sedat Dilek
2011-04-04 15:02 ` Joe Perches
2011-04-04 15:08 ` Sedat Dilek
2011-04-04 15:13 ` Joe Perches
2011-04-05 12:27 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404130036.GB16669@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=ibm-acpi@hmh.eng.br \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).