* [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
@ 2011-11-14 23:57 Fenghua Yu
2011-11-15 6:04 ` Srivatsa S. Bhat
0 siblings, 1 reply; 3+ messages in thread
From: Fenghua Yu @ 2011-11-14 23:57 UTC (permalink / raw)
To: Linus Torvalds, Ingo Molnar, Andrew Morton, Rusty Russell, Rafael
Cc: linux-kernel, linux-pm, linux-next, Fenghua Yu
From: Fenghua Yu <fenghua.yu@intel.com>
Add __init for functions alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
because they are only called during boot time.
Add static for function cpu_hotplug_pm_sync_init() because its scope is limited
in this file only.
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
v2: Change a function name typo in the title.
kernel/cpu.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 563f136..cf915b8 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -470,7 +470,7 @@ out:
cpu_maps_update_done();
}
-static int alloc_frozen_cpus(void)
+static int __init alloc_frozen_cpus(void)
{
if (!alloc_cpumask_var(&frozen_cpus, GFP_KERNEL|__GFP_ZERO))
return -ENOMEM;
@@ -543,7 +543,7 @@ cpu_hotplug_pm_callback(struct notifier_block *nb,
}
-int cpu_hotplug_pm_sync_init(void)
+static int __init cpu_hotplug_pm_sync_init(void)
{
pm_notifier(cpu_hotplug_pm_callback, 0);
return 0;
--
1.6.0.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
2011-11-14 23:57 [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init() Fenghua Yu
@ 2011-11-15 6:04 ` Srivatsa S. Bhat
2011-11-15 20:17 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Srivatsa S. Bhat @ 2011-11-15 6:04 UTC (permalink / raw)
To: Fenghua Yu
Cc: Linus Torvalds, Ingo Molnar, Andrew Morton, Rusty Russell,
Rafael J. Wysocki, linux-kernel, linux-pm, linux-next
On 11/15/2011 05:27 AM, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
>
> Add __init for functions alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
> because they are only called during boot time.
>
> Add static for function cpu_hotplug_pm_sync_init() because its scope is limited
> in this file only.
>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Thanks,
Srivatsa S. Bhat
> ---
> v2: Change a function name typo in the title.
>
> kernel/cpu.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 563f136..cf915b8 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -470,7 +470,7 @@ out:
> cpu_maps_update_done();
> }
>
> -static int alloc_frozen_cpus(void)
> +static int __init alloc_frozen_cpus(void)
> {
> if (!alloc_cpumask_var(&frozen_cpus, GFP_KERNEL|__GFP_ZERO))
> return -ENOMEM;
> @@ -543,7 +543,7 @@ cpu_hotplug_pm_callback(struct notifier_block *nb,
> }
>
>
> -int cpu_hotplug_pm_sync_init(void)
> +static int __init cpu_hotplug_pm_sync_init(void)
> {
> pm_notifier(cpu_hotplug_pm_callback, 0);
> return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
2011-11-15 6:04 ` Srivatsa S. Bhat
@ 2011-11-15 20:17 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2011-11-15 20:17 UTC (permalink / raw)
To: Srivatsa S. Bhat
Cc: Fenghua Yu, Linus Torvalds, Ingo Molnar, Andrew Morton,
Rusty Russell, linux-kernel, linux-pm, linux-next
On Tuesday, November 15, 2011, Srivatsa S. Bhat wrote:
> On 11/15/2011 05:27 AM, Fenghua Yu wrote:
> > From: Fenghua Yu <fenghua.yu@intel.com>
> >
> > Add __init for functions alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
> > because they are only called during boot time.
> >
> > Add static for function cpu_hotplug_pm_sync_init() because its scope is limited
> > in this file only.
> >
> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
>
> Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Well, I guess I can take this one, right? Any objections from anyone?
Rafael
> > ---
> > v2: Change a function name typo in the title.
> >
> > kernel/cpu.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/cpu.c b/kernel/cpu.c
> > index 563f136..cf915b8 100644
> > --- a/kernel/cpu.c
> > +++ b/kernel/cpu.c
> > @@ -470,7 +470,7 @@ out:
> > cpu_maps_update_done();
> > }
> >
> > -static int alloc_frozen_cpus(void)
> > +static int __init alloc_frozen_cpus(void)
> > {
> > if (!alloc_cpumask_var(&frozen_cpus, GFP_KERNEL|__GFP_ZERO))
> > return -ENOMEM;
> > @@ -543,7 +543,7 @@ cpu_hotplug_pm_callback(struct notifier_block *nb,
> > }
> >
> >
> > -int cpu_hotplug_pm_sync_init(void)
> > +static int __init cpu_hotplug_pm_sync_init(void)
> > {
> > pm_notifier(cpu_hotplug_pm_callback, 0);
> > return 0;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-15 20:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-14 23:57 [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init() Fenghua Yu
2011-11-15 6:04 ` Srivatsa S. Bhat
2011-11-15 20:17 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).