From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@tonian.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Michal Marek <mmarek@suse.cz>,
NFS list <linux-nfs@vger.kernel.org>,
open-osd <osd-dev@open-osd.org>
Subject: Re: ore: FIX breakage when MISC_FILESYSTEMS is not set
Date: Tue, 29 Nov 2011 17:38:42 -0500 [thread overview]
Message-ID: <1322606322.11286.30.camel@lade.trondhjem.org> (raw)
In-Reply-To: <1322606193.11286.28.camel@lade.trondhjem.org>
On Tue, 2011-11-29 at 17:36 -0500, Trond Myklebust wrote:
> On Tue, 2011-11-29 at 14:22 -0800, Boaz Harrosh wrote:
> > On 11/29/2011 09:33 AM, Trond Myklebust wrote:
> > > On Tue, 2011-11-29 at 14:21 +0200, Benny Halevy wrote:
> > >> On 2011-11-29 02:13, Boaz Harrosh wrote:
> >
> > >>>
> > >>> The solution is to force all users of ORE (exofs, nfs) to manually
> > >>> select everything auto-magically selected before.
> > >>
> > >> How about using "depend ORE" rather than "select ORE"?
> > >
> > > Right. Make PNFS_OBJLAYOUT and EXOFS_FS depend on ASYNC_XOR (or select
> > > it) and then make ORE depend on EXOFS_FS || PNFS_OBJLAYOUT.
> > >
> > > There should be no need to add the 'select ORE'...
> > >
> >
> > No! guys!
> >
> > One it will not solve my problem because any
> > solution that needs to inspect exofs/Kconfig file will
> > not work if MISC_FILESYSTEMS is not selected and your
> > solutions involve that.
>
> Then move ORE _out_ of MISC_FILESYSTEMS. There is no reason why it needs
> to be there as long as the things it depends on are there.
Should read:
There is no reason why ORE needs to depend on MISC_FILESYSTEMS. Only
EXOFS_FS needs that...
> > And two:
> > All the user needs to do is Select NFS4.1 everything
> > else should be done automatically. He should not need
> > to go to misc-filesystems and select ORE so he can have
> > pnfs-objects. That's a nightmare.
>
> The solution I proposed didn't involve having the user select anything
> other than NFSv4.1 and possibly ASYNC_XOR.
>
> > And anyway the current Kernel rule is that a user of a library
> > needs to select it and all it's dependencies, because select
> > is not recursive. Now I devised a little skim that can avoid
>
> ...and this is _my_ nightmare. I dont' _want_ these selects anywhere in
> the NFS subsystem.
next prev parent reply other threads:[~2011-11-29 23:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 6:43 linux-next: Tree for Nov 24 Stephen Rothwell
2011-11-24 18:50 ` linux-next: Tree for Nov 24 (fs/pnfs vs. exofs) Randy Dunlap
2011-11-29 0:09 ` Boaz Harrosh
[not found] ` <4ED422CC.60706-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2011-11-29 0:13 ` ore: FIX breakage when MISC_FILESYSTEMS is not set Boaz Harrosh
2011-11-29 12:21 ` Benny Halevy
2011-11-29 17:33 ` Trond Myklebust
[not found] ` <1322588023.4174.28.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2011-11-29 22:22 ` Boaz Harrosh
[not found] ` <4ED55B3B.9050207-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2011-11-29 22:36 ` Trond Myklebust
2011-11-29 22:38 ` Trond Myklebust [this message]
2011-11-29 23:33 ` Boaz Harrosh
2011-11-29 23:39 ` Randy Dunlap
2011-11-29 23:30 ` Boaz Harrosh
2011-11-29 23:35 ` [PATCH v3] " Boaz Harrosh
2011-11-30 1:00 ` [osd-dev] " Boaz Harrosh
2011-11-30 18:00 ` Randy Dunlap
2011-11-30 8:31 ` Michal Marek
2011-11-30 16:32 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322606322.11286.30.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=bhalevy@tonian.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=osd-dev@open-osd.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).