From: Michal Marek <mmarek@suse.cz>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
NFS list <linux-nfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Benny Halevy <bhalevy@tonian.com>,
linux-next@vger.kernel.org, open-osd <osd-dev@open-osd.org>
Subject: Re: [PATCH v3] ore: FIX breakage when MISC_FILESYSTEMS is not set
Date: Wed, 30 Nov 2011 09:31:29 +0100 [thread overview]
Message-ID: <4ED5E9E1.9050709@suse.cz> (raw)
In-Reply-To: <4ED56C59.208@panasas.com>
Dne 30.11.2011 00:35, Boaz Harrosh napsal(a):
>
> As Reported by Randy Dunlap
>
> When MISC_FILESYSTEMS is not enabled:
>
> fs/built-in.o: In function `objio_alloc_io_state':
> objio_osd.c:(.text+0xcb525): undefined reference to `ore_get_rw_state'
> fs/built-in.o: In function `_write_done':
> objio_osd.c:(.text+0xcb58d): undefined reference to `ore_check_io'
> fs/built-in.o: In function `_read_done':
> ...
>
> When MISC_FILESYSTEMS, which is more of a GUI thing then anything else,
> is not selected. exofs/Kconfig is never examined during Kconfig,
> and it can not do it's magic stuff to automatically select everything
> needed.
>
> We must split exofs/Kconfig in two. The ore one is always included.
> And the exofs one is left in it's old place in the menu.
>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
> fs/Kconfig | 2 ++
> fs/exofs/Kconfig | 11 -----------
> fs/exofs/ore.Kconfig | 12 ++++++++++++
> 3 files changed, 14 insertions(+), 11 deletions(-)
> create mode 100644 fs/exofs/ore.Kconfig
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 5f4c45d..fd7bfef 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -218,6 +218,8 @@ source "fs/exofs/Kconfig"
>
> endif # MISC_FILESYSTEMS
>
> +source "fs/exofs/ore.Kconfig"
> +
I suggest you name it Kconfig.ore. We have a couple of Kconfig.* files
in the tree, so let's be consistent.
Michal
next prev parent reply other threads:[~2011-11-30 8:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 6:43 linux-next: Tree for Nov 24 Stephen Rothwell
2011-11-24 18:50 ` linux-next: Tree for Nov 24 (fs/pnfs vs. exofs) Randy Dunlap
2011-11-29 0:09 ` Boaz Harrosh
[not found] ` <4ED422CC.60706-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2011-11-29 0:13 ` ore: FIX breakage when MISC_FILESYSTEMS is not set Boaz Harrosh
2011-11-29 12:21 ` Benny Halevy
2011-11-29 17:33 ` Trond Myklebust
[not found] ` <1322588023.4174.28.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2011-11-29 22:22 ` Boaz Harrosh
[not found] ` <4ED55B3B.9050207-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2011-11-29 22:36 ` Trond Myklebust
2011-11-29 22:38 ` Trond Myklebust
2011-11-29 23:33 ` Boaz Harrosh
2011-11-29 23:39 ` Randy Dunlap
2011-11-29 23:30 ` Boaz Harrosh
2011-11-29 23:35 ` [PATCH v3] " Boaz Harrosh
2011-11-30 1:00 ` [osd-dev] " Boaz Harrosh
2011-11-30 18:00 ` Randy Dunlap
2011-11-30 8:31 ` Michal Marek [this message]
2011-11-30 16:32 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED5E9E1.9050709@suse.cz \
--to=mmarek@suse.cz \
--cc=Trond.Myklebust@netapp.com \
--cc=bhalevy@tonian.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).