[PATCH] cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile

[PATCH] cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile

[Paul Gortmaker]

Most of these have been purged years ago.  This one silently lived
on until commit 69349c2dc01c489eccaa4c472542c08e370c6d7e

    "kconfig: fix IS_ENABLED to not require all options to be defined"

In the above, we use some macro trickery to create a conditional that
is valid in CPP and in C usage.  However that trickery doesn't sit
well if you have the legacy "-traditional" flag enabled.  You'll get:

  AS      arch/cris/arch-v10/lib/checksum.o
In file included from <command-line>:4:0:
include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
make[2]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1

Everything builds fine w/o "-traditional" so simply drop it from this
location as well.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/arch/cris/arch-v10/lib/Makefile b/arch/cris/arch-v10/lib/Makefile
index 36e9a9c..725153e 100644
--- a/arch/cris/arch-v10/lib/Makefile
+++ b/arch/cris/arch-v10/lib/Makefile
@@ -2,8 +2,5 @@
 # Makefile for Etrax-specific library files..
 #
 
-
-EXTRA_AFLAGS := -traditional
-
 lib-y  = checksum.o checksumcopy.o string.o usercopy.o memset.o csumcpfruser.o
 
-- 
1.7.9.1

Re: [PATCH] cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile

[Jesper Nilsson]

On Wed, Apr 18, 2012 at 09:58:43PM +0200, Paul Gortmaker wrote:
> Most of these have been purged years ago.  This one silently lived
> on until commit 69349c2dc01c489eccaa4c472542c08e370c6d7e
> 
>     "kconfig: fix IS_ENABLED to not require all options to be defined"
> 
> In the above, we use some macro trickery to create a conditional that
> is valid in CPP and in C usage.  However that trickery doesn't sit
> well if you have the legacy "-traditional" flag enabled.  You'll get:
> 
>   AS      arch/cris/arch-v10/lib/checksum.o
> In file included from <command-line>:4:0:
> include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
> make[2]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1
> 
> Everything builds fine w/o "-traditional" so simply drop it from this
> location as well.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Agreed, I'll push this to the CRIS-tree. Thanks!

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com

Re: [PATCH] cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile

[Paul Gortmaker]

On 12-04-19 05:14 AM, Jesper Nilsson wrote:
> On Wed, Apr 18, 2012 at 09:58:43PM +0200, Paul Gortmaker wrote:
>> Most of these have been purged years ago.  This one silently lived
>> on until commit 69349c2dc01c489eccaa4c472542c08e370c6d7e
>>
>>     "kconfig: fix IS_ENABLED to not require all options to be defined"
>>
>> In the above, we use some macro trickery to create a conditional that
>> is valid in CPP and in C usage.  However that trickery doesn't sit
>> well if you have the legacy "-traditional" flag enabled.  You'll get:
>>
>>   AS      arch/cris/arch-v10/lib/checksum.o
>> In file included from <command-line>:4:0:
>> include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
>> make[2]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1
>>
>> Everything builds fine w/o "-traditional" so simply drop it from this
>> location as well.
>>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> Agreed, I'll push this to the CRIS-tree. Thanks!

Thanks, Please make sure it goes on your "for-3.4" branch,
since Linus took the kconfig change directly into 3.4 (i.e. it
is not specific to linux-next).

Paul.

> 
> /^JN - Jesper Nilsson