* [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 6:11 linux-next: Tree for Apr 16 Stephen Rothwell
@ 2012-04-16 19:50 ` Randy Dunlap
2012-04-16 22:20 ` Paul Gortmaker
` (2 more replies)
2012-04-16 19:51 ` [PATCH -next] wireless: TI wlxxx depends on MAC80211 Randy Dunlap
` (3 subsequent siblings)
4 siblings, 3 replies; 20+ messages in thread
From: Randy Dunlap @ 2012-04-16 19:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Andrew Morton, David Woodhouse, linux-mtd, Tim Hockin
From: Randy Dunlap <rdunlap@xenotime.net>
sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
is not enabled, so make it depend on PCI.
drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/maps/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20120416.orig/drivers/mtd/maps/Kconfig
+++ linux-next-20120416/drivers/mtd/maps/Kconfig
@@ -224,7 +224,7 @@ config MTD_CK804XROM
config MTD_SCB2_FLASH
tristate "BIOS flash chip on Intel SCB2 boards"
- depends on X86 && MTD_JEDECPROBE
+ depends on X86 && MTD_JEDECPROBE && PCI
help
Support for treating the BIOS flash chip on Intel SCB2 boards
as an MTD device - with this you can reprogram your BIOS.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
@ 2012-04-16 22:20 ` Paul Gortmaker
2012-04-17 1:25 ` Randy Dunlap
2012-04-25 11:05 ` Artem Bityutskiy
2012-04-25 15:33 ` Artem Bityutskiy
2 siblings, 1 reply; 20+ messages in thread
From: Paul Gortmaker @ 2012-04-16 22:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
David Woodhouse, linux-mtd, Tim Hockin
On Mon, Apr 16, 2012 at 3:50 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
Minor nit -- above line and subject reference sbc2, when fail comes
from scb2 source module.
Paul.
--
> is not enabled, so make it depend on PCI.
>
> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: linux-mtd@lists.infradead.org
> ---
> drivers/mtd/maps/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20120416.orig/drivers/mtd/maps/Kconfig
> +++ linux-next-20120416/drivers/mtd/maps/Kconfig
> @@ -224,7 +224,7 @@ config MTD_CK804XROM
>
> config MTD_SCB2_FLASH
> tristate "BIOS flash chip on Intel SCB2 boards"
> - depends on X86 && MTD_JEDECPROBE
> + depends on X86 && MTD_JEDECPROBE && PCI
> help
> Support for treating the BIOS flash chip on Intel SCB2 boards
> as an MTD device - with this you can reprogram your BIOS.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 22:20 ` Paul Gortmaker
@ 2012-04-17 1:25 ` Randy Dunlap
0 siblings, 0 replies; 20+ messages in thread
From: Randy Dunlap @ 2012-04-17 1:25 UTC (permalink / raw)
To: Paul Gortmaker
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
David Woodhouse, linux-mtd, Tim Hockin
On 04/16/2012 03:20 PM, Paul Gortmaker wrote:
> On Mon, Apr 16, 2012 at 3:50 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
>
> Minor nit -- above line and subject reference sbc2, when fail comes
> from scb2 source module.
Ack. I noticed later that I had botched that.
Thanks.
> Paul.
> --
>
>> is not enabled, so make it depend on PCI.
>>
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> Cc: linux-mtd@lists.infradead.org
>> ---
>> drivers/mtd/maps/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20120416.orig/drivers/mtd/maps/Kconfig
>> +++ linux-next-20120416/drivers/mtd/maps/Kconfig
>> @@ -224,7 +224,7 @@ config MTD_CK804XROM
>>
>> config MTD_SCB2_FLASH
>> tristate "BIOS flash chip on Intel SCB2 boards"
>> - depends on X86 && MTD_JEDECPROBE
>> + depends on X86 && MTD_JEDECPROBE && PCI
>> help
>> Support for treating the BIOS flash chip on Intel SCB2 boards
>> as an MTD device - with this you can reprogram your BIOS.
>> --
--
~Randy
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
2012-04-16 22:20 ` Paul Gortmaker
@ 2012-04-25 11:05 ` Artem Bityutskiy
2012-04-25 15:33 ` Artem Bityutskiy
2 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2012-04-25 11:05 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
David Woodhouse, linux-mtd, Tim Hockin
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Mon, 2012-04-16 at 12:50 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
> is not enabled, so make it depend on PCI.
>
> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
2012-04-16 22:20 ` Paul Gortmaker
2012-04-25 11:05 ` Artem Bityutskiy
@ 2012-04-25 15:33 ` Artem Bityutskiy
2 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2012-04-25 15:33 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
David Woodhouse, linux-mtd, Tim Hockin
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Mon, 2012-04-16 at 12:50 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
> is not enabled, so make it depend on PCI.
>
> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH -next] wireless: TI wlxxx depends on MAC80211
2012-04-16 6:11 linux-next: Tree for Apr 16 Stephen Rothwell
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
@ 2012-04-16 19:51 ` Randy Dunlap
2012-04-17 5:30 ` Luciano Coelho
` (2 more replies)
2012-04-17 1:01 ` [PATCH -next] staging: fix android alarm.c printk format warnings Randy Dunlap
` (2 subsequent siblings)
4 siblings, 3 replies; 20+ messages in thread
From: Randy Dunlap @ 2012-04-16 19:51 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Andrew Morton, Luciano Coelho, linux-wireless,
John W. Linville
From: Randy Dunlap <rdunlap@xenotime.net>
wl12xx build fails with many undefined symbol errors when MAC80211
and CFG80211 are not enabled, so make WLCORE and WL12XX depend
on MAC80211 (which already depends on CFG80211).
Here are a few of the many build errors:
drivers/built-in.o: In function `wl1271_register_hw':
main.c:(.text+0x4197cd): undefined reference to `ieee80211_register_hw'
drivers/built-in.o: In function `wl1271_rx_streaming_timer':
main.c:(.text+0x419818): undefined reference to `ieee80211_queue_work'
drivers/built-in.o: In function `wl1271_flush_deferred_work':
main.c:(.text+0x419910): undefined reference to `ieee80211_rx'
main.c:(.text+0x419938): undefined reference to `ieee80211_tx_status'
drivers/built-in.o: In function `wl12xx_op_channel_switch':
main.c:(.text+0x419afc): undefined reference to `ieee80211_chswitch_done'
drivers/built-in.o: In function `wl1271_ssid_set':
drivers/built-in.o: In function `wl1271_event_process':
event.c:(.text+0x41fec4): undefined reference to `ieee80211_sched_scan_stopped'
event.c:(.text+0x41ff88): undefined reference to `ieee80211_cqm_rssi_notify'
event.c:(.text+0x42000d): undefined reference to `ieee80211_stop_rx_ba_session'
event.c:(.text+0x420048): undefined reference to `ieee80211_stop_rx_ba_session'
event.c:(.text+0x4200b8): undefined reference to `ieee80211_chswitch_done'
event.c:(.text+0x4201ae): undefined reference to `ieee80211_find_sta'
event.c:(.text+0x4201ba): undefined reference to `ieee80211_report_low_ack'
event.c:(.text+0x42021b): undefined reference to `ieee80211_connection_loss'
drivers/built-in.o: In function `wl1271_tx_complete_packet':
tx.c:(.text+0x4206a6): undefined reference to `ieee80211_get_hdrlen_from_skb'
drivers/built-in.o: In function `wl1271_tx_fill_hdr':
tx.c:(.text+0x4208ca): undefined reference to `ieee80211_hdrlen'
drivers/built-in.o: In function `wl1271_handle_tx_low_watermark':
(.text+0x420e25): undefined reference to `ieee80211_wake_queue'
drivers/built-in.o: In function `wl12xx_rearm_rx_streaming':
(.text+0x420ed9): undefined reference to `ieee80211_queue_work'
drivers/built-in.o: In function `wl1271_tx_work_locked':
(.text+0x421008): undefined reference to `ieee80211_free_txskb'
drivers/built-in.o: In function `wl1271_rx_status.clone.2':
rx.c:(.text+0x421593): undefined reference to `ieee80211_channel_to_frequency'
drivers/built-in.o: In function `wl1271_ps_filter_frames':
ps.c:(.text+0x421a41): undefined reference to `ieee80211_tx_status'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Luciano Coelho <coelho@ti.com>
Cc: linux-wireless@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>
---
drivers/net/wireless/ti/wl12xx/Kconfig | 1 +
drivers/net/wireless/ti/wlcore/Kconfig | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
+++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
@@ -1,5 +1,6 @@
config WL12XX
tristate "TI wl12xx support"
+ depends on MAC80211
select WLCORE
---help---
This module adds support for wireless adapters based on TI wl1271,
--- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
+++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
@@ -1,6 +1,6 @@
config WLCORE
tristate "TI wlcore support"
- depends on WL_TI && GENERIC_HARDIRQS
+ depends on WL_TI && GENERIC_HARDIRQS && MAC80211
depends on INET
select FW_LOADER
---help---
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
2012-04-16 19:51 ` [PATCH -next] wireless: TI wlxxx depends on MAC80211 Randy Dunlap
@ 2012-04-17 5:30 ` Luciano Coelho
2012-04-17 18:29 ` Randy Dunlap
[not found] ` <4F8C784B.2040402-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-05-11 11:59 ` Arend van Spriel
2 siblings, 1 reply; 20+ messages in thread
From: Luciano Coelho @ 2012-04-17 5:30 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
linux-wireless, John W. Linville
Hi Randy,
On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> wl12xx build fails with many undefined symbol errors when MAC80211
> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> on MAC80211 (which already depends on CFG80211).
>
> Here are a few of the many build errors:
>
[...]
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Luciano Coelho <coelho@ti.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: "John W. Linville" <linville@tuxdriver.com>
> ---
Thanks for the patch!
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> @@ -1,5 +1,6 @@
> config WL12XX
> tristate "TI wl12xx support"
> + depends on MAC80211
> select WLCORE
Do we really need this one? wl12xx selects WLCORE which in turn depends
on MAC80211 (with your change below). Maybe we don't need this?
> ---help---
> This module adds support for wireless adapters based on TI wl1271,
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
> @@ -1,6 +1,6 @@
> config WLCORE
> tristate "TI wlcore support"
> - depends on WL_TI && GENERIC_HARDIRQS
> + depends on WL_TI && GENERIC_HARDIRQS && MAC80211
> depends on INET
> select FW_LOADER
> ---help---
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
2012-04-17 5:30 ` Luciano Coelho
@ 2012-04-17 18:29 ` Randy Dunlap
2012-04-17 15:52 ` Luciano Coelho
0 siblings, 1 reply; 20+ messages in thread
From: Randy Dunlap @ 2012-04-17 18:29 UTC (permalink / raw)
To: Luciano Coelho
Cc: Stephen Rothwell, linux-next-u79uwXL29TY76Z2rM5mHXA, LKML,
Andrew Morton, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
John W. Linville
On 04/16/2012 10:30 PM, Luciano Coelho wrote:
> Hi Randy,
>
> On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>>
>> wl12xx build fails with many undefined symbol errors when MAC80211
>> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
>> on MAC80211 (which already depends on CFG80211).
>>
>> Here are a few of the many build errors:
>>
>
> [...]
>
>> Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>> Cc: Luciano Coelho <coelho-l0cyMroinI0@public.gmane.org>
>> Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Cc: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
>> ---
>
> Thanks for the patch!
>
>
>> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
>> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
>> @@ -1,5 +1,6 @@
>> config WL12XX
>> tristate "TI wl12xx support"
>> + depends on MAC80211
>> select WLCORE
>
> Do we really need this one? wl12xx selects WLCORE which in turn depends
> on MAC80211 (with your change below). Maybe we don't need this?
Hi,
[testing...]
The build fails if either one of these "depends" is omitted.
>> ---help---
>> This module adds support for wireless adapters based on TI wl1271,
>> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
>> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
>> @@ -1,6 +1,6 @@
>> config WLCORE
>> tristate "TI wlcore support"
>> - depends on WL_TI && GENERIC_HARDIRQS
>> + depends on WL_TI && GENERIC_HARDIRQS && MAC80211
>> depends on INET
>> select FW_LOADER
>> ---help---
>
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
2012-04-17 18:29 ` Randy Dunlap
@ 2012-04-17 15:52 ` Luciano Coelho
0 siblings, 0 replies; 20+ messages in thread
From: Luciano Coelho @ 2012-04-17 15:52 UTC (permalink / raw)
To: Randy Dunlap, johannes
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
linux-wireless, John W. Linville
On Tue, 2012-04-17 at 11:29 -0700, Randy Dunlap wrote:
> On 04/16/2012 10:30 PM, Luciano Coelho wrote:
>
> > Hi Randy,
> >
> > On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@xenotime.net>
> >>
> >> wl12xx build fails with many undefined symbol errors when MAC80211
> >> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> >> on MAC80211 (which already depends on CFG80211).
> >>
> >> Here are a few of the many build errors:
> >>
> >
> > [...]
> >
> >> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> >> Cc: Luciano Coelho <coelho@ti.com>
> >> Cc: linux-wireless@vger.kernel.org
> >> Cc: "John W. Linville" <linville@tuxdriver.com>
> >> ---
> >
> > Thanks for the patch!
> >
> >
> >> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> >> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> >> @@ -1,5 +1,6 @@
> >> config WL12XX
> >> tristate "TI wl12xx support"
> >> + depends on MAC80211
> >> select WLCORE
> >
> > Do we really need this one? wl12xx selects WLCORE which in turn depends
> > on MAC80211 (with your change below). Maybe we don't need this?
>
> Hi,
>
> [testing...]
>
> The build fails if either one of these "depends" is omitted.
Yeah, thanks for testing. I guess it's because, as Johannes said,
select doesn't check the dependencies of the selected module.
Johannes, thanks for the explanation.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <4F8C784B.2040402-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>]
* Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
[not found] ` <4F8C784B.2040402-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
@ 2012-05-03 12:55 ` Luciano Coelho
2012-05-10 21:25 ` Randy Dunlap
0 siblings, 1 reply; 20+ messages in thread
From: Luciano Coelho @ 2012-05-03 12:55 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next-u79uwXL29TY76Z2rM5mHXA, LKML,
Andrew Morton, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
John W. Linville
On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>
> wl12xx build fails with many undefined symbol errors when MAC80211
> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> on MAC80211 (which already depends on CFG80211).
>
> Here are a few of the many build errors:
>
> drivers/built-in.o: In function `wl1271_register_hw':
> main.c:(.text+0x4197cd): undefined reference to `ieee80211_register_hw'
> drivers/built-in.o: In function `wl1271_rx_streaming_timer':
> main.c:(.text+0x419818): undefined reference to `ieee80211_queue_work'
> drivers/built-in.o: In function `wl1271_flush_deferred_work':
> main.c:(.text+0x419910): undefined reference to `ieee80211_rx'
> main.c:(.text+0x419938): undefined reference to `ieee80211_tx_status'
> drivers/built-in.o: In function `wl12xx_op_channel_switch':
> main.c:(.text+0x419afc): undefined reference to `ieee80211_chswitch_done'
> drivers/built-in.o: In function `wl1271_ssid_set':
> drivers/built-in.o: In function `wl1271_event_process':
> event.c:(.text+0x41fec4): undefined reference to `ieee80211_sched_scan_stopped'
> event.c:(.text+0x41ff88): undefined reference to `ieee80211_cqm_rssi_notify'
> event.c:(.text+0x42000d): undefined reference to `ieee80211_stop_rx_ba_session'
> event.c:(.text+0x420048): undefined reference to `ieee80211_stop_rx_ba_session'
> event.c:(.text+0x4200b8): undefined reference to `ieee80211_chswitch_done'
> event.c:(.text+0x4201ae): undefined reference to `ieee80211_find_sta'
> event.c:(.text+0x4201ba): undefined reference to `ieee80211_report_low_ack'
> event.c:(.text+0x42021b): undefined reference to `ieee80211_connection_loss'
> drivers/built-in.o: In function `wl1271_tx_complete_packet':
> tx.c:(.text+0x4206a6): undefined reference to `ieee80211_get_hdrlen_from_skb'
> drivers/built-in.o: In function `wl1271_tx_fill_hdr':
> tx.c:(.text+0x4208ca): undefined reference to `ieee80211_hdrlen'
> drivers/built-in.o: In function `wl1271_handle_tx_low_watermark':
> (.text+0x420e25): undefined reference to `ieee80211_wake_queue'
> drivers/built-in.o: In function `wl12xx_rearm_rx_streaming':
> (.text+0x420ed9): undefined reference to `ieee80211_queue_work'
> drivers/built-in.o: In function `wl1271_tx_work_locked':
> (.text+0x421008): undefined reference to `ieee80211_free_txskb'
> drivers/built-in.o: In function `wl1271_rx_status.clone.2':
> rx.c:(.text+0x421593): undefined reference to `ieee80211_channel_to_frequency'
> drivers/built-in.o: In function `wl1271_ps_filter_frames':
> ps.c:(.text+0x421a41): undefined reference to `ieee80211_tx_status'
>
> Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
> Cc: Luciano Coelho <coelho-l0cyMroinI0@public.gmane.org>
> Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
> ---
Applied! Thanks Randy, and sorry for the delay in pushing this through
my tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
2012-05-03 12:55 ` Luciano Coelho
@ 2012-05-10 21:25 ` Randy Dunlap
2012-05-10 21:36 ` Luciano Coelho
0 siblings, 1 reply; 20+ messages in thread
From: Randy Dunlap @ 2012-05-10 21:25 UTC (permalink / raw)
To: Luciano Coelho
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
linux-wireless, John W. Linville
On 05/03/2012 05:55 AM, Luciano Coelho wrote:
> On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> wl12xx build fails with many undefined symbol errors when MAC80211
>> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
>> on MAC80211 (which already depends on CFG80211).
>>
>> Here are a few of the many build errors:
>>
>> drivers/built-in.o: In function `wl1271_register_hw':
>> main.c:(.text+0x4197cd): undefined reference to `ieee80211_register_hw'
>> drivers/built-in.o: In function `wl1271_rx_streaming_timer':
>> main.c:(.text+0x419818): undefined reference to `ieee80211_queue_work'
>> drivers/built-in.o: In function `wl1271_flush_deferred_work':
>> main.c:(.text+0x419910): undefined reference to `ieee80211_rx'
>> main.c:(.text+0x419938): undefined reference to `ieee80211_tx_status'
>> drivers/built-in.o: In function `wl12xx_op_channel_switch':
>> main.c:(.text+0x419afc): undefined reference to `ieee80211_chswitch_done'
>> drivers/built-in.o: In function `wl1271_ssid_set':
>> drivers/built-in.o: In function `wl1271_event_process':
>> event.c:(.text+0x41fec4): undefined reference to `ieee80211_sched_scan_stopped'
>> event.c:(.text+0x41ff88): undefined reference to `ieee80211_cqm_rssi_notify'
>> event.c:(.text+0x42000d): undefined reference to `ieee80211_stop_rx_ba_session'
>> event.c:(.text+0x420048): undefined reference to `ieee80211_stop_rx_ba_session'
>> event.c:(.text+0x4200b8): undefined reference to `ieee80211_chswitch_done'
>> event.c:(.text+0x4201ae): undefined reference to `ieee80211_find_sta'
>> event.c:(.text+0x4201ba): undefined reference to `ieee80211_report_low_ack'
>> event.c:(.text+0x42021b): undefined reference to `ieee80211_connection_loss'
>> drivers/built-in.o: In function `wl1271_tx_complete_packet':
>> tx.c:(.text+0x4206a6): undefined reference to `ieee80211_get_hdrlen_from_skb'
>> drivers/built-in.o: In function `wl1271_tx_fill_hdr':
>> tx.c:(.text+0x4208ca): undefined reference to `ieee80211_hdrlen'
>> drivers/built-in.o: In function `wl1271_handle_tx_low_watermark':
>> (.text+0x420e25): undefined reference to `ieee80211_wake_queue'
>> drivers/built-in.o: In function `wl12xx_rearm_rx_streaming':
>> (.text+0x420ed9): undefined reference to `ieee80211_queue_work'
>> drivers/built-in.o: In function `wl1271_tx_work_locked':
>> (.text+0x421008): undefined reference to `ieee80211_free_txskb'
>> drivers/built-in.o: In function `wl1271_rx_status.clone.2':
>> rx.c:(.text+0x421593): undefined reference to `ieee80211_channel_to_frequency'
>> drivers/built-in.o: In function `wl1271_ps_filter_frames':
>> ps.c:(.text+0x421a41): undefined reference to `ieee80211_tx_status'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: Luciano Coelho <coelho@ti.com>
>> Cc: linux-wireless@vger.kernel.org
>> Cc: "John W. Linville" <linville@tuxdriver.com>
>> ---
>
> Applied! Thanks Randy, and sorry for the delay in pushing this through
> my tree.
Ping.
This patch is still needed in linux-next of 20120510.
--
~Randy
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
2012-05-10 21:25 ` Randy Dunlap
@ 2012-05-10 21:36 ` Luciano Coelho
2012-05-10 21:37 ` Randy Dunlap
0 siblings, 1 reply; 20+ messages in thread
From: Luciano Coelho @ 2012-05-10 21:36 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
linux-wireless, John W. Linville
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
Hey Randy,
On Thu, 2012-05-10 at 14:25 -0700, Randy Dunlap wrote:
> On 05/03/2012 05:55 AM, Luciano Coelho wrote:
>
> > On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@xenotime.net>
> >>
> >> wl12xx build fails with many undefined symbol errors when MAC80211
> >> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> >> on MAC80211 (which already depends on CFG80211).
> >>
> >> Here are a few of the many build errors:
[...]
> >> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> >> Cc: Luciano Coelho <coelho@ti.com>
> >> Cc: linux-wireless@vger.kernel.org
> >> Cc: "John W. Linville" <linville@tuxdriver.com>
> >> ---
> >
> > Applied! Thanks Randy, and sorry for the delay in pushing this through
> > my tree.
>
>
>
> Ping.
>
> This patch is still needed in linux-next of 20120510.
I already applied this patch and sent a pull-request to Linville, but he
hasn't pulled from my tree into wireless-next yet.
Would it make sense for you to pull directly from my tree into
linux-next?
--
Cheers,
Luca.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
2012-05-10 21:36 ` Luciano Coelho
@ 2012-05-10 21:37 ` Randy Dunlap
0 siblings, 0 replies; 20+ messages in thread
From: Randy Dunlap @ 2012-05-10 21:37 UTC (permalink / raw)
To: Luciano Coelho
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
linux-wireless, John W. Linville
On 05/10/2012 02:36 PM, Luciano Coelho wrote:
> Hey Randy,
>
> On Thu, 2012-05-10 at 14:25 -0700, Randy Dunlap wrote:
>> On 05/03/2012 05:55 AM, Luciano Coelho wrote:
>>
>>> On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
>>>> From: Randy Dunlap <rdunlap@xenotime.net>
>>>>
>>>> wl12xx build fails with many undefined symbol errors when MAC80211
>>>> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
>>>> on MAC80211 (which already depends on CFG80211).
>>>>
>>>> Here are a few of the many build errors:
>
> [...]
>
>>>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>>>> Cc: Luciano Coelho <coelho@ti.com>
>>>> Cc: linux-wireless@vger.kernel.org
>>>> Cc: "John W. Linville" <linville@tuxdriver.com>
>>>> ---
>>>
>>> Applied! Thanks Randy, and sorry for the delay in pushing this through
>>> my tree.
>>
>>
>>
>> Ping.
>>
>> This patch is still needed in linux-next of 20120510.
>
> I already applied this patch and sent a pull-request to Linville, but he
> hasn't pulled from my tree into wireless-next yet.
>
> Would it make sense for you to pull directly from my tree into
> linux-next?
No, I'm just testing/reporting on linux-next.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
2012-04-16 19:51 ` [PATCH -next] wireless: TI wlxxx depends on MAC80211 Randy Dunlap
2012-04-17 5:30 ` Luciano Coelho
[not found] ` <4F8C784B.2040402-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
@ 2012-05-11 11:59 ` Arend van Spriel
2 siblings, 0 replies; 20+ messages in thread
From: Arend van Spriel @ 2012-05-11 11:59 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, LKML, Andrew Morton,
Luciano Coelho, linux-wireless, John W. Linville, Arik Nemtsov
On 04/16/2012 09:51 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> wl12xx build fails with many undefined symbol errors when MAC80211
> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> on MAC80211 (which already depends on CFG80211).
>
> ---
> drivers/net/wireless/ti/wl12xx/Kconfig | 1 +
> drivers/net/wireless/ti/wlcore/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> @@ -1,5 +1,6 @@
> config WL12XX
> tristate "TI wl12xx support"
> + depends on MAC80211
> select WLCORE
Similar patch is probably needed for new wl18xx driver.
> ---help---
> This module adds support for wireless adapters based on TI wl1271,
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
> @@ -1,6 +1,6 @@
> config WLCORE
> tristate "TI wlcore support"
> - depends on WL_TI && GENERIC_HARDIRQS
> + depends on WL_TI && GENERIC_HARDIRQS && MAC80211
> depends on INET
> select FW_LOADER
> ---help---
Gr. AvS
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH -next] staging: fix android alarm.c printk format warnings
2012-04-16 6:11 linux-next: Tree for Apr 16 Stephen Rothwell
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
2012-04-16 19:51 ` [PATCH -next] wireless: TI wlxxx depends on MAC80211 Randy Dunlap
@ 2012-04-17 1:01 ` Randy Dunlap
2012-04-17 1:01 ` [PATCH -next] soc: fix printk format in soc-dapm.c Randy Dunlap
2012-04-17 1:01 ` [PATCH -next] hippi: fix printk format in rrunner.c Randy Dunlap
4 siblings, 0 replies; 20+ messages in thread
From: Randy Dunlap @ 2012-04-17 1:01 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Greg KH, Brian Swetland, Andrew Morton, devel
From: Randy Dunlap <rdunlap@xenotime.net>
Fix printk format warnings by using 't' modifier for ptrdiff_t.
drivers/staging/android/alarm.c:344:2: warning: format '%ld' expects type 'long int', but argument 2 has type 'int'
drivers/staging/android/alarm.c:367:3: warning: format '%ld' expects type 'long int', but argument 2 has type 'int'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Greg KH <greg@kroah.com>
Cc: Brian Swetland <swetland@google.com>
---
drivers/staging/android/alarm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20120416.orig/drivers/staging/android/alarm.c
+++ linux-next-20120416/drivers/staging/android/alarm.c
@@ -341,7 +341,7 @@ static enum hrtimer_restart alarm_timer_
now = base->stopped ? base->stopped_time : hrtimer_cb_get_time(timer);
now = ktime_sub(now, base->delta);
- pr_alarm(INT, "alarm_timer_triggered type %ld at %lld\n",
+ pr_alarm(INT, "alarm_timer_triggered type %td at %lld\n",
base - alarms, ktime_to_ns(now));
while (base->first) {
@@ -364,7 +364,7 @@ static enum hrtimer_restart alarm_timer_
spin_lock_irqsave(&alarm_slock, flags);
}
if (!base->first)
- pr_alarm(FLOW, "no more alarms of type %ld\n", base - alarms);
+ pr_alarm(FLOW, "no more alarms of type %td\n", base - alarms);
update_timer_locked(base, true);
spin_unlock_irqrestore(&alarm_slock, flags);
return HRTIMER_NORESTART;
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH -next] soc: fix printk format in soc-dapm.c
2012-04-16 6:11 linux-next: Tree for Apr 16 Stephen Rothwell
` (2 preceding siblings ...)
2012-04-17 1:01 ` [PATCH -next] staging: fix android alarm.c printk format warnings Randy Dunlap
@ 2012-04-17 1:01 ` Randy Dunlap
2012-04-16 22:52 ` [alsa-devel] " Fabio Estevam
2012-04-17 1:01 ` [PATCH -next] hippi: fix printk format in rrunner.c Randy Dunlap
4 siblings, 1 reply; 20+ messages in thread
From: Randy Dunlap @ 2012-04-17 1:01 UTC (permalink / raw)
To: Stephen Rothwell
Cc: alsa-devel, Mark Brown, LKML, linux-next, Andrew Morton, Liam Girdwood
From: Randy Dunlap <rdunlap@xenotime.net>
Fix printk format warning for 'formats':
sound/soc/soc-dapm.c:2913:5: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'u64'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Liam Girdwood <lrg@ti.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
---
sound/soc/soc-dapm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20120416.orig/sound/soc/soc-dapm.c
+++ linux-next-20120416/sound/soc/soc-dapm.c
@@ -2909,7 +2909,7 @@ static int snd_soc_dai_link_event(struct
if (config->formats) {
fmt = ffs(config->formats) - 1;
} else {
- dev_warn(w->dapm->dev, "Invalid format %lx specified\n",
+ dev_warn(w->dapm->dev, "Invalid format %llx specified\n",
config->formats);
fmt = 0;
}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [alsa-devel] [PATCH -next] soc: fix printk format in soc-dapm.c
2012-04-17 1:01 ` [PATCH -next] soc: fix printk format in soc-dapm.c Randy Dunlap
@ 2012-04-16 22:52 ` Fabio Estevam
0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2012-04-16 22:52 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, alsa-devel, Mark Brown, LKML, linux-next,
Andrew Morton, Liam Girdwood
On Mon, Apr 16, 2012 at 10:01 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix printk format warning for 'formats':
>
> sound/soc/soc-dapm.c:2913:5: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'u64'
I have sent a fix for this earlier today and Mark has already applied it.
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH -next] hippi: fix printk format in rrunner.c
2012-04-16 6:11 linux-next: Tree for Apr 16 Stephen Rothwell
` (3 preceding siblings ...)
2012-04-17 1:01 ` [PATCH -next] soc: fix printk format in soc-dapm.c Randy Dunlap
@ 2012-04-17 1:01 ` Randy Dunlap
2012-04-17 3:48 ` David Miller
4 siblings, 1 reply; 20+ messages in thread
From: Randy Dunlap @ 2012-04-17 1:01 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, netdev, linux-hippi, Jes Sorensen, Andrew Morton
From: Randy Dunlap <rdunlap@xenotime.net>
Fix printk format warning (from i386 build):
drivers/net/hippi/rrunner.c:146:9: warning: format '%08llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Jes Sorensen <jes@trained-monkey.org>
Cc: linux-hippi@sunsite.dk
---
drivers/net/hippi/rrunner.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-next-20120416.orig/drivers/net/hippi/rrunner.c
+++ linux-next-20120416/drivers/net/hippi/rrunner.c
@@ -142,8 +142,9 @@ static int __devinit rr_init_one(struct
pci_set_master(pdev);
printk(KERN_INFO "%s: Essential RoadRunner serial HIPPI "
- "at 0x%08llx, irq %i, PCI latency %i\n", dev->name,
- pci_resource_start(pdev, 0), pdev->irq, pci_latency);
+ "at 0x%llx, irq %i, PCI latency %i\n", dev->name,
+ (unsigned long long)pci_resource_start(pdev, 0),
+ pdev->irq, pci_latency);
/*
* Remap the MMIO regs into kernel space.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH -next] hippi: fix printk format in rrunner.c
2012-04-17 1:01 ` [PATCH -next] hippi: fix printk format in rrunner.c Randy Dunlap
@ 2012-04-17 3:48 ` David Miller
0 siblings, 0 replies; 20+ messages in thread
From: David Miller @ 2012-04-17 3:48 UTC (permalink / raw)
To: rdunlap; +Cc: sfr, linux-next, linux-kernel, netdev, linux-hippi, jes, akpm
From: Randy Dunlap <rdunlap@xenotime.net>
Date: Mon, 16 Apr 2012 18:01:33 -0700
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix printk format warning (from i386 build):
>
> drivers/net/hippi/rrunner.c:146:9: warning: format '%08llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
I'll apply this, thanks Randy.
^ permalink raw reply [flat|nested] 20+ messages in thread