linux-next: build failure after merge of the final tree (staging tree related)

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1783 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]

Caused by commit 187e47824013 ("Staging: ipack: Read the ID space during
device registration").

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 5 Sep 2012 15:44:11 +1000
Subject: [PATCH] Staging: ipack: disable due to build error

The powerpc allyesconfig build gives this:

drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/ipack/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ipack/Kconfig b/drivers/staging/ipack/Kconfig
index af32178..5c428d7 100644
--- a/drivers/staging/ipack/Kconfig
+++ b/drivers/staging/ipack/Kconfig
@@ -4,6 +4,7 @@
 
 menuconfig IPACK_BUS
 	tristate "IndustryPack bus support"
+	depends on BROKEN
 	---help---
 	  If you say Y here you get support for the IndustryPack Framework
 	  for drivers for many types of boards that support this industrial
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

[PATCH] Staging: ipack: fix build failure in powerpc allyesconfig

[Samuel Iglesias Gonsálvez]

Caused by commit 187e47824013 ("Staging: ipack: Read the ID space during
device registration").

drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function
	'ioread8' [-Werror=implicit-function-declaration]
drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function
	'ioread16be' [-Werror=implicit-function-declaration]

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
---
 drivers/staging/ipack/ipack.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index da9e7bd..8cce6c4 100644
--- a/drivers/staging/ipack/ipack.c
+++ b/drivers/staging/ipack/ipack.c
@@ -12,6 +12,7 @@
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/idr.h>
+#include <asm/io.h>
 #include "ipack.h"
 
 #define to_ipack_dev(device) container_of(device, struct ipack_device, dev)
-- 
1.7.10.4

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Geert Uytterhoeven]

On Wed, Sep 5, 2012 at 7:48 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
> drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
> drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]
>
> Caused by commit 187e47824013 ("Staging: ipack: Read the ID space during
> device registration").
>
> I have added the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 5 Sep 2012 15:44:11 +1000
> Subject: [PATCH] Staging: ipack: disable due to build error
>
> The powerpc allyesconfig build gives this:
>
> drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
> drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
> drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]

The ipack driver also fails on s390/allmodconfig:

drivers/staging/ipack/devices/ipoctal.c:59:2: error: implicit
declaration of function 'iowrite8'
[-Werror=implicit-function-declaration]
drivers/staging/ipack/devices/ipoctal.c:72:2: error: implicit
declaration of function 'ioread8'
[-Werror=implicit-function-declaration]

http://kisskb.ellerman.id.au/kisskb/buildresult/7143741/

Guess it has to depend on HAS_IOMEM, too.

> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/ipack/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ipack/Kconfig b/drivers/staging/ipack/Kconfig
> index af32178..5c428d7 100644
> --- a/drivers/staging/ipack/Kconfig
> +++ b/drivers/staging/ipack/Kconfig
> @@ -4,6 +4,7 @@
>
>  menuconfig IPACK_BUS
>         tristate "IndustryPack bus support"
> +       depends on BROKEN

Cool, can I do that for all build failures? ;-)

>         ---help---
>           If you say Y here you get support for the IndustryPack Framework
>           for drivers for many types of boards that support this industrial

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] staging: ipack: only build on platforms that provide ioread/iowrite.

[Samuel Iglesias Gonsálvez]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

On Thu, 2012-09-06 at 21:45 +0200, Jens Taprogge wrote:
> Do so by depending on HAS_IOMEM.
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
> ---
>  drivers/staging/ipack/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ipack/Kconfig b/drivers/staging/ipack/Kconfig
> index af32178..4cf4706 100644
> --- a/drivers/staging/ipack/Kconfig
> +++ b/drivers/staging/ipack/Kconfig
> @@ -4,6 +4,7 @@
>  
>  menuconfig IPACK_BUS
>  	tristate "IndustryPack bus support"
> +	depends on HAS_IOMEM
>  	---help---
>  	  If you say Y here you get support for the IndustryPack Framework
>  	  for drivers for many types of boards that support this industrial

Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Thanks,

Sam

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]