linux-next: Fixes tag needs some work in the rockchip tree

linux-next: Fixes tag needs some work in the rockchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hi all,

In commit

  8c318aaa2000 ("arm64: dts: rockchip: fix Quartz64-A ddr regulator voltage")

Fixes tag

  Fixes: b33a22a1e7c4 ("arm64: dts: rockchip: add basic dts for Pine64

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, keep all
the commit message tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the rockchip tree

[Heiko Stübner]

Hi Stephen,

Am Sonntag, 30. Januar 2022, 00:23:02 CET schrieb Stephen Rothwell:
> Hi all,
> 
> In commit
> 
>   8c318aaa2000 ("arm64: dts: rockchip: fix Quartz64-A ddr regulator voltage")
> 
> Fixes tag
> 
>   Fixes: b33a22a1e7c4 ("arm64: dts: rockchip: add basic dts for Pine64
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.  Also, keep all
> the commit message tags together at the end of the commit message.

sorry about that. I've corrected the commit now to not split the fixes tag.

Thanks for catching that
Heiko

linux-next: Fixes tag needs some work in the rockchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi all,

In commit

  96e908b46e65 ("arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50 on rock-3a")

Fixes tag

  Fixes: 22a442e6 ("arm64: dts: rockchip: add basic dts for the radxa rock3 model a")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the rockchip tree

[Heiko Stübner]

Am Sonntag, 29. Januar 2023, 23:02:33 CET schrieb Stephen Rothwell:
> Hi all,
> 
> In commit
> 
>   96e908b46e65 ("arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50 on rock-3a")
> 
> Fixes tag
> 
>   Fixes: 22a442e6 ("arm64: dts: rockchip: add basic dts for the radxa rock3 model a")

[re-sending as I initially answered Dan's reply without realizing that the
 mailinglists weren't included there]

I've amended the commit with the better commit hash and also updated the
for-next branch.

Thanks for catching this
Heiko

linux-next: Fixes tag needs some work in the rockchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  0b86f9570e77 ("arm64: dts: rockchip: Fix RX delay for ethernet phy on rk3588s-rock5a")

Fixes tag

  Fixes: 55fa4c2a7a912 ("arm64: dts: rockchip: Add rock-5a board")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d1824cf95799 ("arm64: dts: rockchip: Add rock-5a board")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the rockchip tree

[Heiko Stübner]

Hi Stephen,

Am Sonntag, 15. Januar 2023, 22:09:47 CET schrieb Stephen Rothwell:
> In commit
> 
>   0b86f9570e77 ("arm64: dts: rockchip: Fix RX delay for ethernet phy on rk3588s-rock5a")
> 
> Fixes tag
> 
>   Fixes: 55fa4c2a7a912 ("arm64: dts: rockchip: Add rock-5a board")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: d1824cf95799 ("arm64: dts: rockchip: Add rock-5a board")

thanks for noticing. I've checked this and amended the commit with the
correct id.

Thanks
Heiko

linux-next: Fixes tag needs some work in the rockchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi all,

In commit

  b62ce630fddb ("arm64: dts: rockchip: fix Rockpro64 RK808 interrupt line")

Fixes tag

  Fixes: e4f3fb4 ("arm64: dts: rockchip: add initial dts support for Rockpro64")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the rockchip tree

[Heiko Stuebner]

Hi Stephen,

Am Donnerstag, 3. Oktober 2019, 23:56:45 CEST schrieb Stephen Rothwell:
> In commit
> 
>   b62ce630fddb ("arm64: dts: rockchip: fix Rockpro64 RK808 interrupt line")
> 
> Fixes tag
> 
>   Fixes: e4f3fb4 ("arm64: dts: rockchip: add initial dts support for Rockpro64")

I fixed the git hash and updated the branch with it.

Thanks for the catch
Heiko

linux-next: Fixes tag needs some work in the rockchip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi Heiko,

In commit

  89c1f66ae88a ("arm64: dts: rockchip: fix IO domain voltage setting of APIO5 on rockpro64")

Fixes tag

  Fixes: e4f3fb4909 ("arm64: dts: rockchip: add initial dts support for Rockpro64")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the rockchip tree

[Heiko Stuebner]

Am Dienstag, 23. April 2019, 23:25:39 CEST schrieb Stephen Rothwell:
> Hi Heiko,
> 
> In commit
> 
>   89c1f66ae88a ("arm64: dts: rockchip: fix IO domain voltage setting of APIO5 on rockpro64")
> 
> Fixes tag
> 
>   Fixes: e4f3fb4909 ("arm64: dts: rockchip: add initial dts support for Rockpro64")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thanks for that catch. I've amended the commit to have a correct
fixes commit-id.


Thanks
Heiko