From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"greg@kroah.com" <greg@kroah.com>
Cc: "James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hare@suse.de" <hare@suse.de>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"sameer.wadgaonkar@unisys.com" <sameer.wadgaonkar@unisys.com>
Subject: Re: linux-next: manual merge of the scsi tree with the staging tree
Date: Mon, 28 Aug 2017 15:41:28 +0000 [thread overview]
Message-ID: <1503934884.2841.22.camel@wdc.com> (raw)
In-Reply-To: <20170828064921.GA24696@kroah.com>
On Mon, 2017-08-28 at 08:49 +0200, Greg KH wrote:
> On Mon, Aug 28, 2017 at 04:41:27PM +1000, Stephen Rothwell wrote:
> > Hi James,
> >
> > Today's linux-next merge of the scsi tree got a conflict in:
> >
> > drivers/staging/unisys/visorhba/visorhba_main.c
> >
> > between commits:
> >
> > 781facd05eb9 ("staging: unisys: visorhba: visorhba_main.c: fixed comment formatting issues")
> >
> > from the staging tree and commit:
> >
> > 7bc4e528d9f6 ("scsi: visorhba: sanitze private device data allocation")
> >
> > from the scsi tree.
> >
> > I fixed it up (see below) and can carry the fix as necessary. This
> > is now fixed as far as linux-next is concerned, but any non trivial
> > conflicts should be mentioned to your upstream maintainer when your tree
> > is submitted for merging. You may also want to consider cooperating
> > with the maintainer of the conflicting tree to minimise any particularly
> > complex conflicts.
>
> Ick, messy merge, thanks for doing this.
Hello Greg,
If you agree with the following, please communicate this to the visorhba
authors:
* Most SCSI drivers exist under drivers/scsi, including the virtio-scsi and
xen-scsifront drivers. So why has the visorhba driver been added under
unisys/visorhba?
* Since the SCSI core already keeps track of which commands are pending, the
visorhba driver should not do this. I'm referring here to the scsipending
data structure and the pending[] array in struct visorhb_devdata.
* The pending[] array should be removed and should be converted into
driver-private command data by setting the .cmd_size member of the SCSI host
template.
* scsi_host_find_tag() should be used when a command completion is received
to look up the pointer of the SCSI command that has been completed.
* All code that calls for_each_vdisk_match() looks buggy to me in some way.
E.g. visorhba_abort_handler() should only affect the command passed as an
argument to that function and no other SCSI commands.
* The device and bus reset handlers should call scsi_done() for all affected
commands if forward_taskmgmt_command() succeeds instead of only the command
passed as an argument.
* The for_each_vdisk_match() macro does not protect against concurrent device
removal and hence is unsafe. This macro should be removed and in contexts
where it is *really* needed to iterate over SCSI devices
shost_for_each_device() should be used instead.
* Instead of creating a kernel thread to poll for responses the visorhba driver
should only process responses after it has received an interrupt that tells it
to do so (see also the visor_thread_start() calls).
* SCSI drivers should not have special-case code for host shutdown.
* The 'dev_info_list' member in struct visorhba_data is not used and hence
should be removed.
Please note that I have not attempted to do a full review of the visorhba driver.
Thanks,
Bart.
next prev parent reply other threads:[~2017-08-28 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 6:41 linux-next: manual merge of the scsi tree with the staging tree Stephen Rothwell
2017-08-28 6:49 ` Greg KH
2017-08-28 15:41 ` Bart Van Assche [this message]
2017-08-28 16:05 ` greg
2017-08-28 16:36 ` Bart Van Assche
2017-08-28 16:44 ` greg
2017-08-28 17:06 ` Wadgaonkar, Sameer Laxmikant
2017-08-28 17:51 ` James Bottomley
2017-08-28 18:47 ` greg
2017-09-05 0:18 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503934884.2841.22.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=greg@kroah.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sameer.wadgaonkar@unisys.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).