From: "greg@kroah.com" <greg@kroah.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"hare@suse.de" <hare@suse.de>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"sameer.wadgaonkar@unisys.com" <sameer.wadgaonkar@unisys.com>
Subject: Re: linux-next: manual merge of the scsi tree with the staging tree
Date: Mon, 28 Aug 2017 18:44:20 +0200 [thread overview]
Message-ID: <20170828164420.GB16802@kroah.com> (raw)
In-Reply-To: <1503938165.2841.30.camel@wdc.com>
On Mon, Aug 28, 2017 at 04:36:06PM +0000, Bart Van Assche wrote:
> On Mon, 2017-08-28 at 18:05 +0200, greg@kroah.com wrote:
> > On Mon, Aug 28, 2017 at 03:41:28PM +0000, Bart Van Assche wrote:
> > > * Most SCSI drivers exist under drivers/scsi, including the virtio-scsi and
> > > xen-scsifront drivers. So why has the visorhba driver been added under
> > > unisys/visorhba?
> >
> > That's because right now it's still a staging driver. Also, there are
> > other scsi drivers in other portions of the kernel tree (like the USB
> > driver), so there's no hard rule that all scsi drivers have to be under
> > drivers/scsi/
> >
> > <snip>
> >
> > Please provide this review to them, on the properly mailing list, I'm
> > sure they would be glad to get it.
>
> OK, I will do that. BTW, is there a written down version of the rules for
> adding a driver under drivers/staging available somewhere?
The only 2 rules for adding a new drivers/staging driver is:
- has to compile
- correct license
and sometimes we let code in if the first one isn't true :)
> As far as I can
> see the visorhba driver went in without the linux-scsi mailing list having
> been CC-ed. See also Benjamin Romer, [PATCH] staging: unisys: Add s-Par
> visorhba, linux-driver-devel mailing list, July 2015
> (https://marc.info/?l=linux-driver-devel&m=143681271902628).
That's totally normal, why would the scsi developers care about a
staging driver in such a rough state. Only when it looks "good enough"
would we ask for a scsi developer review to move it out of staging.
hope this helps,
greg k-h
next prev parent reply other threads:[~2017-08-28 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 6:41 linux-next: manual merge of the scsi tree with the staging tree Stephen Rothwell
2017-08-28 6:49 ` Greg KH
2017-08-28 15:41 ` Bart Van Assche
2017-08-28 16:05 ` greg
2017-08-28 16:36 ` Bart Van Assche
2017-08-28 16:44 ` greg [this message]
2017-08-28 17:06 ` Wadgaonkar, Sameer Laxmikant
2017-08-28 17:51 ` James Bottomley
2017-08-28 18:47 ` greg
2017-09-05 0:18 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828164420.GB16802@kroah.com \
--to=greg@kroah.com \
--cc=Bart.VanAssche@wdc.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sameer.wadgaonkar@unisys.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).