* [PATCH] software node: property entry kunit tests must depend on KUNIT=y
@ 2020-01-16 11:17 Alan Maguire
2020-01-16 23:27 ` Brendan Higgins
0 siblings, 1 reply; 2+ messages in thread
From: Alan Maguire @ 2020-01-16 11:17 UTC (permalink / raw)
To: rjw
Cc: gregkh, linux-kernel, skhan, brendanhiggins, linux-next,
dmitry.torokhov, sfr, rdunlap, Alan Maguire
property entry kunit tests are built if CONFIG_KUNIT_DRIVER_PE_TEST
(a boolean) is 'y'; it in turn depends on CONFIG_KUNIT. However to
ensure clean merge with linux-next, where CONFIG_KUNIT is tristate,
we need to explicitly specify KUNIT=y as a dependency, otherwise
allmodconfig builds will build kunit as a module and fail to build
the property entry tests. Later CONFIG_KUNIT_DRIVER_PE_TEST can
be converted to tristate.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 27f9d7e984d9 ("software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST")
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
drivers/base/test/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
index d29ae95..305c775 100644
--- a/drivers/base/test/Kconfig
+++ b/drivers/base/test/Kconfig
@@ -10,4 +10,4 @@ config TEST_ASYNC_DRIVER_PROBE
If unsure say N.
config KUNIT_DRIVER_PE_TEST
bool "KUnit Tests for property entry API"
- depends on KUNIT
+ depends on KUNIT=y
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] software node: property entry kunit tests must depend on KUNIT=y
2020-01-16 11:17 [PATCH] software node: property entry kunit tests must depend on KUNIT=y Alan Maguire
@ 2020-01-16 23:27 ` Brendan Higgins
0 siblings, 0 replies; 2+ messages in thread
From: Brendan Higgins @ 2020-01-16 23:27 UTC (permalink / raw)
To: Alan Maguire
Cc: Rafael J. Wysocki, Greg KH, Linux Kernel Mailing List,
Shuah Khan, Linux Next Mailing List, Dmitry Torokhov,
Stephen Rothwell, Randy Dunlap
On Thu, Jan 16, 2020 at 3:19 AM Alan Maguire <alan.maguire@oracle.com> wrote:
>
> property entry kunit tests are built if CONFIG_KUNIT_DRIVER_PE_TEST
> (a boolean) is 'y'; it in turn depends on CONFIG_KUNIT. However to
> ensure clean merge with linux-next, where CONFIG_KUNIT is tristate,
> we need to explicitly specify KUNIT=y as a dependency, otherwise
> allmodconfig builds will build kunit as a module and fail to build
> the property entry tests. Later CONFIG_KUNIT_DRIVER_PE_TEST can
> be converted to tristate.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 27f9d7e984d9 ("software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST")
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-16 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 11:17 [PATCH] software node: property entry kunit tests must depend on KUNIT=y Alan Maguire
2020-01-16 23:27 ` Brendan Higgins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).