From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Miller <davem@davemloft.net>,
linux-next@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: linux-next: sparc64 build failure
Date: Thu, 29 May 2008 15:01:58 -0700 [thread overview]
Message-ID: <20080529220158.GA3867@kroah.com> (raw)
In-Reply-To: <20080529175332.a12ad65d.sfr@canb.auug.org.au>
On Thu, May 29, 2008 at 05:53:32PM +1000, Stephen Rothwell wrote:
> Hi Dave, Greg,
>
> Today's build of linux-next (sparc64 defconfig) failed like this:
>
> arch/sparc64/kernel/pci.c: In function `of_create_pci_dev':
> arch/sparc64/kernel/pci.c:412: warning: passing arg 1 of `sprintf' discards qualifiers from pointer target type
> make[2]: *** [arch/sparc64/kernel/pci.o] Error 1
>
> This was caused by commit bd24b944eb93549b1ca5becbf27c7373504f7eed
> ("driver-core: prepare for removal of 20 char limit from struct device")
> from the driver-core tree which made pci_name() return a "const char *".
>
> I have applied the following patch.
>
> Greg, it would really help if a version of dev_set_name() was created
> early ... like in Linus' tree now?
I'm trying to do that right now, but it's causing a little oops at boot
time that would not be nice to introduce so late in the game :)
We're working on it.
> >From eee5cd99ea3b4e93f41e7f6486d799d198c87750 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 29 May 2008 17:51:05 +1000
> Subject: [PATCH] sparc: fallout from pci_name() constifying
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/sparc64/kernel/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/sparc64/kernel/pci.c b/arch/sparc64/kernel/pci.c
> index 112b09f..5509619 100644
> --- a/arch/sparc64/kernel/pci.c
> +++ b/arch/sparc64/kernel/pci.c
> @@ -408,7 +408,7 @@ struct pci_dev *of_create_pci_dev(struct pci_pbm_info *pbm,
> dev->class = class >> 8;
> dev->revision = class & 0xff;
>
> - sprintf(pci_name(dev), "%04x:%02x:%02x.%d", pci_domain_nr(bus),
> + dev_set_name(&dev->dev, "%04x:%02x:%02x.%d", pci_domain_nr(bus),
> dev->bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn));
It's wierd that we broke the build like this, I'll work to merge this in
so that it isn't broken.
thanks,
greg k-h
next prev parent reply other threads:[~2008-05-29 22:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 7:53 linux-next: sparc64 build failure Stephen Rothwell
2008-05-29 22:01 ` Greg KH [this message]
2008-05-30 5:38 ` Stephen Rothwell
2008-05-30 14:10 ` Greg KH
2008-06-20 0:43 Stephen Rothwell
2008-06-20 0:55 ` David Miller
2008-06-20 1:11 ` Stephen Rothwell
2008-06-20 7:34 ` Sam Ravnborg
2008-06-20 7:53 ` Stephen Rothwell
2008-06-20 8:34 ` Sam Ravnborg
2008-06-21 0:02 ` Stephen Rothwell
2008-07-08 9:08 Stephen Rothwell
2008-07-08 9:13 ` David Miller
2008-07-09 11:15 Stephen Rothwell
2008-07-09 21:23 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529220158.GA3867@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).