From: Jens Axboe <jens.axboe@oracle.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-next@vger.kernel.org
Subject: Re: linux-next: generic helpers for arch IPI function calls build bug / s390
Date: Thu, 3 Jul 2008 22:12:35 +0200 [thread overview]
Message-ID: <20080703201235.GD20055@kernel.dk> (raw)
In-Reply-To: <20080703193750.GB8958@osiris.boeblingen.de.ibm.com>
On Thu, Jul 03 2008, Heiko Carstens wrote:
> Jens,
>
> you forgot to remove #include <linux/spinlock.h> from linux/smp.h while
> fixing the original s390 build bug.
>
> Patch below fixes this build bug caused by header inclusion dependencies:
>
> CC kernel/timer.o
> In file included from include/linux/spinlock.h:87,
> from include/linux/smp.h:11,
> from include/linux/kernel_stat.h:4,
> from kernel/timer.c:22:
> include/asm/spinlock.h: In function '__raw_spin_lock':
> include/asm/spinlock.h:69: error: implicit declaration of function 'smp_processor_id'
>
> Please merge the patch below with
>
> "Add generic helpers for arch IPI function calls"
>
> Thanks.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> include/linux/smp.h | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: linux-next/include/linux/smp.h
> ===================================================================
> --- linux-next.orig/include/linux/smp.h
> +++ linux-next/include/linux/smp.h
> @@ -8,7 +8,6 @@
>
> #include <linux/errno.h>
> #include <linux/list.h>
> -#include <linux/spinlock.h>
> #include <linux/cpumask.h>
>
> extern void cpu_idle(void);
ugh indeed, that was silly. Thanks!
--
Jens Axboe
prev parent reply other threads:[~2008-07-03 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 19:37 linux-next: generic helpers for arch IPI function calls build bug / s390 Heiko Carstens
2008-07-03 20:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703201235.GD20055@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).