linux-next: generic helpers for arch IPI function calls build bug / s390

linux-next: generic helpers for arch IPI function calls build bug / s390

[Heiko Carstens]

Jens,

you forgot to remove #include <linux/spinlock.h> from linux/smp.h while
fixing the original s390 build bug.

Patch below fixes this build bug caused by header inclusion dependencies:

  CC      kernel/timer.o
In file included from include/linux/spinlock.h:87,
                 from include/linux/smp.h:11,
                 from include/linux/kernel_stat.h:4,
                 from kernel/timer.c:22:
include/asm/spinlock.h: In function '__raw_spin_lock':
include/asm/spinlock.h:69: error: implicit declaration of function 'smp_processor_id'

Please merge the patch below with

"Add generic helpers for arch IPI function calls"

Thanks.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
 include/linux/smp.h |    1 -
 1 file changed, 1 deletion(-)

Index: linux-next/include/linux/smp.h
===================================================================
--- linux-next.orig/include/linux/smp.h
+++ linux-next/include/linux/smp.h
@@ -8,7 +8,6 @@
 
 #include <linux/errno.h>
 #include <linux/list.h>
-#include <linux/spinlock.h>
 #include <linux/cpumask.h>
 
 extern void cpu_idle(void);

Re: linux-next: generic helpers for arch IPI function calls build bug / s390

[Jens Axboe]

On Thu, Jul 03 2008, Heiko Carstens wrote:
> Jens,
> 
> you forgot to remove #include <linux/spinlock.h> from linux/smp.h while
> fixing the original s390 build bug.
> 
> Patch below fixes this build bug caused by header inclusion dependencies:
> 
>   CC      kernel/timer.o
> In file included from include/linux/spinlock.h:87,
>                  from include/linux/smp.h:11,
>                  from include/linux/kernel_stat.h:4,
>                  from kernel/timer.c:22:
> include/asm/spinlock.h: In function '__raw_spin_lock':
> include/asm/spinlock.h:69: error: implicit declaration of function 'smp_processor_id'
> 
> Please merge the patch below with
> 
> "Add generic helpers for arch IPI function calls"
> 
> Thanks.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>  include/linux/smp.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-next/include/linux/smp.h
> ===================================================================
> --- linux-next.orig/include/linux/smp.h
> +++ linux-next/include/linux/smp.h
> @@ -8,7 +8,6 @@
>  
>  #include <linux/errno.h>
>  #include <linux/list.h>
> -#include <linux/spinlock.h>
>  #include <linux/cpumask.h>
>  
>  extern void cpu_idle(void);

ugh indeed, that was silly. Thanks!

-- 
Jens Axboe