linux-next: crypto tree build failure

linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]

Hi Herbert,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

crypto/built-in.o: In function `.test_aead':
testmgr.c:(.text+0x8378): undefined reference to `.crypto_aead_setauthsize'
testmgr.c:(.text+0x874c): undefined reference to `.crypto_aead_setauthsize'
crypto/built-in.o: In function `.alg_test_aead':
testmgr.c:(.text+0x8bb4): undefined reference to `.crypto_alloc_aead'

I added the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From d72a0cb337ed3a553c502e221efbd8dcf725048d Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 5 Aug 2008 14:00:20 +1000
Subject: [PATCH] crypto: tetsmgr linking fix

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 crypto/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/crypto/Makefile b/crypto/Makefile
index 59ab500..ba73c57 100644
--- a/crypto/Makefile
+++ b/crypto/Makefile
@@ -24,7 +24,7 @@ obj-$(CONFIG_CRYPTO_HASH) += crypto_hash.o
 
 cryptomgr-objs := algboss.o testmgr.o
 
-obj-$(CONFIG_CRYPTO_MANAGER) += cryptomgr.o
+obj-$(CONFIG_CRYPTO_MANAGER) += cryptomgr.o aead.o
 obj-$(CONFIG_CRYPTO_HMAC) += hmac.o
 obj-$(CONFIG_CRYPTO_XCBC) += xcbc.o
 obj-$(CONFIG_CRYPTO_NULL) += crypto_null.o
-- 
1.5.6.3


[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: crypto tree build failure

[Herbert Xu]

On Tue, Aug 05, 2008 at 02:02:57PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> crypto/built-in.o: In function `.test_aead':
> testmgr.c:(.text+0x8378): undefined reference to `.crypto_aead_setauthsize'
> testmgr.c:(.text+0x874c): undefined reference to `.crypto_aead_setauthsize'
> crypto/built-in.o: In function `.alg_test_aead':
> testmgr.c:(.text+0x8bb4): undefined reference to `.crypto_alloc_aead'
> 
> I added the following patch.

Thanks Stephen.  I've fixed it with the following patch.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 4f72b30..a3f4b4f 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -40,7 +40,9 @@ config CRYPTO_HASH
 
 config CRYPTO_MANAGER
 	tristate "Cryptographic algorithm manager"
-	select CRYPTO_ALGAPI
+	select CRYPTO_AEAD
+	select CRYPTO_HASH
+	select CRYPTO_BLKCIPHER
 	help
 	  Create default cryptographic template instantiations such as
 	  cbc(aes).
@@ -85,9 +87,7 @@ config CRYPTO_AUTHENC
 config CRYPTO_TEST
 	tristate "Testing module"
 	depends on m
-	select CRYPTO_ALGAPI
-	select CRYPTO_AEAD
-	select CRYPTO_BLKCIPHER
+	select CRYPTO_MANAGER
 	help
 	  Quick & dirty crypto test module.
 

Re: linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Hi Herbert,

On Tue, 5 Aug 2008 13:36:28 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> I've fixed it with the following patch.
> 
> --
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 4f72b30..a3f4b4f 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -40,7 +40,9 @@ config CRYPTO_HASH
>  
>  config CRYPTO_MANAGER
>  	tristate "Cryptographic algorithm manager"
> -	select CRYPTO_ALGAPI
> +	select CRYPTO_AEAD
> +	select CRYPTO_HASH
> +	select CRYPTO_BLKCIPHER
>  	help
>  	  Create default cryptographic template instantiations such as
>  	  cbc(aes).
> @@ -85,9 +87,7 @@ config CRYPTO_AUTHENC
>  config CRYPTO_TEST
>  	tristate "Testing module"
>  	depends on m
> -	select CRYPTO_ALGAPI
> -	select CRYPTO_AEAD
> -	select CRYPTO_BLKCIPHER
> +	select CRYPTO_MANAGER
>  	help
>  	  Quick & dirty crypto test module.

I am guessing that will help with these errors as well?

testmgr.c:(.text+0x6404): undefined reference to `.crypto_alloc_ablkcipher

(From a powerpc cell_defconfig build)
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: crypto tree build failure

[Herbert Xu]

On Tue, Aug 05, 2008 at 11:33:00PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> On Tue, 5 Aug 2008 13:36:28 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > I've fixed it with the following patch.
> > 
> > --
> > diff --git a/crypto/Kconfig b/crypto/Kconfig
> > index 4f72b30..a3f4b4f 100644
> > --- a/crypto/Kconfig
> > +++ b/crypto/Kconfig
> > @@ -40,7 +40,9 @@ config CRYPTO_HASH
> >  
> >  config CRYPTO_MANAGER
> >  	tristate "Cryptographic algorithm manager"
> > -	select CRYPTO_ALGAPI
> > +	select CRYPTO_AEAD
> > +	select CRYPTO_HASH
> > +	select CRYPTO_BLKCIPHER
> >  	help
> >  	  Create default cryptographic template instantiations such as
> >  	  cbc(aes).
> > @@ -85,9 +87,7 @@ config CRYPTO_AUTHENC
> >  config CRYPTO_TEST
> >  	tristate "Testing module"
> >  	depends on m
> > -	select CRYPTO_ALGAPI
> > -	select CRYPTO_AEAD
> > -	select CRYPTO_BLKCIPHER
> > +	select CRYPTO_MANAGER
> >  	help
> >  	  Quick & dirty crypto test module.
> 
> I am guessing that will help with these errors as well?
> 
> testmgr.c:(.text+0x6404): undefined reference to `.crypto_alloc_ablkcipher

Yes it should.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi Herbert,

On Tue, 5 Aug 2008 22:05:04 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Tue, Aug 05, 2008 at 11:33:00PM +1000, Stephen Rothwell wrote:
> > 
> > I am guessing that will help with these errors as well?
> > 
> > testmgr.c:(.text+0x6404): undefined reference to `.crypto_alloc_ablkcipher
> 
> Yes it should.

Great, thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Hi Herbert,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

ERROR: ".crc32c" [net/ipv4/netfilter/nf_nat_proto_sctp.ko] undefined!

I am not quite sure which commit caused this, but there are recent
commits to the crypto tree that play with crc32c, so I am dropping the
crypto tree for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: crypto tree build failure

[Herbert Xu]

On Tue, Nov 11, 2008 at 03:07:31PM +1100, Stephen Rothwell wrote:
> Hi Herbert,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> ERROR: ".crc32c" [net/ipv4/netfilter/nf_nat_proto_sctp.ko] undefined!
> 
> I am not quite sure which commit caused this, but there are recent
> commits to the crypto tree that play with crc32c, so I am dropping the
> crypto tree for today.

I've just pushed an update to master which should fix this issue.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi Herbert,

On Tue, 11 Nov 2008 12:22:59 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> I've just pushed an update to master which should fix this issue.

Thanks.  The crypto tree should be back in linux-next tomorrow, then.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Hi Herbert,

Today's linux-next build (x86_64 allmodconfig) failed like this:

crypto/built-in.o: In function `md5_mod_init':
crypto/md5.c:239: undefined reference to `crypto_register_shash'
crypto/built-in.o: In function `md5_mod_fini':
crypto/md5.c:244: undefined reference to `crypto_unregister_shash'

Presumably caused by commit 08cf233c1f29fc1cad8786b3c73647625810665b
("crypto: md5 - Switch to shash").

I have dropped the crypto tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: crypto tree build failure

[Herbert Xu]

On Thu, Dec 04, 2008 at 01:43:31PM +1100, Stephen Rothwell wrote:
> Hi Herbert,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> crypto/built-in.o: In function `md5_mod_init':
> crypto/md5.c:239: undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `md5_mod_fini':
> crypto/md5.c:244: undefined reference to `crypto_unregister_shash'

Thanks for the note Stephen.  It should be fixed now.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

Hi Herbert,

Today's linux-next build (x86_64 allmodconfig) failed like this:

arch/x86/crypto/aesni-intel_glue.c:22:21: error: asm/aes.h: No such file or directory
arch/x86/crypto/aesni-intel_glue.c: In function 'aes_encrypt':
arch/x86/crypto/aesni-intel_glue.c:98: error: implicit declaration of function 'crypto_aes_encrypt_x86'
arch/x86/crypto/aesni-intel_glue.c: In function 'aes_decrypt':
arch/x86/crypto/aesni-intel_glue.c:111: error: implicit declaration of function 'crypto_aes_decrypt_x86'

Immediate cause is commit 9afc33f2f32204a779ef6c96728a034bcf4df29f
("crypto: aes-ni - Add support to Intel AES-NI instructions for x86_64
platform").

I have dropped the crypto tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: crypto tree build failure

[Huang Ying]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi, Herbert,

On Tue, 2009-01-20 at 10:30 +0800, Stephen Rothwell wrote:
> Hi Herbert,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> arch/x86/crypto/aesni-intel_glue.c:22:21: error: asm/aes.h: No such file or directory

I don't know why. But it seems that asm/aes.h is not included in git,
while it is in my original patch. I will submit a fix patch.

Best Regards,
Huang Ying



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: crypto tree build failure

[Herbert Xu]

On Tue, Jan 20, 2009 at 11:04:27AM +0800, Huang Ying wrote:
>
> I don't know why. But it seems that asm/aes.h is not included in git,
> while it is in my original patch. I will submit a fix patch.

Don't worry.  I'll fix it up in my tree.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: linux-next: crypto tree build failure

[Herbert Xu]

On Tue, Jan 20, 2009 at 01:30:43PM +1100, Stephen Rothwell wrote:
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> arch/x86/crypto/aesni-intel_glue.c:22:21: error: asm/aes.h: No such file or directory
> arch/x86/crypto/aesni-intel_glue.c: In function 'aes_encrypt':
> arch/x86/crypto/aesni-intel_glue.c:98: error: implicit declaration of function 'crypto_aes_encrypt_x86'
> arch/x86/crypto/aesni-intel_glue.c: In function 'aes_decrypt':
> arch/x86/crypto/aesni-intel_glue.c:111: error: implicit declaration of function 'crypto_aes_decrypt_x86'
> 
> Immediate cause is commit 9afc33f2f32204a779ef6c96728a034bcf4df29f
> ("crypto: aes-ni - Add support to Intel AES-NI instructions for x86_64
> platform").
> 
> I have dropped the crypto tree for today.

Sorry for the screw up.  It shold be fixed now.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

Hi Herbert,

On Tue, 20 Jan 2009 16:21:41 +1100 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Sorry for the screw up.  It shold be fixed now.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

Hi Herbert,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/crypto/padlock-aes.c:21:22: error: asm/i387.h: No such file or directory
drivers/crypto/padlock-aes.c: In function 'aes_encrypt':
drivers/crypto/padlock-aes.c:251: error: implicit declaration of function 'irq_ts_save'
drivers/crypto/padlock-aes.c:253: error: implicit declaration of function 'irq_ts_restore'
drivers/crypto/padlock-aes.c: In function 'padlock_init':
drivers/crypto/padlock-aes.c:458: error: 'cpu_has_xcrypt' undeclared (first use in this function)
drivers/crypto/padlock-aes.c:463: error: 'cpu_has_xcrypt_enabled' undeclared (first use in this function)
drivers/crypto/padlock-sha.c:25:22: error: asm/i387.h: No such file or directory
drivers/crypto/padlock-sha.c: In function 'padlock_do_sha1':
drivers/crypto/padlock-sha.c:115: error: implicit declaration of function 'irq_ts_save'
drivers/crypto/padlock-sha.c:119: error: implicit declaration of function 'irq_ts_restore'
drivers/crypto/padlock-sha.c: In function 'padlock_init':
drivers/crypto/padlock-sha.c:265: error: 'cpu_has_phe' undeclared (first use in this function)
drivers/crypto/padlock-sha.c:270: error: 'cpu_has_phe_enabled' undeclared (first use in this function)

Caused by commit 93628c83b00492fc592a29d0dc91efb1d55c6e24 ("crypto:
padlock - Enable on x86_64") which actually enabled it for everything
(except UML)!

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: crypto tree build failure

[Herbert Xu]

On Wed, Apr 22, 2009 at 02:47:06PM +1000, Stephen Rothwell wrote:
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:

Doh, I'm going to add this patch.

Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Wed Apr 22 13:00:15 2009 +0800

    crypto: padlock - Restore dependency on x86
    
    When we added 64-bit support to padlock the dependency on x86
    was lost.  This causes build failures on non-x86 architectures.
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 39eedd4..e748e55 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -12,7 +12,7 @@ if CRYPTO_HW
 
 config CRYPTO_DEV_PADLOCK
 	tristate "Support for VIA PadLock ACE"
-	depends on !UML
+	depends on X86 && !UML
 	select CRYPTO_ALGAPI
 	help
 	  Some VIA processors come with an integrated crypto engine

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: linux-next: crypto tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

Hi Herbert,

On Wed, 22 Apr 2009 13:00:56 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Doh, I'm going to add this patch.

Looks good, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: crypto tree build failure

[Sebastian Andrzej Siewior]

* Herbert Xu | 2009-04-22 13:00:56 [+0800]:

>On Wed, Apr 22, 2009 at 02:47:06PM +1000, Stephen Rothwell wrote:
>> 
>> Today's linux-next build (powerpc allyesconfig) failed like this:
>
>Doh, I'm going to add this patch.
Ups. Thx Herbert.

Sebastian