linux-next: ide tree build failure

linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

Hi Bart,

The linux-next build for 20080808 and later failed like this (on at least
sparc, mips and m68k):

drivers/ide/ide-floppy.c:223: error: implicit declaration of function `sg_page'
drivers/ide/ide-floppy.c:232: error: implicit declaration of function `sg_virt'
drivers/ide/ide-floppy.c:242: error: implicit declaration of function `sg_next'

Caused by commit 788fc238e7b95dae0ff1e2e7c97351289277deea ("ide-floppy:
use scatterlists for pio transfers") which intrduced usages of the sg_
routines but did not include <linux/scatterlist.h>.

I will add an include of <linux/scatterlist.h> near the top of
drivers/ide/ide-floppy.c in linux-next today.  It would be good if the
above patch was fixed up, or another patch added to the ide tree fixing
this.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: ide tree build failure

[Borislav Petkov]

On Tue, Aug 12, 2008 at 11:18:01AM +1000, Stephen Rothwell wrote:
> Hi Bart,
> 
> The linux-next build for 20080808 and later failed like this (on at least
> sparc, mips and m68k):
> 
> drivers/ide/ide-floppy.c:223: error: implicit declaration of function `sg_page'
> drivers/ide/ide-floppy.c:232: error: implicit declaration of function `sg_virt'
> drivers/ide/ide-floppy.c:242: error: implicit declaration of function `sg_next'
> 
> Caused by commit 788fc238e7b95dae0ff1e2e7c97351289277deea ("ide-floppy:
> use scatterlists for pio transfers") which intrduced usages of the sg_
> routines but did not include <linux/scatterlist.h>.

Thanks and sorry about that. I am pretty sure I did include it but probably in
an older version of the patch and forgot to refresh it before sending. Bart, can
you please add the include-line?

> 
> I will add an include of <linux/scatterlist.h> near the top of
> drivers/ide/ide-floppy.c in linux-next today.  It would be good if the
> above patch was fixed up, or another patch added to the ide tree fixing
> this.


-- 
Regards/Gruss,
    Boris.

Re: linux-next: ide tree build failure

[Bartlomiej Zolnierkiewicz]

On Tuesday 12 August 2008, Borislav Petkov wrote:
> On Tue, Aug 12, 2008 at 11:18:01AM +1000, Stephen Rothwell wrote:
> > Hi Bart,
> > 
> > The linux-next build for 20080808 and later failed like this (on at least
> > sparc, mips and m68k):
> > 
> > drivers/ide/ide-floppy.c:223: error: implicit declaration of function `sg_page'
> > drivers/ide/ide-floppy.c:232: error: implicit declaration of function `sg_virt'
> > drivers/ide/ide-floppy.c:242: error: implicit declaration of function `sg_next'
> > 
> > Caused by commit 788fc238e7b95dae0ff1e2e7c97351289277deea ("ide-floppy:
> > use scatterlists for pio transfers") which intrduced usages of the sg_
> > routines but did not include <linux/scatterlist.h>.
> 
> Thanks and sorry about that. I am pretty sure I did include it but probably in
> an older version of the patch and forgot to refresh it before sending. Bart, can
> you please add the include-line?

Done.

linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi Bart,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/ide/ide-tape.c: In function 'idetape_chrdev_open':
drivers/ide/ide-tape.c:1515: error: implicit declaration of function 'idetape_read_position'

Caused by commit 55ce3a129ea2e8faba4a11bb5dbc305590d1c20c ("ide-tape: fix
READ POSITION cmd handling") interacting with the later merge
8dcce4081305d3d1629190edd112e6473c315cbc ("Merge branch
'bp-remove-pc-buf' into for-next").

I have used the ide tree from next-20090612 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: ide tree build failure

[Borislav Petkov]

Hi,

On Mon, Jun 15, 2009 at 11:34:30AM +1000, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/ide/ide-tape.c: In function 'idetape_chrdev_open':
> drivers/ide/ide-tape.c:1515: error: implicit declaration of function 'idetape_read_position'
> 
> Caused by commit 55ce3a129ea2e8faba4a11bb5dbc305590d1c20c ("ide-tape: fix
> READ POSITION cmd handling") interacting with the later merge
> 8dcce4081305d3d1629190edd112e6473c315cbc ("Merge branch
> 'bp-remove-pc-buf' into for-next").
> 
> I have used the ide tree from next-20090612 for today.

Ah, the function got renamed in 55ce3a129ea2e8faba4a11bb5dbc305590d1c20c. Here's
a fix:

---
From: Borislav Petkov <petkovbb@gmail.com>
Date: Mon, 15 Jun 2009 07:32:04 +0200
Subject: [PATCH] ide-tape: fix build issue

This fixes

drivers/ide/ide-tape.c: In function `idetape_chrdev_open':
drivers/ide/ide-tape.c:1515: error: implicit declaration of function `idetape_read_position'
make[1]: *** [drivers/ide/ide-tape.o] Error 1

Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
 drivers/ide/ide-tape.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index bb71e1e..3a3f10f 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -1512,7 +1512,7 @@ static int idetape_chrdev_open(struct inode *inode, struct file *filp)
 		goto out_put_tape;
 	}
 
-	idetape_read_position(drive);
+	ide_tape_read_position(drive);
 	if (!test_bit(ilog2(IDE_AFLAG_ADDRESS_VALID), &drive->atapi_flags))
 		(void)idetape_rewind_tape(drive);
 
-- 
1.6.3.1


-- 
Regards/Gruss,
    Boris.

Re: linux-next: ide tree build failure

[Bartlomiej Zolnierkiewicz]

On Monday 15 June 2009 07:35:14 Borislav Petkov wrote:
> Hi,
> 
> On Mon, Jun 15, 2009 at 11:34:30AM +1000, Stephen Rothwell wrote:
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > drivers/ide/ide-tape.c: In function 'idetape_chrdev_open':
> > drivers/ide/ide-tape.c:1515: error: implicit declaration of function 'idetape_read_position'
> > 
> > Caused by commit 55ce3a129ea2e8faba4a11bb5dbc305590d1c20c ("ide-tape: fix
> > READ POSITION cmd handling") interacting with the later merge
> > 8dcce4081305d3d1629190edd112e6473c315cbc ("Merge branch
> > 'bp-remove-pc-buf' into for-next").
> > 
> > I have used the ide tree from next-20090612 for today.
> 
> Ah, the function got renamed in 55ce3a129ea2e8faba4a11bb5dbc305590d1c20c. Here's
> a fix:
> 
> ---
> From: Borislav Petkov <petkovbb@gmail.com>
> Date: Mon, 15 Jun 2009 07:32:04 +0200
> Subject: [PATCH] ide-tape: fix build issue
> 
> This fixes
> 
> drivers/ide/ide-tape.c: In function `idetape_chrdev_open':
> drivers/ide/ide-tape.c:1515: error: implicit declaration of function `idetape_read_position'
> make[1]: *** [drivers/ide/ide-tape.o] Error 1
> 
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>

thanks, applied

linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi Bart,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/ide/scc_pata.c: In function 'scc_tf_load':
drivers/ide/scc_pata.c:675: error: 'IDE_TFLAG_FLAGGED' undeclared (first use in this function)

Caused by commit 0b6008f9f765b9988b3f86c5fe74cd9873d34c61 ("ide: add
"flagged" taskfile flags to struct ide_taskfile").

I have dropped the ide tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Hi Bart,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/ide/ide-eh.c: In function 'do_reset1':
drivers/ide/ide-eh.c:341: error: implicit declaration of function 'ndelay'

The immediate cause is commit 891ac63a7b4e11f13cfdbef59c77d489edd8e0ba
("ide: move error handling code to ide-eh.c").

I have dropped the ide tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: ide tree build failure

[Bartlomiej Zolnierkiewicz]

Hi,

On Thursday 22 January 2009, Stephen Rothwell wrote:
> Hi Bart,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/ide/ide-eh.c: In function 'do_reset1':
> drivers/ide/ide-eh.c:341: error: implicit declaration of function 'ndelay'
> 
> The immediate cause is commit 891ac63a7b4e11f13cfdbef59c77d489edd8e0ba
> ("ide: move error handling code to ide-eh.c").
> 
> I have dropped the ide tree for today.

Yeah, ide-eh.c should explicitly include <linux/delay.h>
(on x86 it gets pulled indirectly so I haven't noticed it).

Should be fixed now.

Thanks,
Bart

Re: linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi Bart,

On Thu, 22 Jan 2009 14:22:34 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> Yeah, ide-eh.c should explicitly include <linux/delay.h>
> (on x86 it gets pulled indirectly so I haven't noticed it).

Indeed.

> Should be fixed now.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hi Bart,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/built-in.o: In function `.ide_cd_do_request':
ide-cd.c:(.text+0x11a97c): undefined reference to `.ide_cd_get_xferlen'
drivers/built-in.o:(.toc1+0x83b8): undefined reference to `ide_cd_expiry'

So I have dropped the ide tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: ide tree build failure

[Bartlomiej Zolnierkiewicz]

On Monday 08 December 2008, Stephen Rothwell wrote:
> Hi Bart,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/built-in.o: In function `.ide_cd_do_request':
> ide-cd.c:(.text+0x11a97c): undefined reference to `.ide_cd_get_xferlen'
> drivers/built-in.o:(.toc1+0x83b8): undefined reference to `ide_cd_expiry'

I see, BLK_DEV_IDECD needs to select IDE_ATAPI now.  I updated
ide-atapi-accomodate-transfer-length-calculation-for-ide-cd.patch
accordingly so ppc64_defconfing should build fine again.

Thanks,
Bart

Re: linux-next: ide tree build failure

[Borislav Petkov]

On Mon, Dec 8, 2008 at 6:10 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> On Monday 08 December 2008, Stephen Rothwell wrote:
>> Hi Bart,
>>
>> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>>
>> drivers/built-in.o: In function `.ide_cd_do_request':
>> ide-cd.c:(.text+0x11a97c): undefined reference to `.ide_cd_get_xferlen'
>> drivers/built-in.o:(.toc1+0x83b8): undefined reference to `ide_cd_expiry'
>
> I see, BLK_DEV_IDECD needs to select IDE_ATAPI now.  I updated
> ide-atapi-accomodate-transfer-length-calculation-for-ide-cd.patch
> accordingly so ppc64_defconfing should build fine again.

Ups, sorry for that one.

-- 
Regards/Gruss,
Boris

Re: linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi Bart,

On Mon, 8 Dec 2008 18:10:59 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> I see, BLK_DEV_IDECD needs to select IDE_ATAPI now.  I updated
> ide-atapi-accomodate-transfer-length-calculation-for-ide-cd.patch
> accordingly so ppc64_defconfing should build fine again.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: ide tree build failure

[Stephen Rothwell]

Hi Bart,

Today's linux-next build (x86_64_allmodconfig) failed like this:

ERROR: "ide_floppy_ioctl" [drivers/ide/ide-floppy_mod.ko] undefined!

Introduced by commit 487a606ecd39be80655bddc7f8d14bfdf48bf682
("ide-floppy: move all ioctl handling to ide-floppy_ioctl.c").

I added the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 26 Aug 2008 14:04:59 +1000
Subject: [PATCH] ide: fix for idefloppy_ioctl name change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/ide/ide-floppy_ioctl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-floppy_ioctl.c b/drivers/ide/ide-floppy_ioctl.c
index 1fc4050..a3a7a08 100644
--- a/drivers/ide/ide-floppy_ioctl.c
+++ b/drivers/ide/ide-floppy_ioctl.c
@@ -260,7 +260,7 @@ static int ide_floppy_format_ioctl(ide_drive_t *drive, struct file *file,
 	}
 }
 
-int idefloppy_ioctl(struct inode *inode, struct file *file,
+int ide_floppy_ioctl(struct inode *inode, struct file *file,
 		    unsigned int cmd, unsigned long arg)
 {
 	struct block_device *bdev = inode->i_bdev;
-- 
1.5.6.5

Re: linux-next: ide tree build failure

[Bartlomiej Zolnierkiewicz]

Hi,

On Tuesday 26 August 2008, Stephen Rothwell wrote:
> Hi Bart,
> 
> Today's linux-next build (x86_64_allmodconfig) failed like this:
> 
> ERROR: "ide_floppy_ioctl" [drivers/ide/ide-floppy_mod.ko] undefined!
> 
> Introduced by commit 487a606ecd39be80655bddc7f8d14bfdf48bf682
> ("ide-floppy: move all ioctl handling to ide-floppy_ioctl.c").
> 
> I added the following patch.

I integrated it into the guilty commit, thanks!

linux-next: ide tree build failure

[Stephen Rothwell]

Hi Bart,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/ide/ppc/pmac.c: In function 'set_timings_mdma':
drivers/ide/ppc/pmac.c:689: error: expected ']' before ')' token

Caused by commit 010fac593cedbdea4841ffcf49d2ea10e8651c6f "ide: make
drive->id an union".

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 5123642db8897eb15653453f0f76d33d2a5be19e Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 24 Jul 2008 13:15:15 +1000
Subject: [PATCH] ide: fix typo in drivers/ide/ppc/pmac.c

drivers/ide/ppc/pmac.c: In function 'set_timings_mdma':
drivers/ide/ppc/pmac.c:689: error: expected ']' before ')' token

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/ide/ppc/pmac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index 0f636a5..9d8b317 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -686,7 +686,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
 	}
 
 	/* Check if drive provides explicit DMA cycle time */
-	if ((id[ATA_ID_FIELD_VALID] & 2) && id[ATA_ID_EIDE_DMA_TIME)
+	if ((id[ATA_ID_FIELD_VALID] & 2) && id[ATA_ID_EIDE_DMA_TIME])
 		cycleTime = max_t(int, id[ATA_ID_EIDE_DMA_TIME], cycleTime);
 
 	/* OHare limits according to some old Apple sources */	
-- 
1.5.6.3

Re: linux-next: ide tree build failure

[Bartlomiej Zolnierkiewicz]

On Thursday 24 July 2008, Stephen Rothwell wrote:
> Hi Bart,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/ide/ppc/pmac.c: In function 'set_timings_mdma':
> drivers/ide/ppc/pmac.c:689: error: expected ']' before ')' token
> 
> Caused by commit 010fac593cedbdea4841ffcf49d2ea10e8651c6f "ide: make
> drive->id an union".
> 
> I applied the following patch.

Thanks, I integrated it into v2 of the guilty patch.

> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 
> From 5123642db8897eb15653453f0f76d33d2a5be19e Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 24 Jul 2008 13:15:15 +1000
> Subject: [PATCH] ide: fix typo in drivers/ide/ppc/pmac.c
> 
> drivers/ide/ppc/pmac.c: In function 'set_timings_mdma':
> drivers/ide/ppc/pmac.c:689: error: expected ']' before ')' token
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/ide/ppc/pmac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
> index 0f636a5..9d8b317 100644
> --- a/drivers/ide/ppc/pmac.c
> +++ b/drivers/ide/ppc/pmac.c
> @@ -686,7 +686,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
>  	}
>  
>  	/* Check if drive provides explicit DMA cycle time */
> -	if ((id[ATA_ID_FIELD_VALID] & 2) && id[ATA_ID_EIDE_DMA_TIME)
> +	if ((id[ATA_ID_FIELD_VALID] & 2) && id[ATA_ID_EIDE_DMA_TIME])
>  		cycleTime = max_t(int, id[ATA_ID_EIDE_DMA_TIME], cycleTime);
>  
>  	/* OHare limits according to some old Apple sources */	
> -- 
> 1.5.6.3

linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]

Hi Bart,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/ide/ppc/pmac.c: In function 'pmac_ide_setup_device':
drivers/ide/ppc/pmac.c:1115: error: implicit declaration of function 'ide_alloc_host'
drivers/ide/ppc/pmac.c:1115: warning: assignment makes pointer from integer without a cast

Caused by commit 9cfe46a0547b6a1481e773785bceb6a319963b49 ("ide: add
struct ide_host (take 2)") from the ide tree which I have reverted.

Then the x86_64 allmodconfig build fails with:

ERROR: "ide_init_port_hw" [drivers/ide/legacy/ide-cs.ko] undefined!

For which I applied the patch below.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 1bdb17cc47df67e2ca9137ca80d23cc3ac6c61cc Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 30 Jun 2008 15:26:59 +1000
Subject: [PATCH] ide: export ide_init_port_hw to modules

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/ide/ide.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index d7ae256..7e905cc 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -288,6 +288,7 @@ void ide_init_port_hw(ide_hwif_t *hwif, hw_regs_t *hw)
 	hwif->ack_intr = hw->ack_intr;
 	hwif->config_data = hw->config;
 }
+EXPORT_SYMBOL_GPL(ide_init_port_hw);
 
 /*
  *	Locks for IDE setting functionality
-- 
1.5.6


[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: ide tree build failure

[Bartlomiej Zolnierkiewicz]

Hi,

On Monday 30 June 2008, Stephen Rothwell wrote:
> Hi Bart,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/ide/ppc/pmac.c: In function 'pmac_ide_setup_device':
> drivers/ide/ppc/pmac.c:1115: error: implicit declaration of function 'ide_alloc_host'
> drivers/ide/ppc/pmac.c:1115: warning: assignment makes pointer from integer without a cast

Thanks, I fixed the guilty patch.

> Caused by commit 9cfe46a0547b6a1481e773785bceb6a319963b49 ("ide: add
> struct ide_host (take 2)") from the ide tree which I have reverted.
> 
> Then the x86_64 allmodconfig build fails with:
> 
> ERROR: "ide_init_port_hw" [drivers/ide/legacy/ide-cs.ko] undefined!

ditto :)

Bart

Re: linux-next: ide tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

hi Bart,

On Mon, 30 Jun 2008 20:38:20 +0200 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> Thanks, I fixed the guilty patch.
> 
> ditto :)

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]