From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-next@vger.kernel.org, Andreas Oberritter <obi@linuxtv.org>
Subject: linux-next: v4l-dvb tree build failure
Date: Wed, 29 Oct 2008 13:20:11 +1100 [thread overview]
Message-ID: <20081029132011.920a9b6f.sfr@canb.auug.org.au> (raw)
Hi Mauro,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/media/dvb/dvb-core/dvbdev.c: In function 'dvb_register_device':
drivers/media/dvb/dvb-core/dvbdev.c:254: error: implicit declaration of function 'nums2minor'
Caused by commit f3d9182030d9655d9ffff33dfceb45b4a127b6ec ("V4L/DVB
(9361): Dynamic DVB minor allocation") which clearly has not even been
built with CONFIG_DVB_DYNAMIC_MINORS=y.
I applied the following patch.
More care required, please.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 29 Oct 2008 13:16:19 +1100
Subject: [PATCH] v4l-dvb: fallout from DVB_DYNAMIC_MINORS addition
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/media/dvb/dvb-core/dvbdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/dvb/dvb-core/dvbdev.c b/drivers/media/dvb/dvb-core/dvbdev.c
index e363a3b..ebfd913 100644
--- a/drivers/media/dvb/dvb-core/dvbdev.c
+++ b/drivers/media/dvb/dvb-core/dvbdev.c
@@ -251,7 +251,7 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev,
mutex_unlock(&dvbdev_register_lock);
clsdev = device_create(dvb_class, adap->device,
- MKDEV(DVB_MAJOR, nums2minor(adap->num, type, id)),
+ MKDEV(DVB_MAJOR, minor),
NULL, "dvb%d.%s%d", adap->num, dnames[type], id);
if (IS_ERR(clsdev)) {
printk(KERN_ERR "%s: failed to create device dvb%d.%s%d (%ld)\n",
--
1.5.6.5
next reply other threads:[~2008-10-29 2:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 2:20 Stephen Rothwell [this message]
2008-10-29 12:26 ` linux-next: v4l-dvb tree build failure Andreas Oberritter
2008-11-03 1:52 ` Stephen Rothwell
2008-11-05 1:57 ` Stephen Rothwell
2008-11-07 3:30 Stephen Rothwell
2008-11-07 17:43 ` Harvey Harrison
2008-11-07 18:41 ` Greg KH
2008-11-07 23:02 ` Stephen Rothwell
2008-11-12 0:54 ` Mauro Carvalho Chehab
2008-11-12 22:45 ` Greg KH
2008-11-07 22:59 ` Stephen Rothwell
2008-11-07 23:06 ` Greg KH
2008-11-08 3:05 ` Sam Ravnborg
2008-11-08 4:38 ` Greg KH
2008-11-08 5:08 ` Greg KH
2008-11-25 4:41 Stephen Rothwell
2008-12-01 23:37 Stephen Rothwell
2008-12-02 10:03 ` Mauro Carvalho Chehab
2008-12-02 22:23 ` Stephen Rothwell
2008-12-03 22:48 ` Mauro Carvalho Chehab
2008-12-03 0:08 ` Stephen Rothwell
2008-12-03 22:49 ` Mauro Carvalho Chehab
2008-12-08 2:07 Stephen Rothwell
2009-03-02 0:05 Stephen Rothwell
2009-03-02 0:08 ` Michael Krufky
2009-03-02 0:30 ` Stephen Rothwell
2009-03-02 2:52 ` Mauro Carvalho Chehab
2009-03-05 0:35 Stephen Rothwell
2009-03-05 21:51 ` Mauro Carvalho Chehab
2009-03-06 0:05 ` Stephen Rothwell
2009-03-06 1:15 ` Mauro Carvalho Chehab
2009-03-27 0:40 Stephen Rothwell
2009-03-27 11:28 ` Mauro Carvalho Chehab
2009-03-27 14:03 ` Stephen Rothwell
2009-04-07 0:58 Stephen Rothwell
2009-04-07 1:20 ` Mauro Carvalho Chehab
2009-04-07 4:47 ` Stephen Rothwell
2010-01-27 6:59 Stephen Rothwell
2010-01-27 23:24 ` Andy Walls
2010-01-28 1:54 ` Mauro Carvalho Chehab
2010-01-28 5:24 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029132011.920a9b6f.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=obi@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).