linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Walls <awalls@radix.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Devin Heitmueller <dheitmueller@kernellabs.com>
Subject: Re: linux-next: v4l-dvb tree build failure
Date: Wed, 27 Jan 2010 18:24:48 -0500	[thread overview]
Message-ID: <1264634688.3088.1.camel@palomino.walls.org> (raw)
In-Reply-To: <20100127175917.5d690f52.sfr@canb.auug.org.au>

On Wed, 2010-01-27 at 17:59 +1100, Stephen Rothwell wrote:
> Hi Mauro,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> drivers/media/video/cx18/cx18-alsa-pcm.c: In function 'snd_pcm_alloc_vmalloc_buffer':
> drivers/media/video/cx18/cx18-alsa-pcm.c:234: error: implicit declaration of function 'vfree'
> drivers/media/video/cx18/cx18-alsa-pcm.c:236: error: implicit declaration of function 'vmalloc'
> 
> Caused by commit 5e9a302853301e0a2bb6671036daac3366fd85f4 ("V4L/DVB: cx18: overhaul ALSA PCM device handling so it works").
> 
> I applied the following patch for today.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 27 Jan 2010 17:53:39 +1100
> Subject: [PATCH] V4L/DVB: using vmalloc requires include of linux/vmalloc.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Stephen,

Looks good to me.

Acked-by: Andy Walls <awalls@radix.net>

Regards,
Andy

> ---
>  drivers/media/video/cx18/cx18-alsa-pcm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
> index 6e56df9..b9f42b1 100644
> --- a/drivers/media/video/cx18/cx18-alsa-pcm.c
> +++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
> @@ -25,6 +25,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/kernel.h>
> +#include <linux/vmalloc.h>
>  
>  #include <media/v4l2-device.h>
>  
> -- 
> 1.6.6
> 

  reply	other threads:[~2010-01-27 23:26 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  6:59 linux-next: v4l-dvb tree build failure Stephen Rothwell
2010-01-27 23:24 ` Andy Walls [this message]
2010-01-28  1:54   ` Mauro Carvalho Chehab
2010-01-28  5:24     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2009-04-07  0:58 Stephen Rothwell
2009-04-07  1:20 ` Mauro Carvalho Chehab
2009-04-07  4:47   ` Stephen Rothwell
2009-03-27  0:40 Stephen Rothwell
2009-03-27 11:28 ` Mauro Carvalho Chehab
2009-03-27 14:03   ` Stephen Rothwell
2009-03-05  0:35 Stephen Rothwell
2009-03-05 21:51 ` Mauro Carvalho Chehab
2009-03-06  0:05   ` Stephen Rothwell
2009-03-06  1:15     ` Mauro Carvalho Chehab
2009-03-02  0:05 Stephen Rothwell
2009-03-02  0:08 ` Michael Krufky
2009-03-02  0:30   ` Stephen Rothwell
2009-03-02  2:52     ` Mauro Carvalho Chehab
2008-12-08  2:07 Stephen Rothwell
2008-12-01 23:37 Stephen Rothwell
2008-12-02 10:03 ` Mauro Carvalho Chehab
2008-12-02 22:23   ` Stephen Rothwell
2008-12-03 22:48     ` Mauro Carvalho Chehab
2008-12-03  0:08   ` Stephen Rothwell
2008-12-03 22:49     ` Mauro Carvalho Chehab
2008-11-25  4:41 Stephen Rothwell
2008-11-07  3:30 Stephen Rothwell
2008-11-07 17:43 ` Harvey Harrison
2008-11-07 18:41   ` Greg KH
2008-11-07 23:02     ` Stephen Rothwell
2008-11-12  0:54     ` Mauro Carvalho Chehab
2008-11-12 22:45       ` Greg KH
2008-11-07 22:59   ` Stephen Rothwell
2008-11-07 23:06     ` Greg KH
2008-11-08  3:05     ` Sam Ravnborg
2008-11-08  4:38       ` Greg KH
2008-11-08  5:08         ` Greg KH
2008-10-29  2:20 Stephen Rothwell
2008-10-29 12:26 ` Andreas Oberritter
2008-11-03  1:52 ` Stephen Rothwell
2008-11-05  1:57   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264634688.3088.1.camel@palomino.walls.org \
    --to=awalls@radix.net \
    --cc=dheitmueller@kernellabs.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).