* [PATCH] cx231xx: fix wrong usage of select in kconfig
@ 2009-04-01 2:03 Alexander Beregalov
0 siblings, 0 replies; only message in thread
From: Alexander Beregalov @ 2009-04-01 2:03 UTC (permalink / raw)
To: linux-next, mchehab, linux-media, srinivasa.deevi
VIDEO_CX231XX_ALSA depends on SND && SND_PCM,
but if we select it from VIDEO_CX231XX entry
it does not automatically select SND_PCM.
It causes build error:
ERROR: "snd_pcm_period_elapsed" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
Documentation/kbuild/kconfig-language.txt:
Note:
select should be used with care. select will force
a symbol to a value without visiting the dependencies.
By abusing select you are able to select a symbol FOO even
if FOO depends on BAR that is not set.
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
drivers/media/video/cx231xx/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx231xx/Kconfig b/drivers/media/video/cx231xx/Kconfig
index 9115654..85ae751 100644
--- a/drivers/media/video/cx231xx/Kconfig
+++ b/drivers/media/video/cx231xx/Kconfig
@@ -6,7 +6,6 @@ config VIDEO_CX231XX
select VIDEO_IR
select VIDEOBUF_VMALLOC
select VIDEO_CX25840
- select VIDEO_CX231XX_ALSA
---help---
This is a video4linux driver for Conexant 231xx USB based TV cards.
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-04-01 2:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-01 2:03 [PATCH] cx231xx: fix wrong usage of select in kconfig Alexander Beregalov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).