[PATCH next] parisc: asm/pdc.h should include asm/page.h

[PATCH next] parisc: asm/pdc.h should include asm/page.h

[Alexander Beregalov]

Fixes this build error:
arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared
(first use in this function)

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---

 arch/parisc/include/asm/pdc.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/parisc/include/asm/pdc.h b/arch/parisc/include/asm/pdc.h
index a26e98d..fde8045 100644
--- a/arch/parisc/include/asm/pdc.h
+++ b/arch/parisc/include/asm/pdc.h
@@ -340,6 +340,7 @@
 #if !defined(__ASSEMBLY__)

 #include <linux/types.h>
+#include <asm/page.h>

 #ifdef __KERNEL__

Re: [PATCH next] parisc: asm/pdc.h should include asm/page.h

[Kyle McMartin]

On Wed, Apr 01, 2009 at 01:44:08PM +0400, Alexander Beregalov wrote:
> Fixes this build error:
> arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared
> (first use in this function)
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>

Huh. Nice. More patches to arch/parisc that didn't go through me that
break things.

Applied, thanks again Alexander.

cheers, Kyle

Re: [PATCH next] parisc: asm/pdc.h should include asm/page.h

[Alexander Beregalov]

2009/4/1 Kyle McMartin <kyle@mcmartin.ca>:
> On Wed, Apr 01, 2009 at 01:44:08PM +0400, Alexander Beregalov wrote:
>> Fixes this build error:
>> arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared
>> (first use in this function)
>>
>> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
>
> Huh. Nice. More patches to arch/parisc that didn't go through me that
> break things.
>
> Applied, thanks again Alexander.

Hi Kyle

Actually the patch does not fix build. It fails with message
"asm-parisc/page.h is not exported".
I do not know what it means.
Should we include page.h in pdc_cons.c instead of pdc.h ?

Re: [PATCH next] parisc: asm/pdc.h should include asm/page.h

[Kyle McMartin]

On Wed, Apr 01, 2009 at 07:06:41PM +0400, Alexander Beregalov wrote:
> 2009/4/1 Kyle McMartin <kyle@mcmartin.ca>:
> > On Wed, Apr 01, 2009 at 01:44:08PM +0400, Alexander Beregalov wrote:
> >> Fixes this build error:
> >> arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared
> >> (first use in this function)
> >>
> >> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> >
> > Huh. Nice. More patches to arch/parisc that didn't go through me that
> > break things.
> >
> > Applied, thanks again Alexander.
> 
> Hi Kyle
> 
> Actually the patch does not fix build. It fails with message
> "asm-parisc/page.h is not exported".
> I do not know what it means.
> Should we include page.h in pdc_cons.c instead of pdc.h ?
> 

Ah, the <asm/page.h> include needs to be inside __KERNEL__.

Care to resend?

cheers, Kyle

Re: [PATCH next] parisc: asm/pdc.h should include asm/page.h

[Alexander Beregalov]

From: Alexander Beregalov <a.beregalov@gmail.com>
Subject: [PATCH] parisc: asm/pdc.h should include asm/page.h

Fixes this build error:
arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---

 arch/parisc/include/asm/pdc.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/parisc/include/asm/pdc.h b/arch/parisc/include/asm/pdc.h
index a26e98d..90d6973 100644
--- a/arch/parisc/include/asm/pdc.h
+++ b/arch/parisc/include/asm/pdc.h
@@ -343,6 +343,8 @@

 #ifdef __KERNEL__

+#include <asm/page.h> /* for __PAGE_OFFSET */
+
 extern int pdc_type;

 /* Values for pdc_type */

Re: [PATCH next] parisc: asm/pdc.h should include asm/page.h

[Kyle McMartin]

On Wed, Apr 01, 2009 at 07:43:40PM +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
> Subject: [PATCH] parisc: asm/pdc.h should include asm/page.h
> 
> Fixes this build error:
> arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>

Thanks, applied.