From: David Miller <davem@davemloft.net>
To: olof@lixom.net
Cc: subrata@linux.vnet.ibm.com, netdev@vger.kernel.org,
geoffrey.levand@am.sony.com, Linuxppc-dev@ozlabs.org,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
sachinp@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
themann@de.ibm.com
Subject: Re: INET_LRO as tristate and use from modules
Date: Wed, 22 Apr 2009 02:12:18 -0700 (PDT) [thread overview]
Message-ID: <20090422.021218.92737677.davem@davemloft.net> (raw)
In-Reply-To: <20090421193319.GB20237@lixom.net>
From: Olof Johansson <olof@lixom.net>
Date: Tue, 21 Apr 2009 14:33:19 -0500
> On Wed, Apr 22, 2009 at 12:23:03AM +0530, Subrata Modak wrote:
>> MODPOST 338 modules
>> ERROR: ".lro_receive_skb" [drivers/net/pasemi_mac_driver.ko] undefined!
>> ERROR: ".lro_flush_all" [drivers/net/pasemi_mac_driver.ko] undefined!
>> WARNING: modpost: Found 1 section mismatch(es).
>> To see full details build your kernel with:
>> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>
> This seems to be a problem with all tristate-capable drivers that use
> LRO (and uses select INET_LRO in their Kconfig): INET_LRO is a tristate
> and can thus be a module. Looks like it needs to be a bool instead?
Yes, making this a bool would be the easiest fix.
By why don't we get the same problem for PHYLIB? It's also
tristate and "select"'d by a whole slew of networking drivers.
next prev parent reply other threads:[~2009-04-22 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 18:53 [BUILD FAILURE 08/12] Next April 21 : PPC64 randconfig [drivers/net/pasemi_mac_driver.ko] Subrata Modak
2009-04-21 19:33 ` INET_LRO as tristate and use from modules (was: Re: [BUILD FAILURE 08/12] Next April 21 : PPC64 randconfig [drivers/net/pasemi_mac_driver.ko]) Olof Johansson
2009-04-22 9:12 ` David Miller [this message]
2009-05-08 19:43 ` INET_LRO as tristate and use from modules David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422.021218.92737677.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linuxppc-dev@ozlabs.org \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=subrata@linux.vnet.ibm.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).