* linux-next: upstream tree build failure
@ 2009-04-23 6:06 Stephen Rothwell
2009-04-23 10:33 ` Josh Boyer
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2009-04-23 6:06 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linuxppc-dev, linux-next, LKML
Hi all,
[I am now using gcc version 4.4.0 ...]
Today's linux-next build (powerpc ppc44x_defconfig) failed like this:
arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression
Previous gcc versions didn't notice this because one of the preceding
#ifs always evaluated to true. I have applied the following patch for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 23 Apr 2009 16:00:47 +1000
Subject: [PATCH] powerpc: fix for long standing bug noticed by gcc 4.4.0
Previous gcc versions didn't notice this because one of the preceding
gcc 4.4.0 produced this error:
arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/mm/tlb_nohash_low.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/mm/tlb_nohash_low.S b/arch/powerpc/mm/tlb_nohash_low.S
index 45fed36..21e1b9a 100644
--- a/arch/powerpc/mm/tlb_nohash_low.S
+++ b/arch/powerpc/mm/tlb_nohash_low.S
@@ -203,6 +203,6 @@ ALT_MMU_FTR_SECTION_END_IFCLR(MMU_FTR_USE_TLBILX)
isync
1: wrtee r10
blr
-#elif
+#else
#error Unsupported processor type !
#endif
--
1.6.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: linux-next: upstream tree build failure
2009-04-23 6:06 linux-next: upstream tree build failure Stephen Rothwell
@ 2009-04-23 10:33 ` Josh Boyer
2009-04-23 12:56 ` [PATCH v2] powerpc: fix for long standing bug noticed by gcc 4.4.0 Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Josh Boyer @ 2009-04-23 10:33 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev, linux-next, LKML
On Thu, Apr 23, 2009 at 04:06:56PM +1000, Stephen Rothwell wrote:
>Hi all,
>
>[I am now using gcc version 4.4.0 ...]
>
>Today's linux-next build (powerpc ppc44x_defconfig) failed like this:
>
>arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression
>
>Previous gcc versions didn't notice this because one of the preceding
>#ifs always evaluated to true. I have applied the following patch for today.
>
>--
>Cheers,
>Stephen Rothwell sfr@canb.auug.org.au
>http://www.canb.auug.org.au/~sfr/
>
>From: Stephen Rothwell <sfr@canb.auug.org.au>
>Date: Thu, 23 Apr 2009 16:00:47 +1000
>Subject: [PATCH] powerpc: fix for long standing bug noticed by gcc 4.4.0
>
>Previous gcc versions didn't notice this because one of the preceding
>
>gcc 4.4.0 produced this error:
>
>arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression
>
>Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Your changelog got truncated in the first sentence. No big deal.
I have a gcc 4.4.0 system as well. I'll try a bunch of various builds to see
if it catches anything else. This fix looks good to me in the meantime.
Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
josh
>---
> arch/powerpc/mm/tlb_nohash_low.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/arch/powerpc/mm/tlb_nohash_low.S b/arch/powerpc/mm/tlb_nohash_low.S
>index 45fed36..21e1b9a 100644
>--- a/arch/powerpc/mm/tlb_nohash_low.S
>+++ b/arch/powerpc/mm/tlb_nohash_low.S
>@@ -203,6 +203,6 @@ ALT_MMU_FTR_SECTION_END_IFCLR(MMU_FTR_USE_TLBILX)
> isync
> 1: wrtee r10
> blr
>-#elif
>+#else
> #error Unsupported processor type !
> #endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] powerpc: fix for long standing bug noticed by gcc 4.4.0
2009-04-23 10:33 ` Josh Boyer
@ 2009-04-23 12:56 ` Stephen Rothwell
2009-04-23 13:55 ` Kumar Gala
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2009-04-23 12:56 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras
Cc: Josh Boyer, linuxppc-dev, linux-next, LKML
Previous gcc versions didn't notice this because one of the preceding
#ifs always evaluated to true.
gcc 4.4.0 produced this error:
arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
---
arch/powerpc/mm/tlb_nohash_low.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
v2: fixed up commit message, added Josh'd Ack.
diff --git a/arch/powerpc/mm/tlb_nohash_low.S b/arch/powerpc/mm/tlb_nohash_low.S
index 45fed36..21e1b9a 100644
--- a/arch/powerpc/mm/tlb_nohash_low.S
+++ b/arch/powerpc/mm/tlb_nohash_low.S
@@ -203,6 +203,6 @@ ALT_MMU_FTR_SECTION_END_IFCLR(MMU_FTR_USE_TLBILX)
isync
1: wrtee r10
blr
-#elif
+#else
#error Unsupported processor type !
#endif
--
1.6.2.3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] powerpc: fix for long standing bug noticed by gcc 4.4.0
2009-04-23 12:56 ` [PATCH v2] powerpc: fix for long standing bug noticed by gcc 4.4.0 Stephen Rothwell
@ 2009-04-23 13:55 ` Kumar Gala
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2009-04-23 13:55 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Benjamin Herrenschmidt, Paul Mackerras, Josh Boyer, linuxppc-dev,
linux-next, LKML
On Apr 23, 2009, at 7:56 AM, Stephen Rothwell wrote:
> Previous gcc versions didn't notice this because one of the preceding
> #ifs always evaluated to true.
>
> gcc 4.4.0 produced this error:
>
> arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no
> expression
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
> ---
> arch/powerpc/mm/tlb_nohash_low.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> v2: fixed up commit message, added Josh'd Ack.
applied to merge. Picking this up as I'm touching tlb_nohash_low.S w/
another "fix".
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-23 13:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-23 6:06 linux-next: upstream tree build failure Stephen Rothwell
2009-04-23 10:33 ` Josh Boyer
2009-04-23 12:56 ` [PATCH v2] powerpc: fix for long standing bug noticed by gcc 4.4.0 Stephen Rothwell
2009-04-23 13:55 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).