linux-next: voltage tree build failure

linux-next: voltage tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hi Liam,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/regulator/userspace-consumer.c:43: error: conflicting types for 'show_state'
include/linux/sched.h:273: note: previous definition of 'show_state' was here

Caused by commit 5defa2bce704ca4151cfe24e4297aa7797cafd22 ("regulator:
add userspace-consumer driver") which I have reverted for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: voltage tree build failure

[Liam Girdwood]

On Tue, 2009-04-28 at 16:24 +1000, Stephen Rothwell wrote:
> Hi Liam,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> drivers/regulator/userspace-consumer.c:43: error: conflicting types for 'show_state'
> include/linux/sched.h:273: note: previous definition of 'show_state' was here
> 
> Caused by commit 5defa2bce704ca4151cfe24e4297aa7797cafd22 ("regulator:
> add userspace-consumer driver") which I have reverted for today.

Sorry about this. I've now fixed in voltage next by renaming with a reg_
prefix. Fwiw - I did test build for ARM and all was OK yesterday. I
guess I need to build allyesconfig too.

Thanks

Liam 

Re: linux-next: voltage tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Hi Liam,

On Tue, 28 Apr 2009 12:08:37 +0100 Liam Girdwood <lrg@slimlogic.co.uk> wrote:
>
> On Tue, 2009-04-28 at 16:24 +1000, Stephen Rothwell wrote:
> > Hi Liam,
> > 
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> > 
> > drivers/regulator/userspace-consumer.c:43: error: conflicting types for 'show_state'
> > include/linux/sched.h:273: note: previous definition of 'show_state' was here
> > 
> > Caused by commit 5defa2bce704ca4151cfe24e4297aa7797cafd22 ("regulator:
> > add userspace-consumer driver") which I have reverted for today.
> 
> Sorry about this. I've now fixed in voltage next by renaming with a reg_
> prefix. Fwiw - I did test build for ARM and all was OK yesterday. I
> guess I need to build allyesconfig too.

More likely, sched.h is indirectly included on some platforms and not
others.  This is partly what linux-next is for: to find cross platform
and subsystem interactions.

Thanks for the fix.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: voltage tree build failure

[Mike Rapoport]

Stephen Rothwell wrote:
> Hi Liam,
> 
> On Tue, 28 Apr 2009 12:08:37 +0100 Liam Girdwood <lrg@slimlogic.co.uk> wrote:
>> On Tue, 2009-04-28 at 16:24 +1000, Stephen Rothwell wrote:
>>> Hi Liam,
>>>
>>> Today's linux-next build (powerpc allyesconfig) failed like this:
>>>
>>> drivers/regulator/userspace-consumer.c:43: error: conflicting types for 'show_state'
>>> include/linux/sched.h:273: note: previous definition of 'show_state' was here
>>>
>>> Caused by commit 5defa2bce704ca4151cfe24e4297aa7797cafd22 ("regulator:
>>> add userspace-consumer driver") which I have reverted for today.
>> Sorry about this. I've now fixed in voltage next by renaming with a reg_
>> prefix. Fwiw - I did test build for ARM and all was OK yesterday. I
>> guess I need to build allyesconfig too.

It's rather my fault...
BTW, the drivers/regulator/virtual.c has show_mode which may trigger similar
error later, probably it's worth adding reg_ prefix there as well...

> More likely, sched.h is indirectly included on some platforms and not
> others.  This is partly what linux-next is for: to find cross platform
> and subsystem interactions.
> 
> Thanks for the fix.

-- 
Sincerely yours,
Mike.

linux-next: voltage tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

Hi Liam,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/built-in.o: In function `pm8607_write_device':
88pm8607.c:(.text+0xd1359): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `pm8607_read_device':
88pm8607.c:(.text+0xd13ab): undefined reference to `i2c_master_send'
88pm8607.c:(.text+0xd13cc): undefined reference to `i2c_master_recv'
drivers/built-in.o: In function `pm8607_init':
88pm8607.c:(.init.text+0xaa22): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `pm8607_probe':
88pm8607.c:(.devinit.text+0x50fb): undefined reference to `mfd_add_devices'
drivers/built-in.o: In function `pm8607_exit':
88pm8607.c:(.exit.text+0x5de): undefined reference to `i2c_del_driver'
drivers/built-in.o: In function `pm8607_remove':
88pm8607.c:(.devexit.text+0x1cc): undefined reference to `mfd_remove_devices'

Caused by commit 258e3427f83a573d738344c2f5499da5e026e1df ("regulator:
add 88PM8607 PMIC driver").  This is the same driver that has caused the
mfd tree to fail in the same way since next-20091006.  I have used the
version of the voltage tree from next-20091009 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: voltage tree build failure

[Haojian Zhuang]

On Sun, Oct 11, 2009 at 10:26 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Liam,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/built-in.o: In function `pm8607_write_device':
> 88pm8607.c:(.text+0xd1359): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `pm8607_read_device':
> 88pm8607.c:(.text+0xd13ab): undefined reference to `i2c_master_send'
> 88pm8607.c:(.text+0xd13cc): undefined reference to `i2c_master_recv'
> drivers/built-in.o: In function `pm8607_init':
> 88pm8607.c:(.init.text+0xaa22): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `pm8607_probe':
> 88pm8607.c:(.devinit.text+0x50fb): undefined reference to `mfd_add_devices'
> drivers/built-in.o: In function `pm8607_exit':
> 88pm8607.c:(.exit.text+0x5de): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `pm8607_remove':
> 88pm8607.c:(.devexit.text+0x1cc): undefined reference to `mfd_remove_devices'
>
> Caused by commit 258e3427f83a573d738344c2f5499da5e026e1df ("regulator:
> add 88PM8607 PMIC driver").  This is the same driver that has caused the
> mfd tree to fail in the same way since next-20091006.  I have used the
> version of the voltage tree from next-20091009 for today.
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

Hi Samuel & Liam,

Please help review and merge this fix patch. I'm sorry for inconvience.

Stephen,

Thanks for your check.

From b7d3707263598c4c6671ac592eaaf13535a7b96a Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <haojian.zhuang@marvell.com>
Date: Tue, 6 Oct 2009 08:08:37 -0400
Subject: [PATCH] mfd: fix the dependancy issue on 88PM8607

88PM8607 depends on I2C and MFD_CORE. Since 88PM8607 is built-in
kernel, it also requires that I2C and MFD_CORE are built-in
kernel also.

Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
---
 drivers/mfd/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index fbe684b..00064e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -307,7 +307,7 @@ config EZX_PCAP

 config MFD_88PM8607
 	bool "Support Marvell 88PM8607"
-	depends on I2C
+	depends on I2C=y
 	select MFD_CORE
 	help
 	  This supports for Marvell 88PM8607 Power Management IC. This includes
-- 
1.5.6.5


Best Regards
Haojian

Re: linux-next: voltage tree build failure

[Mark Brown]

On Sun, Oct 11, 2009 at 10:50:54PM -0400, Haojian Zhuang wrote:

> Hi Samuel & Liam,

> Please help review and merge this fix patch. I'm sorry for inconvience.

This is waiting for Samuel - it should go via the MFD tree.  I've CCed
in Samuel's current e-mail address on the off-chance that that helps.

Re: linux-next: voltage tree build failure

[Samuel Ortiz]

On Mon, Oct 12, 2009 at 01:57:07PM +0100, Mark Brown wrote:
> On Sun, Oct 11, 2009 at 10:50:54PM -0400, Haojian Zhuang wrote:
> 
> > Hi Samuel & Liam,
> 
> > Please help review and merge this fix patch. I'm sorry for inconvience.
> 
> This is waiting for Samuel - it should go via the MFD tree.  I've CCed
> in Samuel's current e-mail address on the off-chance that that helps.
Patch applied and pushed. Sorry for the delay, I wasnt cc'ed at first.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

linux-next: voltage tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Hi Liam,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/regulator/tps65023-regulator: struct i2c_device_id is 32 bytes.  The last of 1 is:
0x74 0x70 0x73 0x36 0x35 0x30 0x32 0x33 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
FATAL: drivers/regulator/tps65023-regulator: struct i2c_device_id is not terminated with a NULL entry!

Caused by commit 9cfd343f14bf4bd95f8bfc6a1d411d2002bf94d8 ("Regulator:
Add TPS65023 regulator driver").

I have used the version of the voltage tree from next-20090821 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: voltage tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hi Liam,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/regulator/wm8350-regulator.c: In function 'pmic_uv_handler':
drivers/regulator/wm8350-regulator.c:1296: error: dereferencing pointer to incomplete type
drivers/regulator/wm8350-regulator.c:1305: error: dereferencing pointer to incomplete type

Immediate cause is commit 872ed3fe176833f7d43748eb88010da4bbd2f983
("Regulator: Push lock out of _notifier_call_chain + add voltage change
event").

I have dropped the voltage tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: voltage tree build failure

[Jonathan Cameron]

Stephen Rothwell wrote:
> Hi Liam,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/regulator/wm8350-regulator.c: In function 'pmic_uv_handler':
> drivers/regulator/wm8350-regulator.c:1296: error: dereferencing pointer to incomplete type
> drivers/regulator/wm8350-regulator.c:1305: error: dereferencing pointer to incomplete type
> 
> Immediate cause is commit 872ed3fe176833f7d43748eb88010da4bbd2f983
> ("Regulator: Push lock out of _notifier_call_chain + add voltage change
> event").
> 
> I have dropped the voltage tree for today.
Sorry, my error... It's always the simple changes that you don't build
test properly that catch you out.

Liam, can you revert this patch for now and I'll send a version
that doesn't have this problem shortly.

Jonathan

linux-next: voltage tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi Liam,

Today's linux-next build (arm versatile_defconfig) failed like this:

drivers/regulator/Kconfig:59: can't open file "drivers/regulator/wm8350/Kconfig"

Commit 03ec18c8752a9b12006ffff23a5582b4482073ce ("regulator: TI bq24022
Li-Ion Charger driver") added some includes to drivers/regulator/Kconfig
of things that don't exist ...

Unfortunately, this broke all arm builds.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: voltage tree build failure

[Liam Girdwood]

On Mon, 2008-07-14 at 23:35 +1000, Stephen Rothwell wrote:
> Hi Liam,
> 
> Today's linux-next build (arm versatile_defconfig) failed like this:
> 
> drivers/regulator/Kconfig:59: can't open file "drivers/regulator/wm8350/Kconfig"
> 
> Commit 03ec18c8752a9b12006ffff23a5582b4482073ce ("regulator: TI bq24022
> Li-Ion Charger driver") added some includes to drivers/regulator/Kconfig
> of things that don't exist ...
> 
> Unfortunately, this broke all arm builds.

Philipp noticed earlier and it's now fixed. It's stuff that does exist
on my system so I should probably git clean -f -d next time I build
(before commit).

Thanks

Liam