[PATCH -next] wusb: hwa-hc: Drop unused pci_suspend/resume hooks.

[PATCH -next] wusb: hwa-hc: Drop unused pci_suspend/resume hooks.

[Paul Mundt]

  CC      drivers/usb/host/hwa-hc.o
drivers/usb/host/hwa-hc.c:601: warning: initialization from incompatible pointer type
drivers/usb/host/hwa-hc.c:602: warning: initialization from incompatible pointer type

The prototype for these changed, so the message itself was dropped. As the only
thing these hooks were doing was printing out the message for debugging, there
is not much point in keeping them around. So, just kill them off.

Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: David Vrabel <david.vrabel@csr.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>

---

 drivers/usb/host/hwa-hc.c |   21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/usb/host/hwa-hc.c b/drivers/usb/host/hwa-hc.c
index cbf30e5..88b0321 100644
--- a/drivers/usb/host/hwa-hc.c
+++ b/drivers/usb/host/hwa-hc.c
@@ -172,25 +172,6 @@ error_cluster_id_get:
 
 }
 
-static int hwahc_op_suspend(struct usb_hcd *usb_hcd, pm_message_t msg)
-{
-	struct wusbhc *wusbhc = usb_hcd_to_wusbhc(usb_hcd);
-	struct hwahc *hwahc = container_of(wusbhc, struct hwahc, wusbhc);
-	dev_err(wusbhc->dev, "%s (%p [%p], 0x%lx) UNIMPLEMENTED\n", __func__,
-		usb_hcd, hwahc, *(unsigned long *) &msg);
-	return -ENOSYS;
-}
-
-static int hwahc_op_resume(struct usb_hcd *usb_hcd)
-{
-	struct wusbhc *wusbhc = usb_hcd_to_wusbhc(usb_hcd);
-	struct hwahc *hwahc = container_of(wusbhc, struct hwahc, wusbhc);
-
-	dev_err(wusbhc->dev, "%s (%p [%p]) UNIMPLEMENTED\n", __func__,
-		usb_hcd, hwahc);
-	return -ENOSYS;
-}
-
 /*
  * No need to abort pipes, as when this is called, all the children
  * has been disconnected and that has done it [through
@@ -598,8 +579,6 @@ static struct hc_driver hwahc_hc_driver = {
 	.flags = HCD_USB2,		/* FIXME */
 	.reset = hwahc_op_reset,
 	.start = hwahc_op_start,
-	.pci_suspend = hwahc_op_suspend,
-	.pci_resume = hwahc_op_resume,
 	.stop = hwahc_op_stop,
 	.get_frame_number = hwahc_op_get_frame_number,
 	.urb_enqueue = hwahc_op_urb_enqueue,

Re: [PATCH -next] wusb: hwa-hc: Drop unused pci_suspend/resume hooks.

[David Vrabel]

Paul Mundt wrote:
>   CC      drivers/usb/host/hwa-hc.o
> drivers/usb/host/hwa-hc.c:601: warning: initialization from incompatible pointer type
> drivers/usb/host/hwa-hc.c:602: warning: initialization from incompatible pointer type
> 
> The prototype for these changed, so the message itself was dropped. As the only
> thing these hooks were doing was printing out the message for debugging, there
> is not much point in keeping them around. So, just kill them off.

Acked-by: David Vrabel <david.vrabel@csr.com>

Greg, can you pick this one up, please.

David

Re: [PATCH -next] wusb: hwa-hc: Drop unused pci_suspend/resume hooks.

[Greg KH]

On Thu, Apr 30, 2009 at 09:48:10AM +0100, David Vrabel wrote:
> Paul Mundt wrote:
> >   CC      drivers/usb/host/hwa-hc.o
> > drivers/usb/host/hwa-hc.c:601: warning: initialization from incompatible pointer type
> > drivers/usb/host/hwa-hc.c:602: warning: initialization from incompatible pointer type
> > 
> > The prototype for these changed, so the message itself was dropped. As the only
> > thing these hooks were doing was printing out the message for debugging, there
> > is not much point in keeping them around. So, just kill them off.
> 
> Acked-by: David Vrabel <david.vrabel@csr.com>
> 
> Greg, can you pick this one up, please.

I don't seem to have it in my archive, can you resend it to me with your
ack?

thanks,

greg k-h

Re: [PATCH -next] wusb: hwa-hc: Drop unused pci_suspend/resume hooks.

[Greg KH]

On Thu, Apr 30, 2009 at 08:49:40AM -0700, Greg KH wrote:
> On Thu, Apr 30, 2009 at 09:48:10AM +0100, David Vrabel wrote:
> > Paul Mundt wrote:
> > >   CC      drivers/usb/host/hwa-hc.o
> > > drivers/usb/host/hwa-hc.c:601: warning: initialization from incompatible pointer type
> > > drivers/usb/host/hwa-hc.c:602: warning: initialization from incompatible pointer type
> > > 
> > > The prototype for these changed, so the message itself was dropped. As the only
> > > thing these hooks were doing was printing out the message for debugging, there
> > > is not much point in keeping them around. So, just kill them off.
> > 
> > Acked-by: David Vrabel <david.vrabel@csr.com>
> > 
> > Greg, can you pick this one up, please.
> 
> I don't seem to have it in my archive, can you resend it to me with your
> ack?

Nevermind, I found it...

thanks,

greg k-h