[PATCH] max6875: should depend on I2C

[PATCH] max6875: should depend on I2C

[Alexander Beregalov]

Fix this build error:
drivers/built-in.o: In function `max6875_remove':
max6875.c:(.text+0x6bdda): undefined reference to `i2c_unregister_device'

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
 drivers/misc/eeprom/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
index e23f0ec..9118613 100644
--- a/drivers/misc/eeprom/Kconfig
+++ b/drivers/misc/eeprom/Kconfig
@@ -50,7 +50,7 @@ config EEPROM_LEGACY
 
 config EEPROM_MAX6875
 	tristate "Maxim MAX6874/5 power supply supervisor"
-	depends on EXPERIMENTAL
+	depends on I2C && EXPERIMENTAL
 	help
 	  If you say yes here you get read-only support for the user EEPROM of
 	  the Maxim MAX6874/5 EEPROM-programmable, quad power-supply
-- 
1.6.2.3

Re: [PATCH] max6875: should depend on I2C

[Jean Delvare]

Hi Alexander,

On Mon,  4 May 2009 13:49:46 +0400, Alexander Beregalov wrote:
> Fix this build error:
> drivers/built-in.o: In function `max6875_remove':
> max6875.c:(.text+0x6bdda): undefined reference to `i2c_unregister_device'
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>  drivers/misc/eeprom/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
> index e23f0ec..9118613 100644
> --- a/drivers/misc/eeprom/Kconfig
> +++ b/drivers/misc/eeprom/Kconfig
> @@ -50,7 +50,7 @@ config EEPROM_LEGACY
>  
>  config EEPROM_MAX6875
>  	tristate "Maxim MAX6874/5 power supply supervisor"
> -	depends on EXPERIMENTAL
> +	depends on I2C && EXPERIMENTAL
>  	help
>  	  If you say yes here you get read-only support for the user EEPROM of
>  	  the Maxim MAX6874/5 EEPROM-programmable, quad power-supply

Good catch! I've folded this fix into
i2c/i2c-chips-move-max6875-to-drivers-misc-eeprom.patch, thanks for
reporting.

-- 
Jean Delvare

Re: [PATCH] max6875: should depend on I2C

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

> Good catch! I've folded this fix into
> i2c/i2c-chips-move-max6875-to-drivers-misc-eeprom.patch, thanks for
> reporting.

ACK for the patch.

Haven't noticed that Jean put it into his quilt-stack already. Jean,
could you also add the ACK from Ben Gardner or shall I resend it (with
the minor nit removed?)

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] max6875: should depend on I2C

[Jean Delvare]

Hi Wolfram,

On Mon, 4 May 2009 14:55:56 +0200, Wolfram Sang wrote:
> > Good catch! I've folded this fix into
> > i2c/i2c-chips-move-max6875-to-drivers-misc-eeprom.patch, thanks for
> > reporting.
> 
> ACK for the patch.
> 
> Haven't noticed that Jean put it into his quilt-stack already. Jean,
> could you also add the ACK from Ben Gardner or shall I resend it (with
> the minor nit removed?)

I fixed it all myself, it should be OK now.

-- 
Jean Delvare