From: Jens Axboe <jens.axboe@oracle.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: benh@kernel.crashing.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] viocd: needs to depend on BLOCK
Date: Tue, 12 May 2009 13:28:35 +0200 [thread overview]
Message-ID: <20090512112834.GJ4140@kernel.dk> (raw)
In-Reply-To: <1242123655-4104-1-git-send-email-a.beregalov@gmail.com>
On Tue, May 12 2009, Alexander Beregalov wrote:
> Fix this build error when CONFIG_BLOCK is not set:
> drivers/cdrom/viocd.c: In function 'viocd_blk_open':
> drivers/cdrom/viocd.c:156: error: dereferencing pointer to incomplete type
> drivers/cdrom/viocd.c: In function 'viocd_blk_release':
> drivers/cdrom/viocd.c:162: error: dereferencing pointer to incomplete type
> drivers/cdrom/viocd.c: In function 'viocd_blk_ioctl':
> drivers/cdrom/viocd.c:170: error: dereferencing pointer to incomplete type
> drivers/cdrom/viocd.c: In function 'viocd_blk_media_changed':
> drivers/cdrom/viocd.c:176: error: dereferencing pointer to incomplete type
> ...
Added to 2.6.30 pending fixes.
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
> arch/powerpc/platforms/iseries/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
> index 647e877..47a20cf 100644
> --- a/arch/powerpc/platforms/iseries/Kconfig
> +++ b/arch/powerpc/platforms/iseries/Kconfig
> @@ -17,6 +17,7 @@ config VIODASD
>
> config VIOCD
> tristate "iSeries Virtual I/O CD support"
> + depends on BLOCK
> select VIOPATH
> help
> If you are running Linux on an IBM iSeries system and you want to
> --
> 1.6.3
>
--
Jens Axboe
prev parent reply other threads:[~2009-05-12 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 10:20 [PATCH] viocd: needs to depend on BLOCK Alexander Beregalov
2009-05-12 11:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512112834.GJ4140@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=a.beregalov@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).