linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] viocd: needs to depend on BLOCK
@ 2009-05-12 10:20 Alexander Beregalov
  2009-05-12 11:28 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Beregalov @ 2009-05-12 10:20 UTC (permalink / raw)
  To: benh; +Cc: jens.axboe, linux-next, Alexander Beregalov

Fix this build error when CONFIG_BLOCK is not set:
drivers/cdrom/viocd.c: In function 'viocd_blk_open':
drivers/cdrom/viocd.c:156: error: dereferencing pointer to incomplete type
drivers/cdrom/viocd.c: In function 'viocd_blk_release':
drivers/cdrom/viocd.c:162: error: dereferencing pointer to incomplete type
drivers/cdrom/viocd.c: In function 'viocd_blk_ioctl':
drivers/cdrom/viocd.c:170: error: dereferencing pointer to incomplete type
drivers/cdrom/viocd.c: In function 'viocd_blk_media_changed':
drivers/cdrom/viocd.c:176: error: dereferencing pointer to incomplete type
...

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
 arch/powerpc/platforms/iseries/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
index 647e877..47a20cf 100644
--- a/arch/powerpc/platforms/iseries/Kconfig
+++ b/arch/powerpc/platforms/iseries/Kconfig
@@ -17,6 +17,7 @@ config VIODASD
 
 config VIOCD
 	tristate "iSeries Virtual I/O CD support"
+	depends on BLOCK
 	select VIOPATH
 	help
 	  If you are running Linux on an IBM iSeries system and you want to
-- 
1.6.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] viocd: needs to depend on BLOCK
  2009-05-12 10:20 [PATCH] viocd: needs to depend on BLOCK Alexander Beregalov
@ 2009-05-12 11:28 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2009-05-12 11:28 UTC (permalink / raw)
  To: Alexander Beregalov; +Cc: benh, linux-next

On Tue, May 12 2009, Alexander Beregalov wrote:
> Fix this build error when CONFIG_BLOCK is not set:
> drivers/cdrom/viocd.c: In function 'viocd_blk_open':
> drivers/cdrom/viocd.c:156: error: dereferencing pointer to incomplete type
> drivers/cdrom/viocd.c: In function 'viocd_blk_release':
> drivers/cdrom/viocd.c:162: error: dereferencing pointer to incomplete type
> drivers/cdrom/viocd.c: In function 'viocd_blk_ioctl':
> drivers/cdrom/viocd.c:170: error: dereferencing pointer to incomplete type
> drivers/cdrom/viocd.c: In function 'viocd_blk_media_changed':
> drivers/cdrom/viocd.c:176: error: dereferencing pointer to incomplete type
> ...

Added to 2.6.30 pending fixes.

> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>  arch/powerpc/platforms/iseries/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
> index 647e877..47a20cf 100644
> --- a/arch/powerpc/platforms/iseries/Kconfig
> +++ b/arch/powerpc/platforms/iseries/Kconfig
> @@ -17,6 +17,7 @@ config VIODASD
>  
>  config VIOCD
>  	tristate "iSeries Virtual I/O CD support"
> +	depends on BLOCK
>  	select VIOPATH
>  	help
>  	  If you are running Linux on an IBM iSeries system and you want to
> -- 
> 1.6.3
> 

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-12 11:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-12 10:20 [PATCH] viocd: needs to depend on BLOCK Alexander Beregalov
2009-05-12 11:28 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).