* [PATCH] Staging: comedi: comedidev should include delay.h
@ 2009-05-21 13:06 Alexander Beregalov
2009-05-21 13:09 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Beregalov @ 2009-05-21 13:06 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-next, Alexander Beregalov
Fix many build errors like this:
comedi/drivers/adq12b.c:328: error: implicit declaration of function 'udelay'
The same for aio_aio12_8.c, dmm32at.c and others.
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
drivers/staging/comedi/comedidev.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 7a1ccde..3d0e80c 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -38,6 +38,7 @@
#include <linux/dma-mapping.h>
#include <linux/uaccess.h>
#include <linux/io.h>
+#include <linux/delay.h>
#include "comedi.h"
--
1.6.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: comedidev should include delay.h
2009-05-21 13:06 [PATCH] Staging: comedi: comedidev should include delay.h Alexander Beregalov
@ 2009-05-21 13:09 ` Robert P. J. Day
2009-05-21 13:55 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2009-05-21 13:09 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: gregkh, linux-kernel, linux-next
On Thu, 21 May 2009, Alexander Beregalov wrote:
> Fix many build errors like this:
> comedi/drivers/adq12b.c:328: error: implicit declaration of function 'udelay'
>
> The same for aio_aio12_8.c, dmm32at.c and others.
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 7a1ccde..3d0e80c 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -38,6 +38,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/uaccess.h>
> #include <linux/io.h>
> +#include <linux/delay.h>
>
> #include "comedi.h"
not sure it's worth noting but the header comedidev.h currently
resides in the comedi directory itself, while the source file rt.c
contains:
#include <linux/comedidev.h>
which doesn't seem right. and that local comedidev.h header file
contains the comment:
/*
include/linux/comedidev.h
as if it *were* really under include/linux. perhaps someone would
like to clarify that. just an observation.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: comedidev should include delay.h
2009-05-21 13:09 ` Robert P. J. Day
@ 2009-05-21 13:55 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2009-05-21 13:55 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Alexander Beregalov, linux-kernel, linux-next
On Thu, May 21, 2009 at 09:09:53AM -0400, Robert P. J. Day wrote:
> On Thu, 21 May 2009, Alexander Beregalov wrote:
>
> > Fix many build errors like this:
> > comedi/drivers/adq12b.c:328: error: implicit declaration of function 'udelay'
> >
> > The same for aio_aio12_8.c, dmm32at.c and others.
> >
> > Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> > ---
> > drivers/staging/comedi/comedidev.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> > index 7a1ccde..3d0e80c 100644
> > --- a/drivers/staging/comedi/comedidev.h
> > +++ b/drivers/staging/comedi/comedidev.h
> > @@ -38,6 +38,7 @@
> > #include <linux/dma-mapping.h>
> > #include <linux/uaccess.h>
> > #include <linux/io.h>
> > +#include <linux/delay.h>
> >
> > #include "comedi.h"
>
> not sure it's worth noting but the header comedidev.h currently
> resides in the comedi directory itself, while the source file rt.c
> contains:
>
> #include <linux/comedidev.h>
>
> which doesn't seem right.
That's correct, and is one reason why rt.c is now gone in the linux-next
tree :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-21 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-21 13:06 [PATCH] Staging: comedi: comedidev should include delay.h Alexander Beregalov
2009-05-21 13:09 ` Robert P. J. Day
2009-05-21 13:55 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).