linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: manual merge of the vfs tree with the  tree
Date: Mon, 25 May 2009 19:10:56 +0200	[thread overview]
Message-ID: <20090525171055.GA7879@nowhere> (raw)
In-Reply-To: <20090524220747.GA12433@lst.de>

On Mon, May 25, 2009 at 12:07:47AM +0200, Christoph Hellwig wrote:
> On Mon, May 25, 2009 at 12:03:38AM +0200, Frederic Weisbecker wrote:
> > > + 	if (s->s_dirt)
> > > + 		reiserfs_write_super(s);
> > 
> > 
> > 
> > But this part seems to solve another conflict, right?
> > I'm not sure about it.
> 
> Yes, different one.  Previously the VFS called ->write_super just before
> ->put_super.  Now any left over writeback needs to be dealt with by
> the filesystem.  For now I have added a call to the write_super method
> to all filesystems, but most likely this can be removed later after
> an audit by someone who knows the filesystem.
>

Ok. Thanks for the clarification. So Stephen's fix seems to be
correct.

Thanks.

  reply	other threads:[~2009-05-25 17:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22  1:23 linux-next: manual merge of the vfs tree with the tree Stephen Rothwell
2009-05-24 22:03 ` Frederic Weisbecker
2009-05-24 22:07   ` Christoph Hellwig
2009-05-25 17:10     ` Frederic Weisbecker [this message]
2009-05-25  6:50   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2015-06-05  5:46 mpe@ellerman.id.au
2014-05-29  3:25 Stephen Rothwell
2012-09-24  1:45 Stephen Rothwell
2009-06-09  1:08 Stephen Rothwell
2009-06-09  6:58 ` Miklos Szeredi
2009-06-09  7:27   ` Stephen Rothwell
2009-05-13  2:20 Stephen Rothwell
2009-05-08  4:44 Stephen Rothwell
2009-05-08 13:40 ` Miklos Szeredi
2009-05-08 17:50   ` Al Viro
2009-05-09 16:58     ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090525171055.GA7879@nowhere \
    --to=fweisbec@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).