linux-next: pci tree build warning

linux-next: pci tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

Hi Jesse,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

drivers/gpu/vga/vgaarb.c: In function 'vga_arb_write':
drivers/gpu/vga/vgaarb.c:834: warning: cast from pointer to integer of different size
drivers/gpu/vga/vgaarb.c:870: warning: cast from pointer to integer of different size
drivers/gpu/vga/vgaarb.c:920: warning: cast from pointer to integer of different size
drivers/gpu/vga/vgaarb.c:963: warning: cast from pointer to integer of different size
drivers/gpu/vga/vgaarb.c:1017: warning: cast from pointer to integer of different size

Introduced by commit a49c9c1b728fa8f50816d96a0f135e15a359e448 ("PCI/GPU:
implement VGA arbitration on Linux").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: pci tree build warning

[Benjamin Herrenschmidt]

On Thu, 2009-08-13 at 12:47 +1000, Stephen Rothwell wrote:
> Hi Jesse,
> 
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> 
> drivers/gpu/vga/vgaarb.c: In function 'vga_arb_write':
> drivers/gpu/vga/vgaarb.c:834: warning: cast from pointer to integer of different size
> drivers/gpu/vga/vgaarb.c:870: warning: cast from pointer to integer of different size
> drivers/gpu/vga/vgaarb.c:920: warning: cast from pointer to integer of different size
> drivers/gpu/vga/vgaarb.c:963: warning: cast from pointer to integer of different size
> drivers/gpu/vga/vgaarb.c:1017: warning: cast from pointer to integer of different size
> 
> Introduced by commit a49c9c1b728fa8f50816d96a0f135e15a359e448 ("PCI/GPU:
> implement VGA arbitration on Linux").

Right, somebody weirdly decided to cast pointers to int just to printk
them with %X :-) I hope it wasn't me ... 

Just remove the casts and use %p instead.

Cheers,
Ben.

Re: linux-next: pci tree build warning

[Vignatti Tiago (Nokia-D/Helsinki)]

On Thu, Aug 13, 2009 at 05:32:40AM +0200, Benjamin Herrenschmidt wrote:
> On Thu, 2009-08-13 at 12:47 +1000, Stephen Rothwell wrote:
> > Hi Jesse,
> > 
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > 
> > drivers/gpu/vga/vgaarb.c: In function 'vga_arb_write':
> > drivers/gpu/vga/vgaarb.c:834: warning: cast from pointer to integer of different size
> > drivers/gpu/vga/vgaarb.c:870: warning: cast from pointer to integer of different size
> > drivers/gpu/vga/vgaarb.c:920: warning: cast from pointer to integer of different size
> > drivers/gpu/vga/vgaarb.c:963: warning: cast from pointer to integer of different size
> > drivers/gpu/vga/vgaarb.c:1017: warning: cast from pointer to integer of different size
> > 
> > Introduced by commit a49c9c1b728fa8f50816d96a0f135e15a359e448 ("PCI/GPU:
> > implement VGA arbitration on Linux").
> 
> Right, somebody weirdly decided to cast pointers to int just to printk
> them with %X :-) I hope it wasn't me ... 

Ahhh oops.. looks like someone really newbie trying to play developing kernel
code :p
 
            Tiago

linux-next: pci tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Hi Jesse,

Today's linux-next build (powerpc allnoconfig) produced this warning:

WARNING: drivers/pci/built-in.o(.devinit.text+0x86a): Section mismatch in reference from the function pci_init() to the variable .init.data:pci_dfl_cache_line_size
The function __devinit pci_init() references
a variable __initdata pci_dfl_cache_line_size.
If pci_dfl_cache_line_size is only used by pci_init then
annotate pci_dfl_cache_line_size with a matching annotation.

Introduced by commit b20dd110d21aac94b3f4063cffbcf9718656ce51 ("PCI:
determine CLS more intelligently").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: pci tree build warning

[Yinghai Lu]

Stephen Rothwell wrote:
> Hi Jesse,
> 
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> 
> drivers/pci/probe.c: In function '__pci_read_base':
> drivers/pci/probe.c:196: warning: large integer implicitly truncated to unsigned type
> 
> Probably introduced by commit 82160fd142cdf6956a677120426bf5baefcc7cf9
> ("PCI/x86: don't assume prefetchable ranges are 64bit").
> 

--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -193,7 +193,7 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type,
                res->flags |= pci_calc_resource_flags(l) | IORESOURCE_SIZEALIGN;
                if (type == pci_bar_io) {
                        l &= PCI_BASE_ADDRESS_IO_MASK;
-                       mask = PCI_BASE_ADDRESS_IO_MASK & 0xffff;
+                       mask = PCI_BASE_ADDRESS_IO_MASK & IO_SPACE_LIMIT;


and

for x86:
#define IO_SPACE_LIMIT 0xffff

for powerpc
arch/powerpc/include/asm/io.h:#define IO_SPACE_LIMIT ~(0UL)

maybe we need to change back that line...

YH

linux-next: pci tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi Jesse,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

drivers/pci/probe.c: In function '__pci_read_base':
drivers/pci/probe.c:196: warning: large integer implicitly truncated to unsigned type

Probably introduced by commit 82160fd142cdf6956a677120426bf5baefcc7cf9
("PCI/x86: don't assume prefetchable ranges are 64bit").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: pci tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Hi Jesse,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

drivers/pci/setup-bus.c: In function 'pci_bus_assign_resources':
drivers/pci/setup-bus.c:503: warning: passing argument 1 of 'pbus_assign_resources_sorted' discards qualifiers from pointer target type

Caused by commit 1454fec9f61d92514bf3300f8ae99ba7749ccd0c ("PCI: constify
pci_bus_assign_resources()").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]