* linux-next: async_tx tree build failure
@ 2009-09-07 3:08 Stephen Rothwell
2009-09-09 1:35 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2009-09-07 3:08 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-next, linux-kernel, Maciej Sosnowski
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
Hi Dan,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/dma/ioat/dma_v2.c: In function 'ioat2_enumerate_channels':
drivers/dma/ioat/dma_v2.c:346: error: too few arguments to function 'i7300_idle_platform_probe'
Caused by commit feed1bce2e6dc7e3307f122ac95be6741840bee8 ("ioat2,3:
convert to a true ring buffer").
I have used the version of the async_tc tree from next-20090904 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: async_tx tree build failure
2009-09-07 3:08 linux-next: async_tx tree build failure Stephen Rothwell
@ 2009-09-09 1:35 ` Dan Williams
2009-09-09 1:41 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Dan Williams @ 2009-09-09 1:35 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Maciej Sosnowski
On Sun, Sep 6, 2009 at 8:08 PM, Stephen Rothwell<sfr@canb.auug.org.au> wrote:
> Hi Dan,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/dma/ioat/dma_v2.c: In function 'ioat2_enumerate_channels':
> drivers/dma/ioat/dma_v2.c:346: error: too few arguments to function 'i7300_idle_platform_probe'
>
> Caused by commit feed1bce2e6dc7e3307f122ac95be6741840bee8 ("ioat2,3:
> convert to a true ring buffer").
>
> I have used the version of the async_tc tree from next-20090904 for today.
Thanks for the report, I have pushed out a fix for this and some other
fallout from adding CONFIG_I7300_IDLE=y to my build tests.
Regards,
Dan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: async_tx tree build failure
2009-09-09 1:35 ` Dan Williams
@ 2009-09-09 1:41 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2009-09-09 1:41 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-next, linux-kernel, Maciej Sosnowski
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
Hi Dan,
On Tue, 8 Sep 2009 18:35:12 -0700 Dan Williams <dan.j.williams@intel.com> wrote:
>
> Thanks for the report, I have pushed out a fix for this and some other
> fallout from adding CONFIG_I7300_IDLE=y to my build tests.
Thanks, I will include that update today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: async_tx tree build failure
@ 2009-07-23 2:00 Stephen Rothwell
2009-07-23 4:33 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2009-07-23 2:00 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
Hi Dan,
Since next-20090623, the linux-next build (i386 allmodconfig) has failed
like this:
crypto/async_tx/async_xor.c: In function ‘async_xor_init’:
crypto/async_tx/async_xor.c:310: error: size of array ‘type name’ is negative
The failing line is this:
BUILD_BUG_ON(sizeof(dma_addr_t) > sizeof(struct page *));
in async_xor_init() introduced by commit
0036731c88fdb5bf4f04a796a30b5e445fc57f54 ("async_tx: kill tx_set_src and
tx_set_dest methods") in Feb, 2008.
Bisecting in the next-20090623 tree pointed to commit
3c30a9ca1fb95214e60e3bf43957971df6668033 ("dmaengine: move HIGHMEM64G
restriction to ASYNC_TX_DMA") from the async_tx tree. This is now commit
f3c56e57f66a73a241299dbec1ad55491aa0e403.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: async_tx tree build failure
2009-07-23 2:00 Stephen Rothwell
@ 2009-07-23 4:33 ` Dan Williams
2009-07-23 5:17 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Dan Williams @ 2009-07-23 4:33 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
On Wed, 2009-07-22 at 19:00 -0700, Stephen Rothwell wrote:
> Hi Dan,
>
> Since next-20090623, the linux-next build (i386 allmodconfig) has failed
> like this:
>
> crypto/async_tx/async_xor.c: In function ‘async_xor_init’:
> crypto/async_tx/async_xor.c:310: error: size of array ‘type name’ is negative
>
> The failing line is this:
>
> BUILD_BUG_ON(sizeof(dma_addr_t) > sizeof(struct page *));
>
> in async_xor_init() introduced by commit
> 0036731c88fdb5bf4f04a796a30b5e445fc57f54 ("async_tx: kill tx_set_src and
> tx_set_dest methods") in Feb, 2008.
>
> Bisecting in the next-20090623 tree pointed to commit
> 3c30a9ca1fb95214e60e3bf43957971df6668033 ("dmaengine: move HIGHMEM64G
> restriction to ASYNC_TX_DMA") from the async_tx tree. This is now commit
> f3c56e57f66a73a241299dbec1ad55491aa0e403.
Gah, yes that commit was half baked. I have pushed out an updated tree
with the following fix:
diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c
index 95fe2c8..90dd3f8 100644
--- a/crypto/async_tx/async_xor.c
+++ b/crypto/async_tx/async_xor.c
@@ -300,7 +300,7 @@ EXPORT_SYMBOL_GPL(async_xor_zero_sum);
static int __init async_xor_init(void)
{
- #ifdef CONFIG_DMA_ENGINE
+ #ifdef CONFIG_ASYNC_TX_DMA
/* To conserve stack space the input src_list (array of page pointers)
* is reused to hold the array of dma addresses passed to the driver.
* This conversion is only possible when dma_addr_t is less than the
Thanks,
Dan
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-09-09 1:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-07 3:08 linux-next: async_tx tree build failure Stephen Rothwell
2009-09-09 1:35 ` Dan Williams
2009-09-09 1:41 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-07-23 2:00 Stephen Rothwell
2009-07-23 4:33 ` Dan Williams
2009-07-23 5:17 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).