From: Frederic Weisbecker <fweisbec@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Also export the weak version of perf_arch_fetch_caller_regs
Date: Sun, 14 Mar 2010 10:23:44 +0100 [thread overview]
Message-ID: <20100314092341.GA5158@nowhere> (raw)
In-Reply-To: <20100312172043.aa034ede.sfr@canb.auug.org.au>
On Fri, Mar 12, 2010 at 05:20:43PM +1100, Stephen Rothwell wrote:
> Hi Frederic,
>
> On Fri, 12 Mar 2010 06:50:44 +0100 Frederic Weisbecker <fweisbec@gmail.com> wrote:
> >
> > Does that fixes the issue? Sorry I can not test for now...
>
> I can't test it right now, sorry, but I have heard that EXPORT_SYMBOL's
> for weak symbols must be in a different file from the actual symbol
> definition.
Hmm. Ok, kernel/trace/trace_event_perf.c must be the right place then,
as the only users of this helper are trace events.
Will send a fix once I get this tested, thanks for the pointer!
prev parent reply other threads:[~2010-03-14 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 4:00 linux-next: build failure after merge of the tip tree Stephen Rothwell
2010-03-12 5:50 ` [PATCH] perf: Also export the weak version of perf_arch_fetch_caller_regs Frederic Weisbecker
2010-03-12 6:20 ` Stephen Rothwell
2010-03-12 6:26 ` Stephen Rothwell
2010-03-15 21:00 ` [PATCH] perf: Fix unexported generic perf_arch_fetch_caller_regs Frederic Weisbecker
2010-03-15 22:17 ` [PATCH v2] " Frederic Weisbecker
2010-03-15 22:33 ` Stephen Rothwell
2010-03-15 23:54 ` Frederic Weisbecker
2010-03-16 0:05 ` [PATCH v3] " Frederic Weisbecker
2010-03-14 9:23 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100314092341.GA5158@nowhere \
--to=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).