linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	" H . Peter Anvin " <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux Next <linux-next@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v2] perf: Fix unexported generic perf_arch_fetch_caller_regs
Date: Tue, 16 Mar 2010 00:54:52 +0100	[thread overview]
Message-ID: <20100315235450.GB8849@nowhere> (raw)
In-Reply-To: <20100316093355.071fde51.sfr@canb.auug.org.au>

On Tue, Mar 16, 2010 at 09:33:55AM +1100, Stephen Rothwell wrote:
> Hi Frederic,
> 
> On Mon, 15 Mar 2010 23:17:22 +0100 Frederic Weisbecker <fweisbec@gmail.com> wrote:
> >
> > perf_arch_fetch_caller_regs() is exported for the overriden x86
> > version, but not for the generic weak version.
> > As a general rule, weak functions should have their symbol exported
>                                           ^
> "not"


Ooh, right.


 
> > in the same file they are defined.
> > 
> > So let's export it on trace_event_perf.c as it is used by trace
> > events only.
> 
> Otherwise, looks good (though I haven't tested it).



I've tested with some trace event built as module and it looks
fine so far.

Thanks.

  reply	other threads:[~2010-03-15 23:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-12  4:00 linux-next: build failure after merge of the tip tree Stephen Rothwell
2010-03-12  5:50 ` [PATCH] perf: Also export the weak version of perf_arch_fetch_caller_regs Frederic Weisbecker
2010-03-12  6:20   ` Stephen Rothwell
2010-03-12  6:26     ` Stephen Rothwell
2010-03-15 21:00       ` [PATCH] perf: Fix unexported generic perf_arch_fetch_caller_regs Frederic Weisbecker
2010-03-15 22:17         ` [PATCH v2] " Frederic Weisbecker
2010-03-15 22:33           ` Stephen Rothwell
2010-03-15 23:54             ` Frederic Weisbecker [this message]
2010-03-16  0:05             ` [PATCH v3] " Frederic Weisbecker
2010-03-14  9:23     ` [PATCH] perf: Also export the weak version of perf_arch_fetch_caller_regs Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315235450.GB8849@nowhere \
    --to=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).