linux-next: build failure after merge of the fuse tree

linux-next: build failure after merge of the fuse tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

Hi Miklos,

After merging the fuse tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: "generic_pipe_buf_map" [fs/fuse/fuse.ko] undefined!
ERROR: "generic_pipe_buf_confirm" [fs/fuse/fuse.ko] undefined!
ERROR: "generic_pipe_buf_get" [fs/fuse/fuse.ko] undefined!
ERROR: "generic_pipe_buf_unmap" [fs/fuse/fuse.ko] undefined!
ERROR: "generic_pipe_buf_release" [fs/fuse/fuse.ko] undefined!

Caused by commit c3021629a0d820247ee12b6c5192a1d5380e21c6 ("fuse: support
splice() reading from fuse device").

I have used the version of the fuse tree from next-20100525 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the fuse tree

[Miklos Szeredi]

Hi Stephen,

On Wed, 26 May 2010, Stephen Rothwell wrote:
> After merging the fuse tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> ERROR: "generic_pipe_buf_map" [fs/fuse/fuse.ko] undefined!
> ERROR: "generic_pipe_buf_confirm" [fs/fuse/fuse.ko] undefined!
> ERROR: "generic_pipe_buf_get" [fs/fuse/fuse.ko] undefined!
> ERROR: "generic_pipe_buf_unmap" [fs/fuse/fuse.ko] undefined!
> ERROR: "generic_pipe_buf_release" [fs/fuse/fuse.ko] undefined!
> 
> Caused by commit c3021629a0d820247ee12b6c5192a1d5380e21c6 ("fuse: support
> splice() reading from fuse device").

Oops, missed one patch, and forgot to test with modular kernel.  It's
now fixed in the for-next branch.

Thanks for letting me know.

Miklos

Re: linux-next: build failure after merge of the fuse tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Hi Miklos,

On Wed, 26 May 2010 08:46:46 +0200 Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> Oops, missed one patch, and forgot to test with modular kernel.  It's
> now fixed in the for-next branch.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the fuse tree

[Miklos Szeredi]

On Thu, 13 Oct 2022 at 01:15, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the fuse tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: modpost: ".delete_from_page_cache" [fs/fuse/fuse.ko] undefined!
>
> Caused by commit
>
>   0d659ac83481 ("fuse: fix readdir cache race")
>
> delete_from_page_cache has not been exported to modules since commit
>
>   452e9e6992fe ("filemap: Add filemap_remove_folio and __filemap_remove_folio")
>
> Which was merged into Linus tree in v5.17-rc1.
>
> I have used the fuse tree from next-20221012 for today.
>
> Is this really destined for v6.1?

This particular patch, yes.   I posted the patch and asked Willy about
delete_from_page_cache().

Rebased my for-next branch on HEAD and re-added the EXPORT_SYMBOL to
fix this for now.

Thanks,
Miklos

linux-next: build failure after merge of the fuse tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

Hi all,

After merging the fuse tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: ".delete_from_page_cache" [fs/fuse/fuse.ko] undefined!

Caused by commit

  0d659ac83481 ("fuse: fix readdir cache race")

delete_from_page_cache has not been exported to modules since commit

  452e9e6992fe ("filemap: Add filemap_remove_folio and __filemap_remove_folio")

Which was merged into Linus tree in v5.17-rc1.

I have used the fuse tree from next-20221012 for today.

Is this really destined for v6.1?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the fuse tree

[Stephen Rothwell]

Hi Miklos,

After merging the fuse tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/btrfs/file.c: In function 'btrfs_sync_file':
fs/btrfs/file.c:2043:9: error: implicit declaration of function 'btrfs_inode_check_errors' [-Werror=implicit-function-declaration]
   ret = btrfs_inode_check_errors(inode);
         ^

Caused by commit

  7b9885f4acb2 ("mm: export filemap_check_errors() to modules")

interacting with commit

  52c7064bb62a ("Btrfs: add missing check for writeback errors on fsync")

from the btrfs-kdave tree.

I applied the following merge fix patch and can carry it as necessary.
Someone needs to let Linus know about this when he meregs these trees.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 22 Jul 2016 10:57:27 +1000
Subject: [PATCH] btrfs: merge fix for "mm: export filemap_check_errors() to
 modules"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/btrfs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 5842423f8f47..6c8b98cfee09 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -2040,7 +2040,7 @@ int btrfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
 		 * flags for any errors that might have happened while doing
 		 * writeback of file data.
 		 */
-		ret = btrfs_inode_check_errors(inode);
+		ret = filemap_check_errors(inode->i_mapping);
 		inode_unlock(inode);
 		goto out;
 	}
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell