linux-next: build warning after merge of the kvm tree

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
arch/x86/kvm/mmu.c:2908: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'

Introduced by commit af8720393c71a8f81ade71c404798d80c68c5d73 ("KVM: MMU:
add missing reserved bits check in speculative path").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

[PATCH] KVM: fix compile warning

[Xiao Guangrong]

Stephen Rothwell wrote:
> Hi all,
> 
> After merging the kvm tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
> arch/x86/kvm/mmu.c:2908: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
> 
> Introduced by commit af8720393c71a8f81ade71c404798d80c68c5d73 ("KVM: MMU:
> add missing reserved bits check in speculative path").

Hi Stephen,

Thanks for your report, this patch can fix it.

Subject: [PATCH] KVM: fix compile warning

Fix:
arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
arch/x86/kvm/mmu.c:2908: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
 arch/x86/kvm/mmu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 1a8f43f..0dcc95e 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -2904,8 +2904,8 @@ void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa,
 			entry = *spte;
 			mmu_pte_write_zap_pte(vcpu, sp, spte);
 			if (gentry &&
-			      !(sp->role.word ^ vcpu->arch.mmu.base_role.word)
-			      & mask.word)
+			      !((sp->role.word ^ vcpu->arch.mmu.base_role.word)
+			      & mask.word))
 				mmu_pte_write_new_pte(vcpu, sp, spte, &gentry);
 			if (!remote_flush && need_remote_flush(entry, *spte))
 				remote_flush = true;
-- 
1.6.5.2

Re: [PATCH] KVM: fix compile warning

[Marcelo Tosatti]

On Mon, Jul 26, 2010 at 01:47:23PM +0800, Xiao Guangrong wrote:
> 
> Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the kvm tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
> > arch/x86/kvm/mmu.c:2908: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
> > 
> > Introduced by commit af8720393c71a8f81ade71c404798d80c68c5d73 ("KVM: MMU:
> > add missing reserved bits check in speculative path").
> 
> Hi Stephen,
> 
> Thanks for your report, this patch can fix it.
> 
> Subject: [PATCH] KVM: fix compile warning
> 
> Fix:
> arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
> arch/x86/kvm/mmu.c:2908: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
>  arch/x86/kvm/mmu.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Re: linux-next: build warning after merge of the kvm tree

[Paolo Bonzini]

On 11/14/23 04:13, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the kvm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/filesystems/api-summary:74: fs/anon_inodes.c:167: ERROR: Unexpected indentation.
> Documentation/filesystems/api-summary:74: fs/anon_inodes.c:168: WARNING: Block quote ends without a blank line; unexpected unindent.

This reproduces with the version of sphinx in
Documentation/sphinx/requirements.txt.  The fix is
simply this, for which I will send a patch:

diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index e02f4e2e2ece..0496cb5b6eab 100644
--- a/fs/anon_inodes.c
+++ b/fs/anon_inodes.c
@@ -163,8 +163,10 @@ EXPORT_SYMBOL_GPL(anon_inode_getfile);
   *
   * Create a new anonymous inode and file pair.  This can be done for two
   * reasons:
+ *
   * - for the inode to have its own security context, so that LSMs can enforce
   *   policy on the inode's creation;
+ *
   * - if the caller needs a unique inode, for example in order to customize
   *   the size returned by fstat()
   *
@@ -250,8 +252,10 @@ EXPORT_SYMBOL_GPL(anon_inode_getfd);
   *
   * Create a new anonymous inode and file pair.  This can be done for two
   * reasons:
+ *
   * - for the inode to have its own security context, so that LSMs can enforce
   *   policy on the inode's creation;
+ *
   * - if the caller needs a unique inode, for example in order to customize
   *   the size returned by fstat()
   *

Paolo

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/filesystems/api-summary:74: fs/anon_inodes.c:167: ERROR: Unexpected indentation.
Documentation/filesystems/api-summary:74: fs/anon_inodes.c:168: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  e4c866e72563 ("fs: Rename anon_inode_getfile_secure() and anon_inode_getfd_secure()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the kvm tree

[Sean Christopherson]

On Tue, Dec 13, 2022, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the kvm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/virt/kvm/api.rst:7260: ERROR: Unexpected indentation.
> Documentation/virt/kvm/api.rst:7261: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Introduced by commit
> 
>   1f158147181b ("KVM: x86: Clean up KVM_CAP_X86_USER_SPACE_MSR documentation")

On it, should hit next soon.  Thanks!

https://lore.kernel.org/all/20221207000959.2035098-1-seanjc@google.com

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/virt/kvm/api.rst:7260: ERROR: Unexpected indentation.
Documentation/virt/kvm/api.rst:7261: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  1f158147181b ("KVM: x86: Clean up KVM_CAP_X86_USER_SPACE_MSR documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Hi all,

On Mon, 27 Jun 2022 18:19:37 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the kvm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/virt/kvm/api.rst:8210: WARNING: Title underline too short.
> 
> 8.38 KVM_CAP_VM_DISABLE_NX_HUGE_PAGES
> ---------------------------
> Documentation/virt/kvm/api.rst:8217: WARNING: Unexpected indentation.
> 
> Introduced by commit
> 
>   084cc29f8bbb ("KVM: x86/MMU: Allow NX huge pages to be disabled on a per-vm basis")

I am still seeing these warnings.  That commit is now in Linus' tree :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the kvm tree

[Bagas Sanjaya]

On Mon, Jun 27, 2022 at 06:19:37PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the kvm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/virt/kvm/api.rst:8210: WARNING: Title underline too short.
> 
> 8.38 KVM_CAP_VM_DISABLE_NX_HUGE_PAGES
> ---------------------------
> Documentation/virt/kvm/api.rst:8217: WARNING: Unexpected indentation.
> 
> Introduced by commit
> 
>   084cc29f8bbb ("KVM: x86/MMU: Allow NX huge pages to be disabled on a per-vm basis")
> 

Hi Stephen and Paolo,

I have sent the fixes at [1], please test.

[1] https://lore.kernel.org/linux-doc/20220627095151.19339-1-bagasdotme@gmail.com/

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/virt/kvm/api.rst:8210: WARNING: Title underline too short.

8.38 KVM_CAP_VM_DISABLE_NX_HUGE_PAGES
---------------------------
Documentation/virt/kvm/api.rst:8217: WARNING: Unexpected indentation.

Introduced by commit

  084cc29f8bbb ("KVM: x86/MMU: Allow NX huge pages to be disabled on a per-vm basis")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: build warning after merge of the kvm tree

[Wang, Wei W]

On Thursday, January 20, 2022 11:36 AM, Stephen Rothwell wrote:
> On Tue, 11 Jan 2022 02:55:56 +0000 "Wang, Wei W" <wei.w.wang@intel.com>
> wrote:
> >
> > On Monday, January 10, 2022 4:59 PM, Stephen Rothwell wrote:
> > > After merging the kvm tree, today's linux-next build (htmldocs) produced
> this
> > > warning:
> > >
> > > Documentation/virt/kvm/api.rst:5549: WARNING: Title underline too
> short.
> > >
> > > 4.42 KVM_GET_XSAVE2
> > > ------------------
> >
> > Should add one more "_" above.
> > 4.42 KVM_GET_XSAVE2
> > -------------------
> > +-------------------
> >
> > Paolo, do you want us to send another patch to add it or you can just add it?
> 
> I am still seeing this warning.
> 

I'll get you a patch to test soon.

Thanks,
Wei

Re: linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

Hi all,

On Tue, 11 Jan 2022 02:55:56 +0000 "Wang, Wei W" <wei.w.wang@intel.com> wrote:
>
> On Monday, January 10, 2022 4:59 PM, Stephen Rothwell wrote:
> > After merging the kvm tree, today's linux-next build (htmldocs) produced this
> > warning:
> > 
> > Documentation/virt/kvm/api.rst:5549: WARNING: Title underline too short.
> > 
> > 4.42 KVM_GET_XSAVE2
> > ------------------  
> 
> Should add one more "_" above.
> 4.42 KVM_GET_XSAVE2
> -------------------
> +-------------------
> 
> Paolo, do you want us to send another patch to add it or you can just add it?

I am still seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: build warning after merge of the kvm tree

[Wang, Wei W]

On Monday, January 10, 2022 4:59 PM, Stephen Rothwell wrote:
> After merging the kvm tree, today's linux-next build (htmldocs) produced this
> warning:
> 
> Documentation/virt/kvm/api.rst:5549: WARNING: Title underline too short.
> 
> 4.42 KVM_GET_XSAVE2
> ------------------

Should add one more "_" above.
4.42 KVM_GET_XSAVE2
-------------------
+-------------------

Paolo, do you want us to send another patch to add it or you can just add it?

Thanks,
Wei

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/virt/kvm/api.rst:5549: WARNING: Title underline too short.

4.42 KVM_GET_XSAVE2
------------------

Introduced by commit

  16786d406fe8 ("kvm: x86: Add support for getting/setting expanded xstate buffer")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/virt/kvm/api.rst:6243: WARNING: Title underline too short.

7.25 KVM_CAP_SGX_ATTRIBUTE
----------------------

Introduced by commit

  fe7e948837f3 ("KVM: x86: Add capability to grant VM access to privileged SGX attribute")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the kvm tree

[Paolo Bonzini]

On 09/02/21 10:59, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the kvm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/virt/kvm/api.rst:4927: WARNING: Title underline too short.
> 
> 4.130 KVM_XEN_VCPU_GET_ATTR
> --------------------------
> 
> Introduced by commit
> 
>    e1f68169a4f8 ("KVM: Add documentation for Xen hypercall and shared_info updates")
> 

Thanks, will fix.

Paolo

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/virt/kvm/api.rst:4927: WARNING: Title underline too short.

4.130 KVM_XEN_VCPU_GET_ATTR
--------------------------

Introduced by commit

  e1f68169a4f8 ("KVM: Add documentation for Xen hypercall and shared_info updates")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

WARNING: "kvm_get_arch_capabilities" [arch/x86/kvm/kvm] is a static EXPORT_SYMBOL_GPL

Introduced by commit

  cbbaa2727aa3 ("KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the kvm tree

[Gleb Natapov]

On Thu, Jan 10, 2013 at 01:34:36PM +1100, Stephen Rothwell wrote:
> Hi Marcelo,
> 
> After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> In file included from arch/x86/kvm/mmu.c:3482:0:
> arch/x86/kvm/paging_tmpl.h: In function 'paging64_walk_addr_generic':
> arch/x86/kvm/paging_tmpl.h:154:57: warning: unused variable 'shift' [-Wunused-variable]
> In file included from arch/x86/kvm/mmu.c:3486:0:
> arch/x86/kvm/paging_tmpl.h: In function 'paging32_walk_addr_generic':
> arch/x86/kvm/paging_tmpl.h:154:57: warning: unused variable 'shift' [-Wunused-variable]
> 
> Introduced by commit 908e7d7999bc ("KVM: MMU: simplify folding of dirty
> bit into accessed_dirty").
> 
Was fixed yesterday. Thanks.

--
			Gleb.

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

Hi Marcelo,

After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

In file included from arch/x86/kvm/mmu.c:3482:0:
arch/x86/kvm/paging_tmpl.h: In function 'paging64_walk_addr_generic':
arch/x86/kvm/paging_tmpl.h:154:57: warning: unused variable 'shift' [-Wunused-variable]
In file included from arch/x86/kvm/mmu.c:3486:0:
arch/x86/kvm/paging_tmpl.h: In function 'paging32_walk_addr_generic':
arch/x86/kvm/paging_tmpl.h:154:57: warning: unused variable 'shift' [-Wunused-variable]

Introduced by commit 908e7d7999bc ("KVM: MMU: simplify folding of dirty
bit into accessed_dirty").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the kvm tree

[Avi Kivity]

On 05/27/2010 01:19 PM, Roedel, Joerg wrote:
> On Thu, May 27, 2010 at 12:53:07AM -0400, Stephen Rothwell wrote:
>    
>> After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
>> produced this warning:
>>
>> arch/x86/kvm/svm.c: In function 'svm_handle_mce':
>> arch/x86/kvm/svm.c:1489: warning: unused variable 'kvm_run'
>>
>> Introduced by commit 5c91e7b615f7b6b36f6ad32356bb786bed5b7764 ("KVM: SVM:
>> Implement workaround for Erratum 383").
>>      
> Fix for that is already posted and should be in the KVM tree soon.
>
>    

I've just pushed it to linux-next.

-- 
error compiling committee.c: too many arguments to function

Re: linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

Hi Joerg,

On Thu, 27 May 2010 12:19:58 +0200 "Roedel, Joerg" <Joerg.Roedel@amd.com> wrote:
>
> Fix for that is already posted and should be in the KVM tree soon.

Great, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the kvm tree

[Roedel, Joerg]

On Thu, May 27, 2010 at 12:53:07AM -0400, Stephen Rothwell wrote:
> After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> arch/x86/kvm/svm.c: In function 'svm_handle_mce':
> arch/x86/kvm/svm.c:1489: warning: unused variable 'kvm_run'
> 
> Introduced by commit 5c91e7b615f7b6b36f6ad32356bb786bed5b7764 ("KVM: SVM:
> Implement workaround for Erratum 383").

Fix for that is already posted and should be in the KVM tree soon.

	Joerg

linux-next: build warning after merge of the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

Hi all,

After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

arch/x86/kvm/svm.c: In function 'svm_handle_mce':
arch/x86/kvm/svm.c:1489: warning: unused variable 'kvm_run'

Introduced by commit 5c91e7b615f7b6b36f6ad32356bb786bed5b7764 ("KVM: SVM:
Implement workaround for Erratum 383").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]