From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Matthew Garrett <mjg59@srcf.ucam.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the drivers-x86 tree
Date: Mon, 30 Aug 2010 12:51:19 +1000 [thread overview]
Message-ID: <20100830125119.b6a6cb22.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20100827074048.GB9120@core.coreip.homeip.net>
Hi all,
On Fri, 27 Aug 2010 00:40:48 -0700 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> On Fri, Aug 27, 2010 at 03:51:48AM +0100, Matthew Garrett wrote:
> > On Fri, Aug 27, 2010 at 11:59:50AM +1000, Stephen Rothwell wrote:
> >
> > > After merging the drivers-x86 tree, today's linux-next build (powerpc
> > > ppc64_defconfig and x86_64 allmodconfig) produced this warning:
> >
> > Oh Lordy. I should stop merging anything that contains "select". I'll
> > take a look at this tomorrow, but I'm about to head away for a week - if
> > anyone has a fix, feel free to find a way to get it merged.
> >
> > (Dmitry, there was a Kconfig issue when I merged your patch, so it's
> > entirely plausible that you're a completely innocent bystander here)
>
> Yeah, I think I am innocent here. My patch was adding "select
> INPUT_SPARCEKMAP" which is a library module and which I ensure to be
> selectable as long as INPUT is enabled. I do not want to switch it
> around into "depends on" since it is implementation detail and user
> should not care.
I applied this patch for today ...
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 30 Aug 2010 12:47:51 +1000
Subject: [PATCH] Fix Kconfig mistaken update
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/platform/x86/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b96db80..55579f1 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -497,7 +497,6 @@ config ACPI_TOSHIBA
depends on RFKILL || RFKILL = n
select INPUT_POLLDEV
select INPUT_SPARSEKMAP
- select BACKLIGHT_CLASS_DEVICE
---help---
This driver adds support for access to certain system settings
on "legacy free" Toshiba laptops. These laptops can be recognized by
--
1.7.1
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2010-08-30 2:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 1:59 linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell
2010-08-27 2:51 ` Matthew Garrett
2010-08-27 7:40 ` Dmitry Torokhov
2010-08-30 2:51 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-05 6:29 Stephen Rothwell
2023-02-03 2:53 Stephen Rothwell
2023-02-03 9:25 ` Hans de Goede
2021-02-04 5:13 Stephen Rothwell
2021-02-04 7:38 ` Hans de Goede
2021-02-04 15:05 ` Andy Shevchenko
2020-02-10 23:35 Stephen Rothwell
2020-02-10 23:39 ` Kammela, Gayatri
2020-02-11 21:07 ` Andy Shevchenko
2020-01-10 3:57 Stephen Rothwell
2020-01-10 9:47 ` Andy Shevchenko
2017-06-30 4:00 Stephen Rothwell
2017-06-30 5:12 ` Arvind Yadav
2017-07-01 3:32 ` Darren Hart
2017-05-19 3:23 Stephen Rothwell
2017-05-19 22:09 ` Darren Hart
2017-05-22 18:03 ` Andy Shevchenko
2017-05-25 23:34 ` Stephen Rothwell
2017-05-26 8:25 ` Arnd Bergmann
2017-05-26 8:35 ` Stephen Rothwell
2017-05-26 9:04 ` Andy Shevchenko
2017-05-26 9:07 ` Stephen Rothwell
2017-05-26 9:52 ` Andy Shevchenko
2016-12-14 2:50 Stephen Rothwell
2016-12-14 22:21 ` Darren Hart
2016-12-14 22:59 ` Darren Hart
2016-12-15 0:02 ` Stephen Rothwell
2016-12-15 4:07 ` Darren Hart
2010-06-25 3:25 Stephen Rothwell
2010-06-25 3:31 ` Matthew Garrett
2010-06-25 3:41 ` Matthew Garrett
2010-06-25 4:16 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100830125119.b6a6cb22.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).