From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ritesh Raj Sarraf <rrs@debian.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: linux-next: build warning after merge of the drivers-x86 tree
Date: Fri, 26 May 2017 09:34:12 +1000 [thread overview]
Message-ID: <20170526093412.3af222e6@canb.auug.org.au> (raw)
In-Reply-To: <CAHp75VcJ0eWgiRnsxqEVJjEtsNWzkH2+vRGuT6NmeHsH8NbyQQ@mail.gmail.com>
Hi Andy,
On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@infradead.org> wrote:
> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
> >>
> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
> >> static ssize_t touchpad_store(struct device *dev,
> >> ^
> >>
> >> Introduced by commit
> >>
> >> 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
> >
> >
> > Andy, you warned me about this and I had forgotten before I included it in next.
> >
> > Would you like to drop this change, or drop the touchpad_store function?
>
> I would go with Arnd's patch if he respins one addressing my comment.
Any progress on this?
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2017-05-25 23:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 3:23 linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell
2017-05-19 22:09 ` Darren Hart
2017-05-22 18:03 ` Andy Shevchenko
2017-05-25 23:34 ` Stephen Rothwell [this message]
2017-05-26 8:25 ` Arnd Bergmann
2017-05-26 8:35 ` Stephen Rothwell
2017-05-26 9:04 ` Andy Shevchenko
2017-05-26 9:07 ` Stephen Rothwell
2017-05-26 9:52 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2024-01-05 6:29 Stephen Rothwell
2023-02-03 2:53 Stephen Rothwell
2023-02-03 9:25 ` Hans de Goede
2021-02-04 5:13 Stephen Rothwell
2021-02-04 7:38 ` Hans de Goede
2021-02-04 15:05 ` Andy Shevchenko
2020-02-10 23:35 Stephen Rothwell
2020-02-10 23:39 ` Kammela, Gayatri
2020-02-11 21:07 ` Andy Shevchenko
2020-01-10 3:57 Stephen Rothwell
2020-01-10 9:47 ` Andy Shevchenko
2017-06-30 4:00 Stephen Rothwell
2017-06-30 5:12 ` Arvind Yadav
2017-07-01 3:32 ` Darren Hart
2016-12-14 2:50 Stephen Rothwell
2016-12-14 22:21 ` Darren Hart
2016-12-14 22:59 ` Darren Hart
2016-12-15 0:02 ` Stephen Rothwell
2016-12-15 4:07 ` Darren Hart
2010-08-27 1:59 Stephen Rothwell
2010-08-27 2:51 ` Matthew Garrett
2010-08-27 7:40 ` Dmitry Torokhov
2010-08-30 2:51 ` Stephen Rothwell
2010-06-25 3:25 Stephen Rothwell
2010-06-25 3:31 ` Matthew Garrett
2010-06-25 3:41 ` Matthew Garrett
2010-06-25 4:16 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526093412.3af222e6@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rrs@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).