linux-next: build warnings after merge of the tty tree

linux-next: build warnings after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:

drivers/tty/tty_io.c: In function 'tty_init':
drivers/tty/tty_io.c:3309: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/tty/vt/vt.c: In function 'vty_init':
drivers/tty/vt/vt.c:2997: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result

Introduced by commit fbc92a3455577ab17615cbcb91826399061bd789 ("tty: add
'active' sysfs attribute to tty0 and console device").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

P.S. that commits subject appears twice in the commit message.

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings after merge of the tty tree

[Greg KH]

On Tue, Dec 21, 2010 at 06:11:58PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
> 
> drivers/tty/tty_io.c: In function 'tty_init':
> drivers/tty/tty_io.c:3309: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
> drivers/tty/vt/vt.c: In function 'vty_init':
> drivers/tty/vt/vt.c:2997: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
> 
> Introduced by commit fbc92a3455577ab17615cbcb91826399061bd789 ("tty: add
> 'active' sysfs attribute to tty0 and console device").

Oops, Kay, care to make up a patch to fix these warnings?

thanks,

greg k-h

Re: linux-next: build warnings after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

Hi Greg, Kay,

On Tue, 21 Dec 2010 11:42:04 -0800 Greg KH <greg@kroah.com> wrote:
>
> On Tue, Dec 21, 2010 at 06:11:58PM +1100, Stephen Rothwell wrote:
> > 
> > After merging the tty tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced these warnings:
> > 
> > drivers/tty/tty_io.c: In function 'tty_init':
> > drivers/tty/tty_io.c:3309: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
> > drivers/tty/vt/vt.c: In function 'vty_init':
> > drivers/tty/vt/vt.c:2997: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
> > 
> > Introduced by commit fbc92a3455577ab17615cbcb91826399061bd789 ("tty: add
> > 'active' sysfs attribute to tty0 and console device").
> 
> Oops, Kay, care to make up a patch to fix these warnings?

These warnings are now in Linus' tree ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings after merge of the tty tree

[Kay Sievers]

On Mon, Jan 10, 2011 at 01:49, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Greg, Kay,
>
> On Tue, 21 Dec 2010 11:42:04 -0800 Greg KH <greg@kroah.com> wrote:
>>
>> On Tue, Dec 21, 2010 at 06:11:58PM +1100, Stephen Rothwell wrote:
>> >
>> > After merging the tty tree, today's linux-next build (powerpc
>> > ppc64_defconfig) produced these warnings:
>> >
>> > drivers/tty/tty_io.c: In function 'tty_init':
>> > drivers/tty/tty_io.c:3309: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
>> > drivers/tty/vt/vt.c: In function 'vty_init':
>> > drivers/tty/vt/vt.c:2997: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
>> >
>> > Introduced by commit fbc92a3455577ab17615cbcb91826399061bd789 ("tty: add
>> > 'active' sysfs attribute to tty0 and console device").
>>
>> Oops, Kay, care to make up a patch to fix these warnings?
>
> These warnings are now in Linus' tree ...

Discussing with Greg at the moment. Patch is on the way.

Thanks,
Kay

Re: linux-next: build warnings after merge of the tty tree

[Greg KH]

On Mon, Jan 10, 2011 at 11:49:59AM +1100, Stephen Rothwell wrote:
> Hi Greg, Kay,
> 
> On Tue, 21 Dec 2010 11:42:04 -0800 Greg KH <greg@kroah.com> wrote:
> >
> > On Tue, Dec 21, 2010 at 06:11:58PM +1100, Stephen Rothwell wrote:
> > > 
> > > After merging the tty tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced these warnings:
> > > 
> > > drivers/tty/tty_io.c: In function 'tty_init':
> > > drivers/tty/tty_io.c:3309: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
> > > drivers/tty/vt/vt.c: In function 'vty_init':
> > > drivers/tty/vt/vt.c:2997: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
> > > 
> > > Introduced by commit fbc92a3455577ab17615cbcb91826399061bd789 ("tty: add
> > > 'active' sysfs attribute to tty0 and console device").
> > 
> > Oops, Kay, care to make up a patch to fix these warnings?
> 
> These warnings are now in Linus' tree ...

Yes, Kay just sent me a patch to fix this, which I will queue up after
.38-rc1 is out.

thanks,

greg k-h

Re: linux-next: build warnings after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi Greg,

On Sun, 9 Jan 2011 16:56:01 -0800 Greg KH <greg@kroah.com> wrote:
>
> Yes, Kay just sent me a patch to fix this, which I will queue up after
> .38-rc1 is out.

It is surely a pretty obvious patch, why not just do a quick test and
send it on to Linus (or at least your tty-current tree)?

/me gets annoyed by more warnings than necessary - especially when they
should have never been introduced in the first place.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings after merge of the tty tree

[Greg KH]

On Mon, Jan 10, 2011 at 12:59:08PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Sun, 9 Jan 2011 16:56:01 -0800 Greg KH <greg@kroah.com> wrote:
> >
> > Yes, Kay just sent me a patch to fix this, which I will queue up after
> > .38-rc1 is out.
> 
> It is surely a pretty obvious patch, why not just do a quick test and
> send it on to Linus (or at least your tty-current tree)?
> 
> /me gets annoyed by more warnings than necessary - especially when they
> should have never been introduced in the first place.

Sorry, I try to keep patches that were not in -next from getting into
Linus's tree before -rc1, but you are right, this should be fixed.  I'll
forward it on later this week, or bundle it up in the "move tty drivers
around" patch that I have for Linus right after -rc1 is out.

thanks,

greg k-h

Re: linux-next: build warnings after merge of the tty tree

[Kay Sievers]

On Mon, Jan 10, 2011 at 02:59, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Greg,
>
> On Sun, 9 Jan 2011 16:56:01 -0800 Greg KH <greg@kroah.com> wrote:
>>
>> Yes, Kay just sent me a patch to fix this, which I will queue up after
>> .38-rc1 is out.
>
> It is surely a pretty obvious patch, why not just do a quick test and
> send it on to Linus (or at least your tty-current tree)?
>
> /me gets annoyed by more warnings than necessary - especially when they
> should have never been introduced in the first place.

Honestly, just disable these mindless warnings. They *might* be a hint
for a developer, but they should not be triggered in any non-manual
build.

These warnings usually just misguide people to make make random
trivial things fatal at bootup, which even prevent a box from coming
up and allow to find the real error. If these return values would
really be important, the called function would log the error itself,
not force the caller.

I personally think they are as useless as the dumb 80 char limit
checkpatch likes to warn about. It just makes things worse, hard to
read -- while it possibly should just warn about to many indents,
never the line length.

Like the must_check nonsense, it's all stuff with well-intended, but
with really bad results in reality.

People should really stop imposing these sick rules everywhere in
tools -- everybody of us has enough personal issues already, I really
don't need our software to throw the issues of other people at me on
top. :)

Kay

linux-next: build warnings after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/tty/serial/serial_mctrl_gpio.c: In function 'mctrl_gpio_init':
drivers/tty/serial/serial_mctrl_gpio.c:110:4: warning: return makes pointer from integer without a cast
    return PTR_ERR(gpios->gpio[i]);
    ^
drivers/tty/serial/serial_mctrl_gpio.c:90:6: warning: unused variable 'err' [-Wunused-variable]
  int err;
      ^

Introduced by commit 1d267ea6539f ("serial: mctrl-gpio: simplify init
routine").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build warnings after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced these warnings:

drivers/tty/serial/stm32-usart.c:155:12: warning: 'stm32_init_rs485' defined but not used [-Wunused-function]
 static int stm32_init_rs485(struct uart_port *port,
            ^~~~~~~~~~~~~~~~
drivers/tty/serial/stm32-usart.c:100:12: warning: 'stm32_config_rs485' defined but not used [-Wunused-function]
 static int stm32_config_rs485(struct uart_port *port,
            ^~~~~~~~~~~~~~~~~~

Introduced by commit

  1bcda09d2910 ("serial: stm32: add support for RS485 hardware control mode")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the tty tree

[Greg KH]

On Thu, Mar 15, 2018 at 05:43:31PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) produced these warnings:
> 
> drivers/tty/serial/stm32-usart.c:155:12: warning: 'stm32_init_rs485' defined but not used [-Wunused-function]
>  static int stm32_init_rs485(struct uart_port *port,
>             ^~~~~~~~~~~~~~~~
> drivers/tty/serial/stm32-usart.c:100:12: warning: 'stm32_config_rs485' defined but not used [-Wunused-function]
>  static int stm32_config_rs485(struct uart_port *port,
>             ^~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   1bcda09d2910 ("serial: stm32: add support for RS485 hardware control mode")

Fix for this just hit my tree, thanks for the notice.

greg k-h

linux-next: build warnings after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

Hi all,

After merging the tty tree, yesterday's linux-next build (htmldocs) produced
these warnings:

Documentation/tty/device_drivers/oxsemi-tornado.rst:41: WARNING: Inline interpreted text or phrase reference start-string without end-string.
Documentation/tty/device_drivers/oxsemi-tornado.rst:86: WARNING: Inline interpreted text or phrase reference start-string without end-string.
Documentation/tty/device_drivers/oxsemi-tornado.rst:96: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/tty/device_drivers/oxsemi-tornado.rst:100: WARNING: Inline interpreted text or phrase reference start-string without end-string.
Documentation/tty/device_drivers/oxsemi-tornado.rst:100: WARNING: Inline interpreted text or phrase reference start-string without end-string.
Documentation/tty/device_drivers/oxsemi-tornado.rst:100: WARNING: Inline interpreted text or phrase reference start-string without end-string.
Documentation/tty/device_drivers/oxsemi-tornado.rst:100: WARNING: Inline interpreted text or phrase reference start-string without end-string.
Documentation/tty/device_drivers/oxsemi-tornado.rst:100: WARNING: Inline interpreted text or phrase reference start-string without end-string.

Introduced by commit

  366f6c955d4d ("serial: 8250: Add proper clock handling for OxSemi PCIe devices")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the tty tree

[Maciej W. Rozycki]

On Wed, 11 May 2022, Stephen Rothwell wrote:

> After merging the tty tree, yesterday's linux-next build (htmldocs) produced
> these warnings:

 Umm, sorry about that.  I wasn't even aware files under Documentation/ 
are meant to be processed somehow other than through eyeballs nowadays!

 I'll see how to fix the file up and will make the necessary corrections, 
but how shall I post the update?  A replacement patch or an incremental 
change?

 Thanks for letting me know.

  Maciej

Re: linux-next: build warnings after merge of the tty tree

[Greg KH]

On Tue, May 10, 2022 at 11:46:26PM +0100, Maciej W. Rozycki wrote:
> On Wed, 11 May 2022, Stephen Rothwell wrote:
> 
> > After merging the tty tree, yesterday's linux-next build (htmldocs) produced
> > these warnings:
> 
>  Umm, sorry about that.  I wasn't even aware files under Documentation/ 
> are meant to be processed somehow other than through eyeballs nowadays!
> 
>  I'll see how to fix the file up and will make the necessary corrections, 
> but how shall I post the update?  A replacement patch or an incremental 
> change?

Incremental change as I can't rebase my tree.

thanks,

greg k-h

Re: linux-next: build warnings after merge of the tty tree

[Maciej W. Rozycki]

On Wed, 11 May 2022, Greg KH wrote:

> >  I'll see how to fix the file up and will make the necessary corrections, 
> > but how shall I post the update?  A replacement patch or an incremental 
> > change?
> 
> Incremental change as I can't rebase my tree.

 Thanks for the guidance!  Patches now posted, as a small series as the 
issue turned out more complex than one might have expected, see: 
<https://lore.kernel.org/lkml/alpine.DEB.2.21.2205131712410.10656@angie.orcam.me.uk/>.

  Maciej

linux-next: build warnings after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/driver-api/tty/tty_ldisc:46: include/linux/tty_ldisc.h:190: WARNING: Inline literal start-string without end-string.
Documentation/driver-api/tty/tty_ldisc:46: include/linux/tty_ldisc.h:190: WARNING: Inline emphasis start-string without end-string.
Documentation/driver-api/tty/tty_ldisc:46: include/linux/tty_ldisc.h:190: WARNING: Inline emphasis start-string without end-string.
Documentation/driver-api/tty/tty_ldisc:46: include/linux/tty_ldisc.h:190: WARNING: Inline emphasis start-string without end-string.

Introduced by commit

  6bb6fa6908eb ("tty: Implement lookahead to process XON/XOFF timely")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]