From: Randy Dunlap <randy.dunlap@oracle.com>
To: Zeng Zhaoming <zengzm.kernel@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org,
Zeng Zhaoming <zhaoming.zeng@freescale.com>,
Liam@alsa-project.org, Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH -next] soc: sgtl5000 uses regulator interfaces
Date: Tue, 15 Mar 2011 08:41:17 -0700 [thread overview]
Message-ID: <20110315084117.1e3a3a61.randy.dunlap@oracle.com> (raw)
In-Reply-To: <AANLkTikivW3+V4QYh9Nt9FGXTefZiN9WbpAvGVeBJHNN@mail.gmail.com>
On Sat, 5 Mar 2011 20:41:38 +0800 Zeng Zhaoming wrote:
> On Sat, Mar 5, 2011 at 7:29 PM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> > On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> sgtl5000 uses regulator interfaces, so make selecting it depend
> >> on REGULATOR.
> >>
> >> sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister'
> >> sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata'
> >> sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'
> >
>
> hi， Thanks for the report.
>
> > Since the regulator on the device is optional this isn't the best fix,
> > the code should be updated to support building without regulator.
>
> I will fix the code. If regulator not enabled, and the optional
> regulator not provided externally,
> a warning message will print out, and internal regulator will set
> directly by write register.
> > --
ping. This build error still happens in linux-next 2011.0315.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2011-03-15 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 7:00 linux-next: Tree for March 4 Stephen Rothwell
2011-03-05 1:33 ` [PATCH -next] soc: sgtl5000 uses regulator interfaces Randy Dunlap
2011-03-05 11:29 ` Mark Brown
2011-03-05 12:41 ` Zeng Zhaoming
2011-03-15 15:41 ` Randy Dunlap [this message]
2011-03-05 1:35 ` [PATCH -next] staging: altera-jtag needs delay.h Randy Dunlap
2011-03-29 21:27 ` Alexander Beregalov
2011-03-30 1:56 ` Mauro Carvalho Chehab
2011-03-06 22:52 ` linux-next: Tree for March 4 Mariusz Kozlowski
2011-03-07 11:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315084117.1e3a3a61.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=Liam@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sfr@canb.auug.org.au \
--cc=zengzm.kernel@gmail.com \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).