From: Zeng Zhaoming <zengzm.kernel@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Zeng Zhaoming <zhaoming.zeng@freescale.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH -next] soc: sgtl5000 uses regulator interfaces
Date: Sat, 5 Mar 2011 20:41:38 +0800 [thread overview]
Message-ID: <AANLkTikivW3+V4QYh9Nt9FGXTefZiN9WbpAvGVeBJHNN@mail.gmail.com> (raw)
In-Reply-To: <20110305112936.GA30187@opensource.wolfsonmicro.com>
On Sat, Mar 5, 2011 at 7:29 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> sgtl5000 uses regulator interfaces, so make selecting it depend
>> on REGULATOR.
>>
>> sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister'
>> sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata'
>> sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'
>
hi， Thanks for the report.
> Since the regulator on the device is optional this isn't the best fix,
> the code should be updated to support building without regulator.
I will fix the code. If regulator not enabled, and the optional
regulator not provided externally,
a warning message will print out, and internal regulator will set
directly by write register.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Best Regards
Zeng Zhaoming
next prev parent reply other threads:[~2011-03-05 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 7:00 linux-next: Tree for March 4 Stephen Rothwell
2011-03-05 1:33 ` [PATCH -next] soc: sgtl5000 uses regulator interfaces Randy Dunlap
2011-03-05 11:29 ` Mark Brown
2011-03-05 12:41 ` Zeng Zhaoming [this message]
2011-03-15 15:41 ` Randy Dunlap
2011-03-05 1:35 ` [PATCH -next] staging: altera-jtag needs delay.h Randy Dunlap
2011-03-29 21:27 ` Alexander Beregalov
2011-03-30 1:56 ` Mauro Carvalho Chehab
2011-03-06 22:52 ` linux-next: Tree for March 4 Mariusz Kozlowski
2011-03-07 11:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikivW3+V4QYh9Nt9FGXTefZiN9WbpAvGVeBJHNN@mail.gmail.com \
--to=zengzm.kernel@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).