linux-next: build failure after merge of the final tree (vfs tree related)

linux-next: build failure after merge of the final tree (vfs tree related)

[Stephen Rothwell]

Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

fs/fcntl.c: In function 'fcntl_init':
fs/fcntl.c:838: error: size of array 'type name' is negative

This is:

        BUILD_BUG_ON(19 - 1 /* for O_RDONLY being 0 */ != HWEIGHT32(
                O_RDONLY        | O_WRONLY      | O_RDWR        |
                O_CREAT         | O_EXCL        | O_NOCTTY      |
                O_TRUNC         | O_APPEND      | /* O_NONBLOCK | */
                __O_SYNC        | O_DSYNC       | FASYNC        |
                O_DIRECT        | O_LARGEFILE   | O_DIRECTORY   |
                O_NOFOLLOW      | O_NOATIME     | O_CLOEXEC     |
                __FMODE_EXEC    | O_PATH
                ));

in fcntl_init().

Caused by commit 1abf0c718f15 ("New kind of open files - "location
only".") from the vfs tree.  The new O_PATH valuse clashes with O_NOATIME
on sparc and O_CLOEXEC on alpha and parisc.

I applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 16 Mar 2011 18:02:46 +1100
Subject: [PATCH] vfs: add nonconflicting values for O_PATH

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/alpha/include/asm/fcntl.h  |    2 ++
 arch/parisc/include/asm/fcntl.h |    2 ++
 arch/sparc/include/asm/fcntl.h  |    2 ++
 3 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/alpha/include/asm/fcntl.h b/arch/alpha/include/asm/fcntl.h
index 70145cb..1b71ca7 100644
--- a/arch/alpha/include/asm/fcntl.h
+++ b/arch/alpha/include/asm/fcntl.h
@@ -31,6 +31,8 @@
 #define __O_SYNC	020000000
 #define O_SYNC		(__O_SYNC|O_DSYNC)
 
+#define O_PATH		040000000
+
 #define F_GETLK		7
 #define F_SETLK		8
 #define F_SETLKW	9
diff --git a/arch/parisc/include/asm/fcntl.h b/arch/parisc/include/asm/fcntl.h
index f357fc6..0304b92 100644
--- a/arch/parisc/include/asm/fcntl.h
+++ b/arch/parisc/include/asm/fcntl.h
@@ -19,6 +19,8 @@
 #define O_NOFOLLOW	000000200 /* don't follow links */
 #define O_INVISIBLE	004000000 /* invisible I/O, for DMAPI/XDSM */
 
+#define O_PATH		020000000
+
 #define F_GETLK64	8
 #define F_SETLK64	9
 #define F_SETLKW64	10
diff --git a/arch/sparc/include/asm/fcntl.h b/arch/sparc/include/asm/fcntl.h
index 38f37b33..d0b83f6 100644
--- a/arch/sparc/include/asm/fcntl.h
+++ b/arch/sparc/include/asm/fcntl.h
@@ -34,6 +34,8 @@
 #define __O_SYNC	0x800000
 #define O_SYNC		(__O_SYNC|O_DSYNC)
 
+#define O_PATH		0x1000000
+
 #define F_GETOWN	5	/*  for sockets. */
 #define F_SETOWN	6	/*  for sockets. */
 #define F_GETLK		7
-- 
1.7.4.1


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the final tree (vfs tree related)

[Al Viro]

On Wed, Mar 16, 2011 at 06:09:27PM +1100, Stephen Rothwell wrote:
> I applied this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 16 Mar 2011 18:02:46 +1100
> Subject: [PATCH] vfs: add nonconflicting values for O_PATH
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

[snip]

grabbed, will go to Linus in the morning

linux-next: build failure after merge of the final tree (vfs tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

security/security.c: In function 'mmap_prot':
security/security.c:670:31: error: 'READ_IMPLIES_EXEC' undeclared (first use in this function)

Caused by commit 185b26574c03 ("take security_mmap_file() outside of
->mmap_sem") from the vfs tree.  Missing include of linux/personality.h.

I have added this fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 1 Jun 2012 13:10:47 +1000
Subject: [PATCH] security: using READ_IMPLIES_EXEC needs personality.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 security/security.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/security/security.c b/security/security.c
index 257fe77..3efc9b1 100644
--- a/security/security.c
+++ b/security/security.c
@@ -22,6 +22,7 @@
 #include <linux/fsnotify.h>
 #include <linux/mman.h>
 #include <linux/mount.h>
+#include <linux/personality.h>
 #include <net/flow.h>
 
 #define MAX_LSM_EVM_XATTR	2
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (vfs tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc32 defconfig)
failed like this:

drivers/tty/sysrq.c: In function 'write_sysrq_trigger':
drivers/tty/sysrq.c:867:3: error: implicit declaration of function 'get_user' [-Werror=implicit-function-declaration]

Caused by commit b1cdabb05024 ("fs: move code out of buffer.c").
Presumably buffer_head.h was implictly including uaccess.h.

I have added the following patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 28 Dec 2011 19:28:15 +1100
Subject: [PATCH] sysreq.c needs uaccess.h for get_user

Commit b1cdabb05024 ("fs: move code out of buffer.c") removed the include
of linux/buffer_head.h which was presumably implictly including uaccess.h
on sparc32.

Fixes this build error:

drivers/tty/sysrq.c: In function 'write_sysrq_trigger':
drivers/tty/sysrq.c:867:3: error: implicit declaration of function 'get_user' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/tty/sysrq.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 4629801..7867b7c 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -40,6 +40,7 @@
 #include <linux/oom.h>
 #include <linux/slab.h>
 #include <linux/input.h>
+#include <linux/uaccess.h>
 
 #include <asm/ptrace.h>
 #include <asm/irq_regs.h>
-- 
1.7.8.197.g73c6b

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]