linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the nfsd tree
Date: Thu, 17 Mar 2011 14:09:28 -0400	[thread overview]
Message-ID: <20110317180928.GF30180@fieldses.org> (raw)
In-Reply-To: <20110310115331.10a95d57.sfr@canb.auug.org.au>

On Thu, Mar 10, 2011 at 11:53:31AM +1100, Stephen Rothwell wrote:
> Hi Bruce,
> 
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> net/sunrpc/svcauth_unix.c: In function 'unix_domain_find':
> net/sunrpc/svcauth_unix.c:58: warning: passing argument 1 of 'svcauth_unix_domain_release' from incompatible pointer type
> net/sunrpc/svcauth_unix.c:41: note: expected 'struct auth_domain *' but argument is of type 'struct unix_domain *'
> 
> Introduced by commit 8b3e07ac908d ("svcrpc: fix rare race on unix_domain
> creation").

Should be fixed, thanks for the report.

--b.

commit 352b5d13c0684ba8cd103aa20cb74f105334562a
Author: J. Bruce Fields <bfields@redhat.com>
Date:   Wed Mar 9 22:40:30 2011 -0500

    svcrpc: fix bad argument in unix_domain_find
    
    "After merging the nfsd tree, today's linux-next build (powerpc
    ppc64_defconfig) produced this warning:
    
    net/sunrpc/svcauth_unix.c: In function 'unix_domain_find':
    net/sunrpc/svcauth_unix.c:58: warning: passing argument 1 of
    +'svcauth_unix_domain_release' from incompatible pointer type
    net/sunrpc/svcauth_unix.c:41: note: expected 'struct auth_domain *' but
    argument
    +is of type 'struct unix_domain *'
    
    Introduced by commit 8b3e07ac908d ("svcrpc: fix rare race on unix_domain
    creation")."
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>

diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
index d100bf2..c8e1021 100644
--- a/net/sunrpc/svcauth_unix.c
+++ b/net/sunrpc/svcauth_unix.c
@@ -55,7 +55,7 @@ struct auth_domain *unix_domain_find(char *name)
 	while(1) {
 		if (rv) {
 			if (new && rv != &new->h)
-				svcauth_unix_domain_release(new);
+				svcauth_unix_domain_release(&new->h);
 
 			if (rv->flavour != &svcauth_unix) {
 				auth_domain_put(rv);

  reply	other threads:[~2011-03-17 18:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10  0:53 linux-next: build warning after merge of the nfsd tree Stephen Rothwell
2011-03-17 18:09 ` J. Bruce Fields [this message]
2017-04-03  1:09 Stephen Rothwell
2017-04-03  2:39 ` J. Bruce Fields
2018-01-18 23:23 Stephen Rothwell
2018-05-10  0:42 Stephen Rothwell
2018-05-10 14:21 ` Chuck Lever
2018-05-10 15:24   ` Bruce Fields
2018-05-10 16:10     ` Chuck Lever
2022-02-15  9:27 Stephen Rothwell
2022-02-15 15:08 ` Chuck Lever III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110317180928.GF30180@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).