linux-next: build warning after merge of the nfsd tree

linux-next: build warning after merge of the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi Bruce,

After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

net/sunrpc/svcauth_unix.c: In function 'unix_domain_find':
net/sunrpc/svcauth_unix.c:58: warning: passing argument 1 of 'svcauth_unix_domain_release' from incompatible pointer type
net/sunrpc/svcauth_unix.c:41: note: expected 'struct auth_domain *' but argument is of type 'struct unix_domain *'

Introduced by commit 8b3e07ac908d ("svcrpc: fix rare race on unix_domain
creation").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the nfsd tree

[J. Bruce Fields]

On Thu, Mar 10, 2011 at 11:53:31AM +1100, Stephen Rothwell wrote:
> Hi Bruce,
> 
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> net/sunrpc/svcauth_unix.c: In function 'unix_domain_find':
> net/sunrpc/svcauth_unix.c:58: warning: passing argument 1 of 'svcauth_unix_domain_release' from incompatible pointer type
> net/sunrpc/svcauth_unix.c:41: note: expected 'struct auth_domain *' but argument is of type 'struct unix_domain *'
> 
> Introduced by commit 8b3e07ac908d ("svcrpc: fix rare race on unix_domain
> creation").

Should be fixed, thanks for the report.

--b.

commit 352b5d13c0684ba8cd103aa20cb74f105334562a
Author: J. Bruce Fields <bfields@redhat.com>
Date:   Wed Mar 9 22:40:30 2011 -0500

    svcrpc: fix bad argument in unix_domain_find
    
    "After merging the nfsd tree, today's linux-next build (powerpc
    ppc64_defconfig) produced this warning:
    
    net/sunrpc/svcauth_unix.c: In function 'unix_domain_find':
    net/sunrpc/svcauth_unix.c:58: warning: passing argument 1 of
    +'svcauth_unix_domain_release' from incompatible pointer type
    net/sunrpc/svcauth_unix.c:41: note: expected 'struct auth_domain *' but
    argument
    +is of type 'struct unix_domain *'
    
    Introduced by commit 8b3e07ac908d ("svcrpc: fix rare race on unix_domain
    creation")."
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>

diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
index d100bf2..c8e1021 100644
--- a/net/sunrpc/svcauth_unix.c
+++ b/net/sunrpc/svcauth_unix.c
@@ -55,7 +55,7 @@ struct auth_domain *unix_domain_find(char *name)
 	while(1) {
 		if (rv) {
 			if (new && rv != &new->h)
-				svcauth_unix_domain_release(new);
+				svcauth_unix_domain_release(&new->h);
 
 			if (rv->flavour != &svcauth_unix) {
 				auth_domain_put(rv);

Re: linux-next: build warning after merge of the nfsd tree

[Chuck Lever III]

> On Feb 15, 2022, at 4:27 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi all,
> 
> After merging the nfsd tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/networking/kapi:62: net/sunrpc/svc_xprt.c:331: WARNING: Unknown target name: "sock".
> 
> Introduced by commit
> 
>  26978084103a ("SUNRPC: Rename svc_create_xprt()")

Thank you, Stephen. I'll fix that up.


--
Chuck Lever

linux-next: build warning after merge of the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

Hi all,

After merging the nfsd tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/networking/kapi:62: net/sunrpc/svc_xprt.c:331: WARNING: Unknown target name: "sock".

Introduced by commit

  26978084103a ("SUNRPC: Rename svc_create_xprt()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the nfsd tree

[Chuck Lever]

> On May 10, 2018, at 11:24 AM, Bruce Fields <bfields@fieldses.org> wrote:
> 
> On Thu, May 10, 2018 at 10:21:05AM -0400, Chuck Lever wrote:
>> 
>> 
>>> On May 9, 2018, at 8:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>> 
>>> Hi all,
>>> 
>>> After merging the nfsd tree, today's linux-next build (powerpc
>>> ppc64_defconfig) produced this warning:
>>> 
>>> net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
>>> net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
>>> struct svcxprt_rdma *rdma = cma_id->context;
>>>                      ^~~~
>> 
>> Needs to be wrapped with "#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)"
>> Would you like me to send a patch?
> 
> Any objection to saving the #if and just going back to writing out
> cma_id->context there?

LGTM

That's not really very useful information anyway, but I decided
to leave this stuff mostly as-is for now. I plan to do something
to fix races between disconnect and device removal at some point.


> I've done that in my tree.
> 
> --b.
> 
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index ca9001d73456..05edb18f8ca3 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -544,7 +544,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
> 			       struct rdma_cm_event *event)
> {
> 	struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr;
> -	struct svcxprt_rdma *rdma = cma_id->context;
> 	int ret = 0;
> 
> 	trace_svcrdma_cm_event(event, sap);
> @@ -552,7 +551,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
> 	switch (event->event) {
> 	case RDMA_CM_EVENT_CONNECT_REQUEST:
> 		dprintk("svcrdma: Connect request on cma_id=%p, xprt = %p, "
> -			"event = %s (%d)\n", cma_id, rdma,
> +			"event = %s (%d)\n", cma_id, cma_id->context,
> 			rdma_event_msg(event->event), event->event);
> 		handle_connect_req(cma_id, &event->param.conn);
> 		break;

--
Chuck Lever

Re: linux-next: build warning after merge of the nfsd tree

[Bruce Fields]

On Thu, May 10, 2018 at 10:21:05AM -0400, Chuck Lever wrote:
> 
> 
> > On May 9, 2018, at 8:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > Hi all,
> > 
> > After merging the nfsd tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
> > net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
> >  struct svcxprt_rdma *rdma = cma_id->context;
> >                       ^~~~
> 
> Needs to be wrapped with "#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)"
> Would you like me to send a patch?

Any objection to saving the #if and just going back to writing out
cma_id->context there?

I've done that in my tree.

--b.

diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index ca9001d73456..05edb18f8ca3 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -544,7 +544,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
 			       struct rdma_cm_event *event)
 {
 	struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr;
-	struct svcxprt_rdma *rdma = cma_id->context;
 	int ret = 0;
 
 	trace_svcrdma_cm_event(event, sap);
@@ -552,7 +551,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
 	switch (event->event) {
 	case RDMA_CM_EVENT_CONNECT_REQUEST:
 		dprintk("svcrdma: Connect request on cma_id=%p, xprt = %p, "
-			"event = %s (%d)\n", cma_id, rdma,
+			"event = %s (%d)\n", cma_id, cma_id->context,
 			rdma_event_msg(event->event), event->event);
 		handle_connect_req(cma_id, &event->param.conn);
 		break;

Re: linux-next: build warning after merge of the nfsd tree

[Chuck Lever]

> On May 9, 2018, at 8:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi all,
> 
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
> net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
>  struct svcxprt_rdma *rdma = cma_id->context;
>                       ^~~~

Needs to be wrapped with "#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)"
Would you like me to send a patch?


> Introduced by commit
> 
>  d1ab72afe681 ("svcrdma: Trace key RDMA API events")

--
Chuck Lever

linux-next: build warning after merge of the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi all,

After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
  struct svcxprt_rdma *rdma = cma_id->context;
                       ^~~~

Introduced by commit

  d1ab72afe681 ("svcrdma: Trace key RDMA API events")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nfsd tree

[Stephen Rothwell]

Hi,

After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/nfsd/nfs4xdr.c:241:1: warning: 'svcxdr_dupstr' defined but not used [-Wunused-function]
 svcxdr_dupstr(struct nfsd4_compoundargs *argp, void *buf, u32 len)
 ^~~~~~~~~~~~~

Introduced by commit

  e40d99e6183e ("NFSD: Clean up symlink argument XDR decoders")

The only remaining call is protected by CONFIG_NFSD_V4_SECURITY_LABEL.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the nfsd tree

[J. Bruce Fields]

On Mon, Apr 03, 2017 at 11:09:48AM +1000, Stephen Rothwell wrote:
> Hi,
> 
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/nfsd/nfs4state.c: In function 'copy_cred':
> fs/nfsd/nfs4state.c:1917:6: warning: unused variable 'ret' [-Wunused-variable]
>   int ret;
>       ^
> 
> Introduced by commit
> 
>   d39662236bf8 ("nfsd4: remove pointless strdup_if_nonnull")
> 
> Also, that commit has no Signed-off-by from its Author.

Both fixed, thanks.--b.

linux-next: build warning after merge of the nfsd tree

[Stephen Rothwell]

Hi,

After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/nfsd/nfs4state.c: In function 'copy_cred':
fs/nfsd/nfs4state.c:1917:6: warning: unused variable 'ret' [-Wunused-variable]
  int ret;
      ^

Introduced by commit

  d39662236bf8 ("nfsd4: remove pointless strdup_if_nonnull")

Also, that commit has no Signed-off-by from its Author.

-- 
Cheers,
Stephen Rothwell