* linux-next: build failure after merge of the voltage tree
@ 2011-05-10 2:44 Stephen Rothwell
2011-05-10 8:38 ` Liam Girdwood
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2011-05-10 2:44 UTC (permalink / raw)
To: Liam Girdwood
Cc: linux-next, linux-kernel, Graeme Gregory, Jorge Eduardo Candelaria
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
Hi Liam,
After merging the voltage tree, today's linux-next build (x86_64
allmodconfig) failed like this:
ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
I have used the voltage tree from next-20110509 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-10 2:44 linux-next: build failure after merge of the voltage tree Stephen Rothwell
@ 2011-05-10 8:38 ` Liam Girdwood
2011-05-10 17:30 ` Jorge Eduardo Candelaria
0 siblings, 1 reply; 10+ messages in thread
From: Liam Girdwood @ 2011-05-10 8:38 UTC (permalink / raw)
To: Jorge Eduardo Candelaria
Cc: linux-next, linux-kernel, Graeme Gregory, Stephen Rothwell
On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> Hi Liam,
>
> After merging the voltage tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
>
> I have used the voltage tree from next-20110509 for today.
Jorge, could you send a fix for this today.
Thanks
Liam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-10 8:38 ` Liam Girdwood
@ 2011-05-10 17:30 ` Jorge Eduardo Candelaria
2011-05-10 19:57 ` Liam Girdwood
2011-05-11 2:27 ` Stephen Rothwell
0 siblings, 2 replies; 10+ messages in thread
From: Jorge Eduardo Candelaria @ 2011-05-10 17:30 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-next, linux-kernel, Graeme Gregory, Stephen Rothwell
On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
>> Hi Liam,
>>
>> After merging the voltage tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
>>
>> I have used the voltage tree from next-20110509 for today.
>
> Jorge, could you send a fix for this today.
>
> Thanks
>
> Liam
>
The following patch should solve this:
From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
MFD: Fix TPS65910 build
Support for tps65910 as a module is not available. The driver can
only be compiled as built-in. OTOH, the regulator driver can still
be built as module without breaking the compilation.
Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
---
drivers/mfd/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 65930a7..c78865e 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -672,8 +672,8 @@ config MFD_OMAP_USB_HOST
OMAP USB Host drivers.
config MFD_TPS65910
- tristate "TPS65910 Power Management chip"
- depends on I2C && GPIOLIB
+ bool "TPS65910 Power Management chip"
+ depends on I2C && GPIOLIB
select MFD_CORE
help
if you say yes here you get support for the TPS65910 series of
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-10 17:30 ` Jorge Eduardo Candelaria
@ 2011-05-10 19:57 ` Liam Girdwood
2011-05-11 2:27 ` Stephen Rothwell
1 sibling, 0 replies; 10+ messages in thread
From: Liam Girdwood @ 2011-05-10 19:57 UTC (permalink / raw)
To: Jorge Eduardo Candelaria
Cc: linux-next, linux-kernel, Graeme Gregory, Stephen Rothwell
On Tue, 2011-05-10 at 12:30 -0500, Jorge Eduardo Candelaria wrote:
> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
>
> > On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >> Hi Liam,
> >>
> >> After merging the voltage tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >>
> >> I have used the voltage tree from next-20110509 for today.
> >
> > Jorge, could you send a fix for this today.
> >
> > Thanks
> >
> > Liam
> >
>
> The following patch should solve this:
>
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> MFD: Fix TPS65910 build
>
> Support for tps65910 as a module is not available. The driver can
> only be compiled as built-in. OTOH, the regulator driver can still
> be built as module without breaking the compilation.
>
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> ---
> drivers/mfd/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 65930a7..c78865e 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -672,8 +672,8 @@ config MFD_OMAP_USB_HOST
> OMAP USB Host drivers.
>
> config MFD_TPS65910
> - tristate "TPS65910 Power Management chip"
> - depends on I2C && GPIOLIB
> + bool "TPS65910 Power Management chip"
> + depends on I2C && GPIOLIB
> select MFD_CORE
> help
> if you say yes here you get support for the TPS65910 series of
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-10 17:30 ` Jorge Eduardo Candelaria
2011-05-10 19:57 ` Liam Girdwood
@ 2011-05-11 2:27 ` Stephen Rothwell
2011-05-11 6:43 ` Jorge Eduardo Candelaria
2011-05-11 8:47 ` [PATCH] mfd: TPS65910 depends on I2C and must be built in Mark Brown
1 sibling, 2 replies; 10+ messages in thread
From: Stephen Rothwell @ 2011-05-11 2:27 UTC (permalink / raw)
To: Jorge Eduardo Candelaria
Cc: Liam Girdwood, linux-next, linux-kernel, Graeme Gregory
[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]
Hi Jorge,
On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
>
> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
>
> > On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >> Hi Liam,
> >>
> >> After merging the voltage tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >>
> >> I have used the voltage tree from next-20110509 for today.
> >
> > Jorge, could you send a fix for this today.
>
> The following patch should solve this:
>
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> MFD: Fix TPS65910 build
>
> Support for tps65910 as a module is not available. The driver can
> only be compiled as built-in. OTOH, the regulator driver can still
> be built as module without breaking the compilation.
>
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Today (even with the above patch included) I got these errors from the
x86_64 allmodconfig build:
tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `tps65910_i2c_read':
tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `tps65910_i2c_init':
tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `tps65910_i2c_exit':
tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
I have used the voltage tree from next-20110509 again today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-11 2:27 ` Stephen Rothwell
@ 2011-05-11 6:43 ` Jorge Eduardo Candelaria
2011-05-11 13:29 ` Liam Girdwood
2011-05-11 8:47 ` [PATCH] mfd: TPS65910 depends on I2C and must be built in Mark Brown
1 sibling, 1 reply; 10+ messages in thread
From: Jorge Eduardo Candelaria @ 2011-05-11 6:43 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Graeme Gregory
On May 10, 2011, at 9:27 PM, Stephen Rothwell wrote:
> Hi Jorge,
>
> On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
>>
>> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
>>
>>> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
>>>> Hi Liam,
>>>>
>>>> After merging the voltage tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
>>>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
>>>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
>>>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
>>>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
>>>>
>>>> I have used the voltage tree from next-20110509 for today.
>>>
>>> Jorge, could you send a fix for this today.
>>
>> The following patch should solve this:
>>
>> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
>> MFD: Fix TPS65910 build
>>
>> Support for tps65910 as a module is not available. The driver can
>> only be compiled as built-in. OTOH, the regulator driver can still
>> be built as module without breaking the compilation.
>>
>> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
>
> Today (even with the above patch included) I got these errors from the
> x86_64 allmodconfig build:
>
> tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `tps65910_i2c_read':
> tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
> drivers/built-in.o: In function `tps65910_i2c_init':
> tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `tps65910_i2c_exit':
> tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
>
> I have used the voltage tree from next-20110509 again today.
Following patch should fix the dependency problems. Please review:
From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
[PATCH] MFD: TPS65910: Fix I2C dependency
TPS65910 driver can only be compiled built-in, so the I2C driver
should be as well.
Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index c78865e..0131d49 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -673,7 +673,7 @@ config MFD_OMAP_USB_HOST
config MFD_TPS65910
bool "TPS65910 Power Management chip"
- depends on I2C && GPIOLIB
+ depends on I2C=y && GPIOLIB
select MFD_CORE
help
if you say yes here you get support for the TPS65910 series of
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] mfd: TPS65910 depends on I2C and must be built in
2011-05-11 2:27 ` Stephen Rothwell
2011-05-11 6:43 ` Jorge Eduardo Candelaria
@ 2011-05-11 8:47 ` Mark Brown
2011-05-11 13:35 ` Liam Girdwood
1 sibling, 1 reply; 10+ messages in thread
From: Mark Brown @ 2011-05-11 8:47 UTC (permalink / raw)
To: Jorge Eduardo Candelaria, Liam Girdwood, Graeme Gregory
Cc: linux-next, linux-kernel, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index c78865e..0131d49 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -673,7 +673,7 @@ config MFD_OMAP_USB_HOST
config MFD_TPS65910
bool "TPS65910 Power Management chip"
- depends on I2C && GPIOLIB
+ depends on I2C=y && GPIOLIB
select MFD_CORE
help
if you say yes here you get support for the TPS65910 series of
--
1.7.5.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-11 6:43 ` Jorge Eduardo Candelaria
@ 2011-05-11 13:29 ` Liam Girdwood
0 siblings, 0 replies; 10+ messages in thread
From: Liam Girdwood @ 2011-05-11 13:29 UTC (permalink / raw)
To: Jorge Eduardo Candelaria
Cc: Stephen Rothwell, linux-next, linux-kernel, Graeme Gregory
On Wed, 2011-05-11 at 01:43 -0500, Jorge Eduardo Candelaria wrote:
> On May 10, 2011, at 9:27 PM, Stephen Rothwell wrote:
>
> > Hi Jorge,
> >
> > On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
> >>
> >> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> >>
> >>> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >>>> Hi Liam,
> >>>>
> >>>> After merging the voltage tree, today's linux-next build (x86_64
> >>>> allmodconfig) failed like this:
> >>>>
> >>>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >>>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >>>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>>
> >>>> I have used the voltage tree from next-20110509 for today.
> >>>
> >>> Jorge, could you send a fix for this today.
> >>
> >> The following patch should solve this:
> >>
> >> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> >> MFD: Fix TPS65910 build
> >>
> >> Support for tps65910 as a module is not available. The driver can
> >> only be compiled as built-in. OTOH, the regulator driver can still
> >> be built as module without breaking the compilation.
> >>
> >> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> >
> > Today (even with the above patch included) I got these errors from the
> > x86_64 allmodconfig build:
> >
> > tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
> > drivers/built-in.o: In function `tps65910_i2c_read':
> > tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
> > drivers/built-in.o: In function `tps65910_i2c_init':
> > tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
> > drivers/built-in.o: In function `tps65910_i2c_exit':
> > tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
> >
> > I have used the voltage tree from next-20110509 again today.
>
> Following patch should fix the dependency problems. Please review:
>
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> [PATCH] MFD: TPS65910: Fix I2C dependency
>
> TPS65910 driver can only be compiled built-in, so the I2C driver
> should be as well.
>
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index c78865e..0131d49 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -673,7 +673,7 @@ config MFD_OMAP_USB_HOST
>
> config MFD_TPS65910
> bool "TPS65910 Power Management chip"
> - depends on I2C && GPIOLIB
> + depends on I2C=y && GPIOLIB
> select MFD_CORE
> help
> if you say yes here you get support for the TPS65910 series of
Now applied.
Liam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: TPS65910 depends on I2C and must be built in
2011-05-11 8:47 ` [PATCH] mfd: TPS65910 depends on I2C and must be built in Mark Brown
@ 2011-05-11 13:35 ` Liam Girdwood
2011-05-11 13:36 ` Mark Brown
0 siblings, 1 reply; 10+ messages in thread
From: Liam Girdwood @ 2011-05-11 13:35 UTC (permalink / raw)
To: Mark Brown
Cc: Jorge Eduardo Candelaria, Graeme Gregory, linux-next, linux-kernel
On Wed, 2011-05-11 at 10:47 +0200, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index c78865e..0131d49 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -673,7 +673,7 @@ config MFD_OMAP_USB_HOST
>
> config MFD_TPS65910
> bool "TPS65910 Power Management chip"
> - depends on I2C && GPIOLIB
> + depends on I2C=y && GPIOLIB
> select MFD_CORE
> help
> if you say yes here you get support for the TPS65910 series of
Thanks, Applied the exact same patch from Jorge (sent a few hours
before).
Thanks
Liam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: TPS65910 depends on I2C and must be built in
2011-05-11 13:35 ` Liam Girdwood
@ 2011-05-11 13:36 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2011-05-11 13:36 UTC (permalink / raw)
To: Liam Girdwood
Cc: Jorge Eduardo Candelaria, Graeme Gregory, linux-next, linux-kernel
On Wed, May 11, 2011 at 02:35:18PM +0100, Liam Girdwood wrote:
> Thanks, Applied the exact same patch from Jorge (sent a few hours
> before).
Mutter, mutter, send to list, mutter, mutter. :)
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-05-11 16:29 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-10 2:44 linux-next: build failure after merge of the voltage tree Stephen Rothwell
2011-05-10 8:38 ` Liam Girdwood
2011-05-10 17:30 ` Jorge Eduardo Candelaria
2011-05-10 19:57 ` Liam Girdwood
2011-05-11 2:27 ` Stephen Rothwell
2011-05-11 6:43 ` Jorge Eduardo Candelaria
2011-05-11 13:29 ` Liam Girdwood
2011-05-11 8:47 ` [PATCH] mfd: TPS65910 depends on I2C and must be built in Mark Brown
2011-05-11 13:35 ` Liam Girdwood
2011-05-11 13:36 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).