From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: linux-next: build failure after merge of the final tree (uprobes tree related)
Date: Wed, 23 Nov 2011 14:44:09 +1100 [thread overview]
Message-ID: <20111123144409.7d1816bef960a2f277aaf1b9@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]
Hi Srikar,
After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:
In file included from include/linux/mm_types.h:15:0,
from include/linux/sched.h:64,
from arch/powerpc/mm/mem.c:21:
include/linux/uprobes.h:174:49: error: 'struct mm_struct' declared inside parameter list [-Werror]
include/linux/uprobes.h:174:49: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
And many more similar.
Caused by commit 61fafad13005 ("uprobes_xol" - "uprobes: slot allocation").
I have added the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 23 Nov 2011 14:35:01 +1100
Subject: [PATCH] uprobes: declare mm_struct before its use in uprobes.h
Since there is a circular dependency between uprobes.h and mm_type.h
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/uprobes.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 20bdd0a..091dfb8 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -26,6 +26,7 @@
#include <linux/rbtree.h>
struct vm_area_struct;
+struct mm_struct;
#ifdef CONFIG_ARCH_SUPPORTS_UPROBES
#include <asm/uprobes.h>
#else
--
1.7.7.3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2011-11-23 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 3:44 Stephen Rothwell [this message]
2011-11-23 10:42 ` linux-next: build failure after merge of the final tree (uprobes tree related) Srikar Dronamraju
2011-11-23 4:28 Stephen Rothwell
2011-11-23 9:54 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123144409.7d1816bef960a2f277aaf1b9@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).