linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (uprobes tree related)
Date: Wed, 23 Nov 2011 15:24:43 +0530	[thread overview]
Message-ID: <20111123095443.GA22971@linux.vnet.ibm.com> (raw)
In-Reply-To: <20111123152854.98c60a7c859f28c2efa30717@canb.auug.org.au>


Hey Stephen, 

> After merging the uprobes tree, today's linux-next build (sparc64
> defconfig) failed like this:
> 
> In file included from include/linux/mm_types.h:15:0,
>                  from include/linux/kmemcheck.h:4,
>                  from include/linux/skbuff.h:18,
>                  from net/8021q/vlan_core.c:1:
> include/linux/uprobes.h: In function 'register_uprobe':
> include/linux/uprobes.h:148:10: error: 'ENOSYS' undeclared (first use in this function)
> 

Oh sorry for missing this.

> And several more.
> 
> Caused by commit fb16338b69cd ("register_unregister_uprobe" - "Uprobes:
> register/unregister probes").
> 
> I have added this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 23 Nov 2011 15:11:20 +1100
> Subject: [PATCH] uprobes: using ENOSYS requires errno.h
> 
> Fixes this build problem:
> 
> In file included from include/linux/mm_types.h:15:0,
>                  from include/linux/kmemcheck.h:4,
>                  from include/linux/skbuff.h:18,
>                  from net/8021q/vlan_core.c:1:
> include/linux/uprobes.h: In function 'register_uprobe':
> include/linux/uprobes.h:148:10: error: 'ENOSYS' undeclared (first use in this function)
> 
> when CONFIG_UPROBES is not defined.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/linux/uprobes.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
> index 091dfb8..e2e0674 100644
> --- a/include/linux/uprobes.h
> +++ b/include/linux/uprobes.h
> @@ -23,6 +23,7 @@
>   *	Jim Keniston
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/rbtree.h>
>  
>  struct vm_area_struct;

Yes, this is the right fix. So I will fold this into my patch.

-- 
Thanks and Regards
Srikar

  reply	other threads:[~2011-11-23  9:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23  4:28 linux-next: build failure after merge of the final tree (uprobes tree related) Stephen Rothwell
2011-11-23  9:54 ` Srikar Dronamraju [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-11-23  3:44 Stephen Rothwell
2011-11-23 10:42 ` Srikar Dronamraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123095443.GA22971@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).