linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
	sfr@canb.auug.org.au, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (akpm tree related)
Date: Wed, 30 Nov 2011 06:48:41 -0500	[thread overview]
Message-ID: <20111130114841.GB5677@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20111129220728.b3351335.akpm@linux-foundation.org>

On Tue, Nov 29, 2011 at 10:07:28PM -0800, Andrew Morton wrote:
> On Wed, 30 Nov 2011 00:40:10 -0500 (EST) David Miller <davem@davemloft.net> wrote:
> 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 30 Nov 2011 15:52:26 +1100
> > 
> > > And many more similar.
> > > 
> > > Caused (or exposed) by commit 9222aa56c0ce
> > > ("include/net/netprio_cgroup.h: various fixes") from the akpm tree.
> > > 
> > > I have reverted that commit for today.
> > 
> > Andrew, please submit networking bug fixes to the networking maintainers
> > in order to avoid problems like this in the future.
> > 
> > Unlike other subsystems, I guarentee to handle it within 24 hours, often
> > much faster.
> > 
> 
> This is my attempt to address the issues I mentioned last week.  It is
> still under development and doesn't work yet.  I thought it did.
> 
> I'm now trying to get my brain around what that code is doing with
> Kconfig symbols and net_prio_subsys_id.  I'm suspecting it's all to
> make cgroup-subsys-within-a-module appear to work.
> 
> afaict net_prio_subsys_id is an enum if CONFIG_NETPRIO_CGROUP=y and is
> an `extern int' when CONFIG_NETPRIO_CGROUP=m.  It's unclear to me why
> the extern int version or net_prio_subsys_id exists at all, really.
> 
> 
I implemented this code the same way that the net_cls cgroup does.  I'm not at
all sure whats going on in your tree, as its building as both a module and
monolitically in net-next.  I'll get it sorted today though.
Neil

  reply	other threads:[~2011-11-30 11:48 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30  4:52 linux-next: build failure after merge of the final tree (akpm tree related) Stephen Rothwell
2011-11-30  5:40 ` David Miller
2011-11-30  6:07   ` Andrew Morton
2011-11-30 11:48     ` Neil Horman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-06-06  7:25 Stephen Rothwell
2013-06-06  7:15 Stephen Rothwell
2013-06-06  6:18 Stephen Rothwell
2013-03-04  3:28 Stephen Rothwell
2013-03-04  9:22 ` Jan Kara
2013-03-04  3:10 Stephen Rothwell
2013-03-06 23:52 ` Andrew Morton
2013-01-24  5:54 Stephen Rothwell
2013-01-24 10:30 ` Shaohua Li
2013-01-24 23:22   ` Stephen Rothwell
2013-01-21  6:08 Stephen Rothwell
2013-01-21  7:17 ` Tang Chen
2012-11-09  4:16 Stephen Rothwell
2012-11-09  4:09 Stephen Rothwell
2012-11-14 22:18 ` Andrew Morton
2012-11-14 22:30   ` David Miller
2012-11-14 23:09     ` Andrew Morton
2012-11-14 23:10       ` David Miller
2012-11-09  3:58 Stephen Rothwell
2012-11-09  4:01 ` Andrew Morton
2012-11-12  0:00   ` Stephen Rothwell
2012-09-17 11:49 Stephen Rothwell
2012-09-13  8:11 Stephen Rothwell
2012-09-13 13:24 ` David Fries
2012-09-13 13:34   ` Stephen Rothwell
2012-09-14  4:20     ` David Fries
2012-09-13  8:01 Stephen Rothwell
2012-09-13 10:01 ` Shaohua Li
2012-09-13 12:29   ` Stephen Rothwell
2012-05-11  6:20 Stephen Rothwell
2012-03-14 23:44 Stephen Rothwell
2012-02-17 10:20 Stephen Rothwell
2012-02-17 12:06 ` Konstantin Khlebnikov
2012-02-19 23:04 ` Stephen Rothwell
2012-02-19 23:15   ` Andrew Morton
2012-02-17  5:30 Stephen Rothwell
2012-02-17  6:07 ` Benjamin Herrenschmidt
2012-01-20  2:02 Stephen Rothwell
2011-12-17  4:42 Stephen Rothwell
2011-12-17  5:02 ` NeilBrown
2011-11-30  4:42 Stephen Rothwell
2011-11-30  5:16 ` Andrew Morton
2011-10-05  8:23 Stephen Rothwell
2011-09-30  1:52 Stephen Rothwell
2011-09-28 10:01 Stephen Rothwell
2011-07-27  3:55 Stephen Rothwell
2011-07-01  5:45 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111130114841.GB5677@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).