linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Fries <david@fries.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (akpm tree related)
Date: Thu, 13 Sep 2012 08:24:08 -0500	[thread overview]
Message-ID: <20120913132408.GZ2608@spacedout.fries.net> (raw)
In-Reply-To: <20120913181127.862265ddb9a08758ada8405c@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

On Thu, Sep 13, 2012 at 06:11:27PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> drivers/built-in.o: In function `rtc_hctosys':
> hctosys.c:(.init.text+0x4a98): undefined reference to `rtc_hctosys_ret'
> hctosys.c:(.init.text+0x4b54): undefined reference to `rtc_hctosys_ret'
> hctosys.c:(.init.text+0x4b58): undefined reference to `rtc_hctosys_ret'

Can you post your .config?  `grep RTC .config`
It would seem to me that drivers/rtc/hctosys.c is being compiled
without drivers/rtc/class.c which now holds the global variable, but
Kconfig says that RTC_HCTOSYS 'depends on RTC_CLASS = y'.

config RTC_HCTOSYS
	depends on RTC_HCTOSYS_DEVICE
Or, how do you depend on a string value being set?

config RTC_HCTOSYS_DEVICE
	depends on RTC_CLASS = y

> Caused by commit "rtc_sysfs_show_hctosys(): display 0 if resume failed"
> from the akpm tree.  rtc_hctosys_ret was moved into class.c but protected
> by defined(CONFIG_PM) && defined(CONFIG_RTC_HCTOSYS_DEVICE) and this
> build does not have CONFIG_PM set.
> 
> I have reverted that commit for today.
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au



-- 
David Fries <david@fries.net>    PGP pub CB1EE8F0
http://fries.net/~david/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-09-13 13:24 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  8:11 linux-next: build failure after merge of the final tree (akpm tree related) Stephen Rothwell
2012-09-13 13:24 ` David Fries [this message]
2012-09-13 13:34   ` Stephen Rothwell
2012-09-14  4:20     ` David Fries
  -- strict thread matches above, loose matches on Subject: below --
2013-06-06  7:25 Stephen Rothwell
2013-06-06  7:15 Stephen Rothwell
2013-06-06  6:18 Stephen Rothwell
2013-03-04  3:28 Stephen Rothwell
2013-03-04  9:22 ` Jan Kara
2013-03-04  3:10 Stephen Rothwell
2013-03-06 23:52 ` Andrew Morton
2013-01-24  5:54 Stephen Rothwell
2013-01-24 10:30 ` Shaohua Li
2013-01-24 23:22   ` Stephen Rothwell
2013-01-21  6:08 Stephen Rothwell
2013-01-21  7:17 ` Tang Chen
2012-11-09  4:16 Stephen Rothwell
2012-11-09  4:09 Stephen Rothwell
2012-11-14 22:18 ` Andrew Morton
2012-11-14 22:30   ` David Miller
2012-11-14 23:09     ` Andrew Morton
2012-11-14 23:10       ` David Miller
2012-11-09  3:58 Stephen Rothwell
2012-11-09  4:01 ` Andrew Morton
2012-11-12  0:00   ` Stephen Rothwell
2012-09-17 11:49 Stephen Rothwell
2012-09-13  8:01 Stephen Rothwell
2012-09-13 10:01 ` Shaohua Li
2012-09-13 12:29   ` Stephen Rothwell
2012-05-11  6:20 Stephen Rothwell
2012-03-14 23:44 Stephen Rothwell
2012-02-17 10:20 Stephen Rothwell
2012-02-17 12:06 ` Konstantin Khlebnikov
2012-02-19 23:04 ` Stephen Rothwell
2012-02-19 23:15   ` Andrew Morton
2012-02-17  5:30 Stephen Rothwell
2012-02-17  6:07 ` Benjamin Herrenschmidt
2012-01-20  2:02 Stephen Rothwell
2011-12-17  4:42 Stephen Rothwell
2011-12-17  5:02 ` NeilBrown
2011-11-30  4:52 Stephen Rothwell
2011-11-30  5:40 ` David Miller
2011-11-30  6:07   ` Andrew Morton
2011-11-30 11:48     ` Neil Horman
2011-11-30  4:42 Stephen Rothwell
2011-11-30  5:16 ` Andrew Morton
2011-10-05  8:23 Stephen Rothwell
2011-09-30  1:52 Stephen Rothwell
2011-09-28 10:01 Stephen Rothwell
2011-07-27  3:55 Stephen Rothwell
2011-07-01  5:45 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120913132408.GZ2608@spacedout.fries.net \
    --to=david@fries.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).